[GitHub] nihui commented on a change in pull request #9960: [MXNET-30] Add label augmentation support in image recordio2

[GitBox <gi...@apache.org>]

nihui commented on a change in pull request #9960: [MXNET-30] Add label augmentation support in image recordio2
URL: https://github.com/apache/incubator-mxnet/pull/9960#discussion_r172752595
 
 

 ##########
 File path: src/io/image_iter_common.h
 ##########
 @@ -85,6 +85,14 @@ class ImageLabelMap {
     CHECK(it != idx2label_.end()) << "fail to find imagelabel for id " << imid;
     return mshadow::Tensor<cpu, 1>(it->second, mshadow::Shape1(label_width));
   }
+  /*! \brief find a label for corresponding index, return vector as copy */
+  inline std::vector<float> FindCopy(size_t imid) const {
 
 Review comment:
   FindCopy is borrowed from the similar existing code [1], so I use FindCopy for consistency.
   But if you do think FindLabel is better, I could update the name, and may open another PR to update the existing FindCopy code.
   
   please tell me if I need to do this.
   
   [1] https://github.com/apache/incubator-mxnet/blob/0fe04e9d778ac9c55e933ff3f21c4ddf28a4a101/src/io/iter_image_det_recordio.cc#L116

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services