Re: [PR] [FLINK-39367][connector-http] Add configurable error logging with detailed context [flink-connector-http]

["davidradl (via GitHub)" <gi...@apache.org>]

davidradl commented on code in PR #35:
URL: https://github.com/apache/flink-connector-http/pull/35#discussion_r3115878446


##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/config/HttpConnectorConfigConstants.java:
##########
@@ -164,4 +164,15 @@ public final class HttpConnectorConfigConstants {
             SOURCE_RETRY_EXP_DELAY_PREFIX + "max-backoff";
     public static final String SOURCE_RETRY_EXP_DELAY_MULTIPLIER =
             SOURCE_RETRY_EXP_DELAY_PREFIX + "backoff-multiplier";
+
+    // -------------- Error logging configuration --------------
+
+    public static final String ERROR_LOG_LEVEL = FLINK_CONNECTOR_HTTP + "error.log.level";

Review Comment:
   I think we should fit in with the [existing configuration](https://github.com/apache/flink-connector-http/blob/main/docs/content/docs/connectors/table/http.md#logging-the-http-content) based logging . We added this so that potentially sensitive information in the http messages could be obfuscated.  We agreed that it would be possible to log out the clear content for development debugging. I suggest we use the existing controls and scope and extend them to to cover sink 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org