You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by GitBox <gi...@apache.org> on 2018/09/28 06:17:37 UTC
[GitHub] shaofengshi closed pull request #269: KYLIN-3586 Fix eight
primitive boxing/unboxing problem.
shaofengshi closed pull request #269: KYLIN-3586 Fix eight primitive boxing/unboxing problem.
URL: https://github.com/apache/kylin/pull/269
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java b/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
index 073662b920..6f1dfd9144 100644
--- a/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
+++ b/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
@@ -1046,7 +1046,7 @@ public int getQueryScanFuzzyKeySplitMax() {
}
public int getQueryStorageVisitScanRangeMax() {
- return Integer.valueOf(this.getOptional("kylin.storage.hbase.max-visit-scanrange", "1000000"));
+ return Integer.parseInt(this.getOptional("kylin.storage.hbase.max-visit-scanrange", "1000000"));
}
public String getDefaultIGTStorage() {
@@ -1059,7 +1059,7 @@ public int getHBaseScanCacheRows() {
}
public float getKylinHBaseRegionCut() {
- return Float.valueOf(getOptional("kylin.storage.hbase.region-cut-gb", "5.0"));
+ return Float.parseFloat(getOptional("kylin.storage.hbase.region-cut-gb", "5.0"));
}
public int getHBaseScanMaxResultSize() {
@@ -1075,11 +1075,11 @@ public String getHbaseDefaultEncoding() {
}
public int getHbaseDefaultBlockSize() {
- return Integer.valueOf(getOptional("kylin.storage.hbase.block-size-bytes", "1048576"));
+ return Integer.parseInt(getOptional("kylin.storage.hbase.block-size-bytes", "1048576"));
}
public int getHbaseSmallFamilyBlockSize() {
- return Integer.valueOf(getOptional("kylin.storage.hbase.small-family-block-size-bytes", "65536"));
+ return Integer.parseInt(getOptional("kylin.storage.hbase.small-family-block-size-bytes", "65536"));
}
public String getKylinOwner() {
@@ -1242,15 +1242,15 @@ public String getSparkAdditionalJars() {
}
public float getSparkRDDPartitionCutMB() {
- return Float.valueOf(getOptional("kylin.engine.spark.rdd-partition-cut-mb", "10.0"));
+ return Float.parseFloat(getOptional("kylin.engine.spark.rdd-partition-cut-mb", "10.0"));
}
public int getSparkMinPartition() {
- return Integer.valueOf(getOptional("kylin.engine.spark.min-partition", "1"));
+ return Integer.parseInt(getOptional("kylin.engine.spark.min-partition", "1"));
}
public int getSparkMaxPartition() {
- return Integer.valueOf(getOptional("kylin.engine.spark.max-partition", "5000"));
+ return Integer.parseInt(getOptional("kylin.engine.spark.max-partition", "5000"));
}
public String getSparkStorageLevel() {
@@ -1266,10 +1266,10 @@ public boolean isSparkSanityCheckEnabled() {
// ============================================================================
public boolean isDictionaryEnumeratorEnabled() {
- return Boolean.valueOf(getOptional("kylin.query.enable-dict-enumerator", "false"));
+ return Boolean.parseBoolean(getOptional("kylin.query.enable-dict-enumerator", "false"));
}
- public Boolean isEnumerableRulesEnabled() {
+ public boolean isEnumerableRulesEnabled() {
return Boolean.parseBoolean(getOptional("kylin.query.calcite.enumerable-rules-enabled", "false"));
}
@@ -1278,7 +1278,7 @@ public boolean isReduceExpressionsRulesEnabled() {
}
public boolean isConvertCreateTableToWith() {
- return Boolean.valueOf(getOptional("kylin.query.convert-create-table-to-with", "false"));
+ return Boolean.parseBoolean(getOptional("kylin.query.convert-create-table-to-with", "false"));
}
/**
@@ -1318,16 +1318,16 @@ public Properties getCalciteExtrasProperties() {
// check KYLIN-3358, need deploy coprocessor if enabled
// finally should be deprecated
public boolean isDynamicColumnEnabled() {
- return Boolean.valueOf(getOptional("kylin.query.enable-dynamic-column", "false"));
+ return Boolean.parseBoolean(getOptional("kylin.query.enable-dynamic-column", "false"));
}
//check KYLIN-1684, in most cases keep the default value
public boolean isSkippingEmptySegments() {
- return Boolean.valueOf(getOptional("kylin.query.skip-empty-segments", "true"));
+ return Boolean.parseBoolean(getOptional("kylin.query.skip-empty-segments", "true"));
}
public boolean isDisableCubeNoAggSQL() {
- return Boolean.valueOf(getOptional("kylin.query.disable-cube-noagg-sql", "false"));
+ return Boolean.parseBoolean(getOptional("kylin.query.disable-cube-noagg-sql", "false"));
}
public boolean isStreamAggregateEnabled() {
@@ -1529,11 +1529,11 @@ public int getPoolMinIdle() {
}
public boolean isTableACLEnabled() {
- return Boolean.valueOf(this.getOptional("kylin.query.security.table-acl-enabled", "true"));
+ return Boolean.parseBoolean(this.getOptional("kylin.query.security.table-acl-enabled", "true"));
}
public boolean isEscapeDefaultKeywordEnabled() {
- return Boolean.valueOf(this.getOptional("kylin.query.escape-default-keyword", "false"));
+ return Boolean.parseBoolean(this.getOptional("kylin.query.escape-default-keyword", "false"));
}
public String getQueryRealizationFilter() {
@@ -1566,7 +1566,7 @@ public int getWorkersPerServer() {
}
public long getSequenceExpireTime() {
- return Long.valueOf(this.getOptional("kylin.server.sequence-sql.expire-time", "86400000"));//default a day
+ return Long.parseLong(this.getOptional("kylin.server.sequence-sql.expire-time", "86400000"));//default a day
}
public boolean getQueryMetricsEnabled() {
@@ -1583,11 +1583,11 @@ public boolean getQueryMetrics2Enabled() {
}
public int getServerUserCacheExpireSeconds() {
- return Integer.valueOf(this.getOptional("kylin.server.auth-user-cache.expire-seconds", "300"));
+ return Integer.parseInt(this.getOptional("kylin.server.auth-user-cache.expire-seconds", "300"));
}
public int getServerUserCacheMaxEntries() {
- return Integer.valueOf(this.getOptional("kylin.server.auth-user-cache.max-entries", "100"));
+ return Integer.parseInt(this.getOptional("kylin.server.auth-user-cache.max-entries", "100"));
}
public String getExternalAclProvider() {
@@ -1651,11 +1651,11 @@ public String getPropertiesWhiteList() {
// ============================================================================
public int getRestClientDefaultMaxPerRoute() {
- return Integer.valueOf(this.getOptional("kylin.restclient.connection.default-max-per-route", "20"));
+ return Integer.parseInt(this.getOptional("kylin.restclient.connection.default-max-per-route", "20"));
}
public int getRestClientMaxTotal() {
- return Integer.valueOf(this.getOptional("kylin.restclient.connection.max-total", "200"));
+ return Integer.parseInt(this.getOptional("kylin.restclient.connection.max-total", "200"));
}
// ============================================================================
@@ -1680,11 +1680,11 @@ public String getPerfLoggerClassName() {
}
public boolean isShowingGuiTraceToggle() {
- return Boolean.valueOf(getOptional("kylin.htrace.show-gui-trace-toggle", "false"));
+ return Boolean.parseBoolean(getOptional("kylin.htrace.show-gui-trace-toggle", "false"));
}
public boolean isHtraceTracingEveryQuery() {
- return Boolean.valueOf(getOptional("kylin.htrace.trace-every-query", "false"));
+ return Boolean.parseBoolean(getOptional("kylin.htrace.trace-every-query", "false"));
}
public boolean isKylinMetricsMonitorEnabled() {
@@ -1772,7 +1772,7 @@ public String getMetadataDialect() {
}
public boolean isJsonAlwaysSmallCell() {
- return Boolean.valueOf(getOptional("kylin.metadata.jdbc.json-always-small-cell", "true"));
+ return Boolean.parseBoolean(getOptional("kylin.metadata.jdbc.json-always-small-cell", "true"));
}
public int getSmallCellMetadataWarningThreshold() {
diff --git a/core-common/src/main/java/org/apache/kylin/common/util/MailService.java b/core-common/src/main/java/org/apache/kylin/common/util/MailService.java
index 25bc03c5e4..44e1d9c52a 100644
--- a/core-common/src/main/java/org/apache/kylin/common/util/MailService.java
+++ b/core-common/src/main/java/org/apache/kylin/common/util/MailService.java
@@ -93,7 +93,7 @@ public boolean sendMail(List<String> receivers, String subject, String content,
if (starttlsEnabled) {
email.setSslSmtpPort(port);
} else {
- email.setSmtpPort(Integer.valueOf(port));
+ email.setSmtpPort(Integer.parseInt(port));
}
if (username != null && username.trim().length() > 0) {
diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ExtractTupleFilter.java b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ExtractTupleFilter.java
index 591e64b7d9..8c2ba942f6 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ExtractTupleFilter.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ExtractTupleFilter.java
@@ -68,7 +68,7 @@ public boolean evaluate(IEvaluatableTuple tuple, IFilterCodeSystem<?> cs) {
}
// extract date
- this.date = extractDate(extractType, Integer.valueOf(tupleValue));
+ this.date = extractDate(extractType, Integer.parseInt(tupleValue));
return true;
}
diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/TimeConditionLiteralsReplacer.java b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/TimeConditionLiteralsReplacer.java
index e4b5ba3622..0301d36890 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/TimeConditionLiteralsReplacer.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/TimeConditionLiteralsReplacer.java
@@ -82,7 +82,7 @@ private String formatTime(String dateStr, DataType dataType) {
return dateStr;
}
- long millis = Long.valueOf(dateStr);
+ long millis = Long.parseLong(dateStr);
if (dataType.isTimestamp()) {
return DateFormat.formatToTimeStr(millis);
} else if (dataType.isDate()) {
diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/UDF/MassInTupleFilter.java b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/UDF/MassInTupleFilter.java
index edfde437ce..d0ff92e6be 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/UDF/MassInTupleFilter.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/UDF/MassInTupleFilter.java
@@ -150,7 +150,7 @@ public void deserialize(IFilterCodeSystem<?> cs, ByteBuffer buffer) {
filterTableName = BytesUtil.readUTFString(buffer);
filterTableResourceIdentifier = BytesUtil.readUTFString(buffer);
filterTableType = Functions.FilterTableType.valueOf(BytesUtil.readUTFString(buffer));
- reverse = Boolean.valueOf(BytesUtil.readUTFString(buffer));
+ reverse = Boolean.parseBoolean(BytesUtil.readUTFString(buffer));
}
public static boolean containsMassInTupleFilter(TupleFilter filter) {
diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/tuple/Tuple.java b/core-metadata/src/main/java/org/apache/kylin/metadata/tuple/Tuple.java
index a299216ad4..cd2cfe316c 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/tuple/Tuple.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/tuple/Tuple.java
@@ -178,7 +178,7 @@ public static long getTs(ITuple row, TblColRef partitionCol) {
if (partitionCol.getDatatype().equals("date")) {
return epicDaysToMillis(Integer.valueOf(row.getValue(partitionCol).toString()));
} else {
- return Long.valueOf(row.getValue(partitionCol).toString());
+ return Long.parseLong(row.getValue(partitionCol).toString());
}
}
diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/MapReduceExecutable.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/MapReduceExecutable.java
index ae285ccd94..b26e40fb3a 100755
--- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/MapReduceExecutable.java
+++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/MapReduceExecutable.java
@@ -279,7 +279,7 @@ public void setCounterSaveAs(String value) {
conf.set(entry.getKey(), entry.getValue());
}
if (conf.get("mapreduce.job.is-mem-hungry") != null
- && Boolean.valueOf(conf.get("mapreduce.job.is-mem-hungry"))) {
+ && Boolean.parseBoolean(conf.get("mapreduce.job.is-mem-hungry"))) {
for (Map.Entry<String, String> entry : CubeManager.getInstance(config).getCube(cubeName).getConfig()
.getMemHungryConfigOverride().entrySet()) {
conf.set(entry.getKey(), entry.getValue());
diff --git a/query/src/main/java/org/apache/kylin/query/util/DefaultQueryTransformer.java b/query/src/main/java/org/apache/kylin/query/util/DefaultQueryTransformer.java
index f32e562cb6..5376493884 100644
--- a/query/src/main/java/org/apache/kylin/query/util/DefaultQueryTransformer.java
+++ b/query/src/main/java/org/apache/kylin/query/util/DefaultQueryTransformer.java
@@ -134,7 +134,7 @@ public String transform(String sql, String project, String defaultSchema) {
if (!m.find())
break;
- int value = (int) Math.floor(Double.valueOf(m.group(2)));
+ int value = (int) Math.floor(Double.parseDouble(m.group(2)));
sql = sql.substring(0, m.start(1)) + "'" + value + "'" + sql.substring(m.end(3));
}
diff --git a/server-base/src/main/java/org/apache/kylin/rest/job/HybridCubeCLI.java b/server-base/src/main/java/org/apache/kylin/rest/job/HybridCubeCLI.java
index 443eba6021..4e490c82b7 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/job/HybridCubeCLI.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/job/HybridCubeCLI.java
@@ -116,7 +116,7 @@ protected void execute(OptionsHelper optionsHelper) throws Exception {
String projectName = optionsHelper.getOptionValue(OPTION_PROJECT);
String modelName = optionsHelper.getOptionValue(OPTION_MODEL);
String cubeNamesStr = optionsHelper.getOptionValue(OPTION_CUBES);
- boolean checkCubeSize = optionsHelper.hasOption(OPTION_CHECK) ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_CHECK)) : true;
+ boolean checkCubeSize = optionsHelper.hasOption(OPTION_CHECK) ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_CHECK)) : true;
HybridInstance hybridInstance = hybridManager.getHybridInstance(hybridName);
diff --git a/server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java b/server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java
index 65054c425d..053269a3a4 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java
@@ -1087,23 +1087,23 @@ private void setParam(PreparedStatement preparedState, int index, PrepareSqlRequ
break;
case PRIMITIVE_INT:
case INTEGER:
- preparedState.setInt(index, isNull ? 0 : Integer.valueOf(param.getValue()));
+ preparedState.setInt(index, isNull ? 0 : Integer.parseInt(param.getValue()));
break;
case PRIMITIVE_SHORT:
case SHORT:
- preparedState.setShort(index, isNull ? 0 : Short.valueOf(param.getValue()));
+ preparedState.setShort(index, isNull ? 0 : Short.parseShort(param.getValue()));
break;
case PRIMITIVE_LONG:
case LONG:
- preparedState.setLong(index, isNull ? 0 : Long.valueOf(param.getValue()));
+ preparedState.setLong(index, isNull ? 0 : Long.parseLong(param.getValue()));
break;
case PRIMITIVE_FLOAT:
case FLOAT:
- preparedState.setFloat(index, isNull ? 0 : Float.valueOf(param.getValue()));
+ preparedState.setFloat(index, isNull ? 0 : Float.parseFloat(param.getValue()));
break;
case PRIMITIVE_DOUBLE:
case DOUBLE:
- preparedState.setDouble(index, isNull ? 0 : Double.valueOf(param.getValue()));
+ preparedState.setDouble(index, isNull ? 0 : Double.parseDouble(param.getValue()));
break;
case PRIMITIVE_BOOLEAN:
case BOOLEAN:
@@ -1111,7 +1111,7 @@ private void setParam(PreparedStatement preparedState, int index, PrepareSqlRequ
break;
case PRIMITIVE_BYTE:
case BYTE:
- preparedState.setByte(index, isNull ? 0 : Byte.valueOf(param.getValue()));
+ preparedState.setByte(index, isNull ? 0 : Byte.parseByte(param.getValue()));
break;
case JAVA_UTIL_DATE:
case JAVA_SQL_DATE:
diff --git a/source-kafka/src/main/java/org/apache/kylin/source/kafka/DefaultTimeParser.java b/source-kafka/src/main/java/org/apache/kylin/source/kafka/DefaultTimeParser.java
index 4bcd572f19..3b85b0bd8b 100644
--- a/source-kafka/src/main/java/org/apache/kylin/source/kafka/DefaultTimeParser.java
+++ b/source-kafka/src/main/java/org/apache/kylin/source/kafka/DefaultTimeParser.java
@@ -41,7 +41,7 @@ public long parseTime(String time) throws IllegalArgumentException {
t = 0;
} else {
try {
- t = Long.valueOf(time);
+ t = Long.parseLong(time);
} catch (NumberFormatException e) {
throw new IllegalArgumentException(e);
}
diff --git a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableHFilesBulkLoadJob.java b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableHFilesBulkLoadJob.java
index 5598ed9ed5..7e734db383 100644
--- a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableHFilesBulkLoadJob.java
+++ b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableHFilesBulkLoadJob.java
@@ -61,7 +61,7 @@ public int run(String[] args) throws Exception {
ExtTableSnapshotInfoManager extTableSnapshotInfoManager = ExtTableSnapshotInfoManager.getInstance(kylinConfig);
ExtTableSnapshotInfo snapshot = extTableSnapshotInfoManager.getSnapshot(tableName, snapshotID);
- long srcTableRowCnt = Long.valueOf(job.findExtraInfoBackward(BatchConstants.LOOKUP_EXT_SNAPSHOT_SRC_RECORD_CNT_PFX + tableName, "-1"));
+ long srcTableRowCnt = Long.parseLong(job.findExtraInfoBackward(BatchConstants.LOOKUP_EXT_SNAPSHOT_SRC_RECORD_CNT_PFX + tableName, "-1"));
logger.info("update table:{} snapshot row count:{}", tableName, srcTableRowCnt);
snapshot.setRowCnt(srcTableRowCnt);
snapshot.setLastBuildTime(System.currentTimeMillis());
diff --git a/tool/src/main/java/org/apache/kylin/tool/AbstractInfoExtractor.java b/tool/src/main/java/org/apache/kylin/tool/AbstractInfoExtractor.java
index eb59d2024c..54f76043b0 100644
--- a/tool/src/main/java/org/apache/kylin/tool/AbstractInfoExtractor.java
+++ b/tool/src/main/java/org/apache/kylin/tool/AbstractInfoExtractor.java
@@ -85,9 +85,9 @@ protected Options getOptions() {
protected void execute(OptionsHelper optionsHelper) throws Exception {
String exportDest = optionsHelper.getOptionValue(options.getOption("destDir"));
boolean shouldCompress = optionsHelper.hasOption(OPTION_COMPRESS)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_COMPRESS)) : true;
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_COMPRESS)) : true;
boolean isSubmodule = optionsHelper.hasOption(OPTION_SUBMODULE)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_SUBMODULE)) : false;
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_SUBMODULE)) : false;
packageType = optionsHelper.getOptionValue(OPTION_PACKAGETYPE);
if (packageType == null)
diff --git a/tool/src/main/java/org/apache/kylin/tool/CubeMetaExtractor.java b/tool/src/main/java/org/apache/kylin/tool/CubeMetaExtractor.java
index 652ae8a1b3..5cf035072b 100644
--- a/tool/src/main/java/org/apache/kylin/tool/CubeMetaExtractor.java
+++ b/tool/src/main/java/org/apache/kylin/tool/CubeMetaExtractor.java
@@ -166,16 +166,16 @@ public CubeMetaExtractor() {
@Override
protected void executeExtract(OptionsHelper optionsHelper, File exportDir) throws Exception {
includeSegments = optionsHelper.hasOption(OPTION_INCLUDE_SEGMENTS)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_INCLUDE_SEGMENTS))
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_INCLUDE_SEGMENTS))
: true;
includeJobs = optionsHelper.hasOption(OPTION_INCLUDE_JOB)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_INCLUDE_JOB))
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_INCLUDE_JOB))
: false;
includeSegmentDetails = optionsHelper.hasOption(OPTION_INCLUDE_SEGMENT_DETAILS)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_INCLUDE_SEGMENT_DETAILS))
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_INCLUDE_SEGMENT_DETAILS))
: false;
onlyJobOutput = optionsHelper.hasOption(OPTION_INCLUDE_ONLY_JOB_OUTPUT)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_INCLUDE_ONLY_JOB_OUTPUT))
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_INCLUDE_ONLY_JOB_OUTPUT))
: true;
storageType = optionsHelper.hasOption(OPTION_STORAGE_TYPE) ? optionsHelper.getOptionValue(OPTION_STORAGE_TYPE)
: null;
diff --git a/tool/src/main/java/org/apache/kylin/tool/CubeMetaIngester.java b/tool/src/main/java/org/apache/kylin/tool/CubeMetaIngester.java
index bdd849c79f..a8e0ab3fb5 100644
--- a/tool/src/main/java/org/apache/kylin/tool/CubeMetaIngester.java
+++ b/tool/src/main/java/org/apache/kylin/tool/CubeMetaIngester.java
@@ -94,11 +94,11 @@ protected void execute(OptionsHelper optionsHelper) throws Exception {
kylinConfig = KylinConfig.getInstanceFromEnv();
if (optionsHelper.hasOption(OPTION_FORCE_INGEST)) {
- forceIngest = Boolean.valueOf(optionsHelper.getOptionValue(OPTION_FORCE_INGEST));
+ forceIngest = Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_FORCE_INGEST));
}
if (optionsHelper.hasOption(OPTION_OVERWRITE_TABLES)) {
- overwriteTables = Boolean.valueOf(optionsHelper.getOptionValue(OPTION_OVERWRITE_TABLES));
+ overwriteTables = Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_OVERWRITE_TABLES));
}
targetProjectName = optionsHelper.getOptionValue(OPTION_PROJECT);
diff --git a/tool/src/main/java/org/apache/kylin/tool/DiagnosisInfoCLI.java b/tool/src/main/java/org/apache/kylin/tool/DiagnosisInfoCLI.java
index d960f8f6a9..9063e9e172 100644
--- a/tool/src/main/java/org/apache/kylin/tool/DiagnosisInfoCLI.java
+++ b/tool/src/main/java/org/apache/kylin/tool/DiagnosisInfoCLI.java
@@ -122,23 +122,23 @@ public static void main(String[] args) {
protected void executeExtract(final OptionsHelper optionsHelper, final File exportDir) throws IOException {
final String projectInput = optionsHelper.getOptionValue(options.getOption("project"));
final boolean includeConf = optionsHelper.hasOption(OPTION_INCLUDE_CONF)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_INCLUDE_CONF))
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_INCLUDE_CONF))
: true;
final boolean includeHBase = optionsHelper.hasOption(OPTION_INCLUDE_HBASE)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_INCLUDE_HBASE))
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_INCLUDE_HBASE))
: true;
final boolean includeClient = optionsHelper.hasOption(OPTION_INCLUDE_CLIENT)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_INCLUDE_CLIENT))
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_INCLUDE_CLIENT))
: true;
final boolean includeJob = optionsHelper.hasOption(OPTION_INCLUDE_JOB)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_INCLUDE_JOB))
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_INCLUDE_JOB))
: true;
final int threadsNum = optionsHelper.hasOption(OPTION_THREADS)
- ? Integer.valueOf(optionsHelper.getOptionValue(OPTION_THREADS))
+ ? Integer.parseInt(optionsHelper.getOptionValue(OPTION_THREADS))
: DEFAULT_PARALLEL_SIZE;
final String projectNames = StringUtils.join(getProjects(projectInput), ",");
final int period = optionsHelper.hasOption(OPTION_PERIOD)
- ? Integer.valueOf(optionsHelper.getOptionValue(OPTION_PERIOD))
+ ? Integer.parseInt(optionsHelper.getOptionValue(OPTION_PERIOD))
: DEFAULT_PERIOD;
logger.info("Start diagnosis info extraction in {} threads.", threadsNum);
diff --git a/tool/src/main/java/org/apache/kylin/tool/JobDiagnosisInfoCLI.java b/tool/src/main/java/org/apache/kylin/tool/JobDiagnosisInfoCLI.java
index c8e144adcd..a0c846533b 100644
--- a/tool/src/main/java/org/apache/kylin/tool/JobDiagnosisInfoCLI.java
+++ b/tool/src/main/java/org/apache/kylin/tool/JobDiagnosisInfoCLI.java
@@ -100,16 +100,16 @@ public static void main(String[] args) {
protected void executeExtract(OptionsHelper optionsHelper, File exportDir) throws Exception {
String kylinJobId = optionsHelper.getOptionValue(OPTION_JOB_ID);
boolean includeCube = optionsHelper.hasOption(OPTION_INCLUDE_CUBE)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_INCLUDE_CUBE))
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_INCLUDE_CUBE))
: true;
boolean includeYarnLogs = optionsHelper.hasOption(OPTION_INCLUDE_YARN_LOGS)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_INCLUDE_YARN_LOGS))
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_INCLUDE_YARN_LOGS))
: true;
boolean includeClient = optionsHelper.hasOption(OPTION_INCLUDE_CLIENT)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_INCLUDE_CLIENT))
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_INCLUDE_CLIENT))
: true;
boolean includeConf = optionsHelper.hasOption(OPTION_INCLUDE_CONF)
- ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_INCLUDE_CONF))
+ ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_INCLUDE_CONF))
: true;
// dump job output
diff --git a/tool/src/main/java/org/apache/kylin/tool/MetadataCleanupJob.java b/tool/src/main/java/org/apache/kylin/tool/MetadataCleanupJob.java
index cf17f82710..1e5214dd2a 100644
--- a/tool/src/main/java/org/apache/kylin/tool/MetadataCleanupJob.java
+++ b/tool/src/main/java/org/apache/kylin/tool/MetadataCleanupJob.java
@@ -57,7 +57,7 @@ protected void execute(OptionsHelper optionsHelper) throws Exception {
logger.info("jobThreshold option value: '" + optionsHelper.getOptionValue(OPTION_THRESHOLD_FOR_JOB) + "'");
boolean delete = Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_DELETE));
int jobOutdatedDays = optionsHelper.hasOption(OPTION_THRESHOLD_FOR_JOB)
- ? Integer.valueOf(optionsHelper.getOptionValue(OPTION_THRESHOLD_FOR_JOB))
+ ? Integer.parseInt(optionsHelper.getOptionValue(OPTION_THRESHOLD_FOR_JOB))
: DEFAULT_JOB_OUTDATED_THRESHOLD_DAYS;
new org.apache.kylin.rest.job.MetadataCleanupJob().cleanup(delete, jobOutdatedDays);
diff --git a/tool/src/main/java/org/apache/kylin/tool/MrJobInfoExtractor.java b/tool/src/main/java/org/apache/kylin/tool/MrJobInfoExtractor.java
index dab49b2fad..31c0a5c688 100644
--- a/tool/src/main/java/org/apache/kylin/tool/MrJobInfoExtractor.java
+++ b/tool/src/main/java/org/apache/kylin/tool/MrJobInfoExtractor.java
@@ -151,7 +151,7 @@ private String saveHttpResponseQuietly(File dest, String url) {
@Override
protected void executeExtract(OptionsHelper optionsHelper, File exportDir) throws Exception {
try {
- boolean includeTaskDetails = optionsHelper.hasOption(OPTION_INCLUDE_DETAILS) ? Boolean.valueOf(optionsHelper.getOptionValue(OPTION_INCLUDE_DETAILS)) : true;
+ boolean includeTaskDetails = optionsHelper.hasOption(OPTION_INCLUDE_DETAILS) ? Boolean.parseBoolean(optionsHelper.getOptionValue(OPTION_INCLUDE_DETAILS)) : true;
String mrJobId = optionsHelper.getOptionValue(OPTION_MR_JOB_ID);
extractRestCheckUrl();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services