You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "AnandInguva (via GitHub)" <gi...@apache.org> on 2023/04/05 15:39:58 UTC
[GitHub] [beam] AnandInguva opened a new pull request, #26121: Python 3.11 support with dill monkey patching
AnandInguva opened a new pull request, #26121:
URL: https://github.com/apache/beam/pull/26121
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on a diff in pull request #26121: Support Python 3.11 (#26121)
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on code in PR #26121:
URL: https://github.com/apache/beam/pull/26121#discussion_r1159950048
##########
.test-infra/jenkins/job_PreCommit_Portable_Python.groovy:
##########
@@ -40,15 +42,17 @@ builder.build {
// Due to BEAM-7993, run multiple Python version of portable precommit
// tests in parallel could lead python3 container crash. We manually
// config gradle steps here to run tests in sequential.
+ def lowestSupported = LOWEST_SUPPORTED.replace('.', '')
+ def highestSupported = HIGHEST_SUPPORTED.replace('.', '')
steps {
gradle {
rootBuildScriptDir(commonJobProperties.checkoutDir)
- tasks(':sdks:python:test-suites:portable:py37:preCommitPy37')
+ tasks(':sdks:python:test-suites:portable:py${lowestSupported}:preCommitPy${lowestSupported}')
commonJobProperties.setGradleSwitches(delegate)
}
gradle {
rootBuildScriptDir(commonJobProperties.checkoutDir)
- tasks(':sdks:python:test-suites:portable:py310:preCommitPy310')
+ tasks(':sdks:python:test-suites:portable:${highestSupported}:preCommitPy${highestSupported}')
Review Comment:
Looks like these changes are causing [Python Portable Precommit to fail](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Commit/27558/console) with:
```
Project 'py${lowestSupported}' not found in project ':sdks:python:test-suites:portable'
```
Need to use double quotes when using embedded values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #26121: Python 3.11 support with dill monkey patching
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26121:
URL: https://github.com/apache/beam/pull/26121#issuecomment-1498022484
Verified that this PR is identical to https://github.com/apache/beam/pull/26120 modulo comment-only changes to base_image_requirements_manual.txt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #26121: Python 3.11 support with dill monkey patching
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26121:
URL: https://github.com/apache/beam/pull/26121#issuecomment-1498022697
Merging based on test signal from https://github.com/apache/beam/pull/26120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on a diff in pull request #26121: Support Python 3.11 (#26121)
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on code in PR #26121:
URL: https://github.com/apache/beam/pull/26121#discussion_r1159952133
##########
.test-infra/jenkins/job_PreCommit_Portable_Python.groovy:
##########
@@ -40,15 +42,17 @@ builder.build {
// Due to BEAM-7993, run multiple Python version of portable precommit
// tests in parallel could lead python3 container crash. We manually
// config gradle steps here to run tests in sequential.
+ def lowestSupported = LOWEST_SUPPORTED.replace('.', '')
+ def highestSupported = HIGHEST_SUPPORTED.replace('.', '')
steps {
gradle {
rootBuildScriptDir(commonJobProperties.checkoutDir)
- tasks(':sdks:python:test-suites:portable:py37:preCommitPy37')
+ tasks(':sdks:python:test-suites:portable:py${lowestSupported}:preCommitPy${lowestSupported}')
commonJobProperties.setGradleSwitches(delegate)
}
gradle {
rootBuildScriptDir(commonJobProperties.checkoutDir)
- tasks(':sdks:python:test-suites:portable:py310:preCommitPy310')
+ tasks(':sdks:python:test-suites:portable:${highestSupported}:preCommitPy${highestSupported}')
Review Comment:
Fix in #26151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #26121: Python 3.11 support with dill monkey patching
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #26121:
URL: https://github.com/apache/beam/pull/26121#issuecomment-1497977782
Run Python_Integration PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26121: Python 3.11 support with dill monkey patching
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26121:
URL: https://github.com/apache/beam/pull/26121#issuecomment-1497850596
## [Codecov](https://codecov.io/gh/apache/beam/pull/26121?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#26121](https://codecov.io/gh/apache/beam/pull/26121?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6b2800) into [master](https://codecov.io/gh/apache/beam/commit/ed93a34524d8d77976a0fccce7862df64c353a42?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed93a34) will **decrease** coverage by `0.02%`.
> The diff coverage is `17.64%`.
```diff
@@ Coverage Diff @@
## master #26121 +/- ##
==========================================
- Coverage 71.18% 71.17% -0.02%
==========================================
Files 787 787
Lines 103296 103311 +15
==========================================
- Hits 73530 73529 -1
- Misses 28278 28294 +16
Partials 1488 1488
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `79.85% <17.64%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/26121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/dill\_pickler.py](https://codecov.io/gh/apache/beam/pull/26121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvZGlsbF9waWNrbGVyLnB5) | `77.91% <6.66%> (-7.23%)` | :arrow_down: |
| [sdks/python/apache\_beam/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/26121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vX19pbml0X18ucHk=) | `85.00% <100.00%> (ø)` | |
| [...apache\_beam/runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/26121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=) | `77.02% <100.00%> (ø)` | |
... and [9 files with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/26121/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #26121: Python 3.11 support with dill monkey patching
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn merged PR #26121:
URL: https://github.com/apache/beam/pull/26121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org