You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/15 12:34:40 UTC
[GitHub] [arrow-rs] martin-g opened a new pull request, #1881: Issue #1876: Explicitly declare the used features for each dependency in parquet
martin-g opened a new pull request, #1881:
URL: https://github.com/apache/arrow-rs/pull/1881
# Which issue does this PR close?
This is the third PR for https://github.com/apache/arrow-rs/issues/1876.
It changes just parquet/Cargo.toml.
The PR does not upgrade the dependencies!
Previous PRs:
* https://github.com/apache/arrow-rs/pull/1877 - module arrow
* https://github.com/apache/arrow-rs/pull/1880 - module arrow-flight
# Rationale for this change
Reduce the disk and CPU usage at build time.
# What changes are included in this PR?
N/A
# Are there any user-facing changes?
N/A
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] martin-g commented on pull request #1881: Issue #1876: Explicitly declare the used features for each dependency in parquet
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1881:
URL: https://github.com/apache/arrow-rs/pull/1881#issuecomment-1158691086
I think I broke the build.
```
$ cargo +nightly build --all-features
Compiling parquet v16.0.0 (/home/martin/git/apache/arrow-rs/parquet)
error[E0432]: unresolved import `rand::thread_rng`
--> parquet/src/util/test_common/rand_gen.rs:20:5
|
20 | thread_rng, Rng,
| ^^^^^^^^^^ no `thread_rng` in the root
error[E0433]: failed to resolve: could not find `test_util` in `util`
--> parquet/src/util/test_common/file_util.rs:23:41
|
23 | PathBuf::from_str(&arrow::util::test_util::parquet_test_data()).unwrap();
| ^^^^^^^^^ could not find `test_util` in `util`
warning: unused import: `Rng`
--> parquet/src/util/test_common/rand_gen.rs:20:17
|
20 | thread_rng, Rng,
| ^^^
|
= note: `#[warn(unused_imports)]` on by default
Some errors have detailed explanations: E0432, E0433.
For more information about an error, try `rustc --explain E0432`.
warning: `parquet` (lib) generated 1 warning
error: could not compile `parquet` due to 2 previous errors; 1 warning emitted
```
It is interesting that the CI is green...
I will send a new PR to fix it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #1881: Issue #1876: Explicitly declare the used features for each dependency in parquet
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #1881:
URL: https://github.com/apache/arrow-rs/pull/1881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org