You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tamaya.apache.org by Aaron Coburn <ac...@apache.org> on 2019/05/14 15:52:36 UTC
Sonar integration and recent commits
Hi All,
it seems that the sonar integration for the core tamaya repository has been
removed. Were those commits reverted? Or maybe a force-push? A number of
the recent changes seem no longer to be present.
Aaron
Re: Sonar integration and recent commits
Posted by "P. Ottlinger" <po...@apache.org>.
Hi Anatole,
a lot of work is missing ..... pls create a branch and work on that.
Forking is not that easy I guess.
Cheers,
Phil
Am 15.05.19 um 08:03 schrieb Anatole Tresch:
> I did a merge but I also did a reset on the travis before pulling so I do
> not overwrite any changes. I never did a force commit/push. Sorry, if
> something went wrong nevertheless, just restore the last version on that
> file🙏
>
> Aaron Coburn <ac...@apache.org> schrieb am Di., 14. Mai 2019, 17:52:
>
>> Hi All,
>> it seems that the sonar integration for the core tamaya repository has been
>> removed. Were those commits reverted? Or maybe a force-push? A number of
>> the recent changes seem no longer to be present.
>>
>> Aaron
>>
>
Re: Sonar integration and recent commits
Posted by "P. Ottlinger" <po...@apache.org>.
Anatole, I tried to reapply most of the stuff I saw,
please go ahead and fix the new sonar warnings .....
https://sonarcloud.io/project/issues?id=apache_incubator-tamaya&resolved=false
I assume your changes in sandbox and extensions did also overwrite some
stuff - can you have a look please?
Thanks,
Phil
Am 15.05.19 um 08:03 schrieb Anatole Tresch:
> I did a merge but I also did a reset on the travis before pulling so I do
> not overwrite any changes. I never did a force commit/push. Sorry, if
> something went wrong nevertheless, just restore the last version on that
> file🙏
>
> Aaron Coburn <ac...@apache.org> schrieb am Di., 14. Mai 2019, 17:52:
>
>> Hi All,
>> it seems that the sonar integration for the core tamaya repository has been
>> removed. Were those commits reverted? Or maybe a force-push? A number of
>> the recent changes seem no longer to be present.
>>
>> Aaron
>>
>
Re: Sonar integration and recent commits
Posted by Anatole Tresch <at...@gmail.com>.
I did a merge but I also did a reset on the travis before pulling so I do
not overwrite any changes. I never did a force commit/push. Sorry, if
something went wrong nevertheless, just restore the last version on that
file🙏
Aaron Coburn <ac...@apache.org> schrieb am Di., 14. Mai 2019, 17:52:
> Hi All,
> it seems that the sonar integration for the core tamaya repository has been
> removed. Were those commits reverted? Or maybe a force-push? A number of
> the recent changes seem no longer to be present.
>
> Aaron
>
Re: Sonar integration and recent commits
Posted by "P. Ottlinger" <po...@apache.org>.
Am 14.05.19 um 17:52 schrieb Aaron Coburn:
> Hi All,
> it seems that the sonar integration for the core tamaya repository has been
> removed. Were those commits reverted? Or maybe a force-push? A number of
> the recent changes seem no longer to be present.
@Anatole: where did you checkout? Gitbox or github?
Maybe there's a difference .... apart from that I just experienced the
same problems with contributions in other projects, which is not that
motivating ;)
Thanks for spotting it Aaron and William.
Phil
Re: Sonar integration and recent commits
Posted by Anatole Tresch <at...@gmail.com>.
Ho William
I agree completely with you and will now recreate my work environment using
my own github clone repo.
Thanks, Anatole
William Lieurance <wi...@namikoda.com> schrieb am Di., 14. Mai
2019, 20:50:
> It looks like 0ddb859d57c71515e417a33e77d69355c753bb9b ("Merged with
> master changes") didn't pick up the travis yaml changes. Git's CLI, and
> github's web as well, isn't great at showing all the three-way changes
> added in a merge commit. Do a `git diff 8bcf8106..d5d3b748` to see what
> got modified on top of the changes in 0ddb859 alongside it.
>
> Anatole, does that sound right? I feel like this might have gotten seen in
> a pull request, and is probably a good reason to use those more often.
>
> --William
>
> ________________________________________
> From: Aaron Coburn <ac...@apache.org>
> Sent: Tuesday, May 14, 2019 10:52 AM
> To: dev@tamaya.incubator.apache.org
> Subject: Sonar integration and recent commits
>
> Hi All,
> it seems that the sonar integration for the core tamaya repository has been
> removed. Were those commits reverted? Or maybe a force-push? A number of
> the recent changes seem no longer to be present.
>
> Aaron
>
Re: Sonar integration and recent commits
Posted by William Lieurance <wi...@namikoda.com>.
It looks like 0ddb859d57c71515e417a33e77d69355c753bb9b ("Merged with master changes") didn't pick up the travis yaml changes. Git's CLI, and github's web as well, isn't great at showing all the three-way changes added in a merge commit. Do a `git diff 8bcf8106..d5d3b748` to see what got modified on top of the changes in 0ddb859 alongside it.
Anatole, does that sound right? I feel like this might have gotten seen in a pull request, and is probably a good reason to use those more often.
--William
________________________________________
From: Aaron Coburn <ac...@apache.org>
Sent: Tuesday, May 14, 2019 10:52 AM
To: dev@tamaya.incubator.apache.org
Subject: Sonar integration and recent commits
Hi All,
it seems that the sonar integration for the core tamaya repository has been
removed. Were those commits reverted? Or maybe a force-push? A number of
the recent changes seem no longer to be present.
Aaron