You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/24 07:04:00 UTC
[jira] [Commented] (FLINK-8756) Support
ClusterClient.getAccumulators() in RestClusterClient
[ https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375378#comment-16375378 ]
ASF GitHub Bot commented on FLINK-8756:
---------------------------------------
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5573
[FLINK-8756][Client] Support ClusterClient.getAccumulators() in RestClusterClient
## What is the purpose of the change
This PR Support ClusterClient.getAccumulators() in RestClusterClient.
## Brief change log
- *Send REST request to get `JobAccumulatorsInfo` object*
- *Use jackson's ObjectMapper convert `JobAccumulatorsInfo` object to Map*
- *Add a test method into `RestClusterClientTest` class to test the `getAccumulators` function*
- *Add a test handler to mock `JobAccumulatorsInfo` object*
## Verifying this change
This change added tests and can be verified as follows:
- *Added test that validates that actual accumulators size equals we mocked in the test handler*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-8756
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5573.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5573
----
commit ec8ef5d8ad6d650e250737d5005173994337168c
Author: vinoyang <vi...@...>
Date: 2018-02-24T06:50:55Z
[FLINK-8756][Client] Support ClusterClient.getAccumulators() in RestClusterClient
----
> Support ClusterClient.getAccumulators() in RestClusterClient
> ------------------------------------------------------------
>
> Key: FLINK-8756
> URL: https://issues.apache.org/jira/browse/FLINK-8756
> Project: Flink
> Issue Type: Improvement
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Aljoscha Krettek
> Assignee: vinoyang
> Priority: Blocker
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)