You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "chennaji9 (via GitHub)" <gi...@apache.org> on 2026/09/30 10:55:50 UTC
[PR] [ISSUE #11285] test(remoting): cover RequestBuilder header mapping and rejection branches [rocketmq]
chennaji9 opened a new pull request, #11301:
URL: https://github.com/apache/rocketmq/pull/11301
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
Fixes #11285
### Brief Description
Adds `RequestBuilderTest` (remoting module, JUnit 4 + AssertJ, same package and style as the existing `RpcRequestHeaderTest`), pinning `RequestBuilder`'s currently untested contract:
- `RequestCode.PULL_MESSAGE` maps to `PullMessageRequestHeader` through both `buildTopicQueueRequestHeader` (all four overloads) and `buildCommonRpcHeader` (both overloads),
- `brokerName`/`topic`/`queueId`/`lo`/`oneway` field propagation across the overloads, including the nullable `Boolean` cases,
- unknown request codes (e.g. 999999, -1) are rejected with `UnsupportedOperationException` whose message contains the code.
No production code changes.
### How Did You Test This Change?
`mvn -B -pl remoting -am -Dtest=RequestBuilderTest -Dsurefire.failIfNoSpecifiedTests=false test` → BUILD SUCCESS, `Tests run: 8, Failures: 0, Errors: 0, Skipped: 0`. (The cast behavior of `buildCommonRpcHeader` was verified empirically before writing assertions — `RpcRequestHeader` is in the `PullMessageRequestHeader` hierarchy, so both overloads are covered by green tests.)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #11285] test(remoting): cover RequestBuilder header mapping and rejection branches [rocketmq]
Posted by "chennaji9 (via GitHub)" <gi...@apache.org>.
chennaji9 commented on PR #11301:
URL: https://github.com/apache/rocketmq/pull/11301#issuecomment-6259806472
Hi @RongtongJin, sorry for the ping — this PR has been open for a while without a review yet. The change is small and focused (cover RequestBuilder header mapping and rejection branches), and all tests and CI pass on my side. Would you mind taking a look when you get a chance? If it looks good, merging it would be much appreciated — happy to adjust anything if needed. Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #11285] test(remoting): cover RequestBuilder header mapping and rejection branches [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11301:
URL: https://github.com/apache/rocketmq/pull/11301#issuecomment-6247690745
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/11301?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 49.74%. Comparing base ([`78b96bc`](https://app.codecov.io/gh/apache/rocketmq/commit/78b96bc5e21216cd7896efae08f90c5cde4cae53?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`041ebc7`](https://app.codecov.io/gh/apache/rocketmq/commit/041ebc7f516237b56170aa3b77ab876dd58c72d2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 15 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #11301 +/- ##
=============================================
- Coverage 49.74% 49.74% -0.01%
- Complexity 14352 14376 +24
=============================================
Files 1390 1390
Lines 103190 103262 +72
Branches 13493 13504 +11
=============================================
+ Hits 51337 51365 +28
- Misses 45688 45690 +2
- Partials 6165 6207 +42
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/11301?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org