You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2014/04/07 23:23:39 UTC

[GitHub] incubator-storm pull request: STORM-274. Add support for command r...

Github user revans2 commented on the pull request:

    https://github.com/apache/incubator-storm/pull/60#issuecomment-39785521
  
    This is not strictly compatible with the python version.  This will come out as 
    
    "VALUE: ${VALUE}"
    
    where as the python strips of "VALUE:" and replaces it with "${name}:"
    
    I don't know if this needs to be fixed or not.  I am not sure who is reading these values.
    
    Also did you intend to include the STORM-273 fix in there as well?  It also looks OK to me, but I want to be sure that it is complete.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---