You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/11 12:04:55 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6036: arch, boards: cxd56xx: Minor update for spresense

pkarashchenko commented on code in PR #6036:
URL: https://github.com/apache/incubator-nuttx/pull/6036#discussion_r847251217


##########
boards/arm/cxd56xx/spresense/src/cxd56_ioctl.c:
##########
@@ -91,6 +92,22 @@ int board_ioctl(unsigned int cmd, uintptr_t arg)
         }
         break;
 #endif
+
+#ifdef CONFIG_CXD56_SDIO
+      /* CMD:           BOARDIOC_SDCARD_SETNOTIFYCB
+       * DESCRIPTION:   Set a callback function pointer to SDCard driver
+       *                to notify when card status is changed.
+       * ARG:           Callback function.
+       * CONFIGURATION: CONFIG_BOARDCTL & CONFIG_CXD56_SDIO
+       * DEPENDENCIES:  Board logic must provide board_app_initialization
+       */
+
+      case BOARDIOC_SDCARD_SETNOTIFYCB:
+        {
+          ret = board_sdcard_set_state_cb(arg);

Review Comment:
   I think passing function pointers from app to kernel is not the best thing. Why such functionality is needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org