[GitHub] [arrow] amol- commented on pull request #10427: ARROW-12881: [Python] Pyarrow IPC guide is missing sink.close()

[GitBox <gi...@apache.org>]

amol- commented on pull request #10427:
URL: https://github.com/apache/arrow/pull/10427#issuecomment-887534590


   > @amol- What do you think about this PR? Would you like to take it up?
   
   I wonder if we should foster (in the tutorial/howto) usage of context managers (by getting rid of all examples where `close()` is manually invoked) and reserve the use of explicit `close` for advanced use cases where it's up to the user to know what he/she is doing. At that point you could probably document that the object must be closed in the class documentation itself but you wouldn't have to worry too much in the tutorials because you spread the best practice that will handle closing by itself for the usage docs.
   
   My gut feeling is that this note probably fits more in the class doc itself, but I do also see how striving for perfection might make us delay too much good enough solutions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org