You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/13 05:26:37 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request
#8829: [dashboard] fix duplicated chart fetching when dashboard has default
filters
graceguo-supercat opened a new pull request #8829: [dashboard] fix duplicated chart fetching when dashboard has default filters
URL: https://github.com/apache/incubator-superset/pull/8829
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [x] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
When dashboard has default filters, I saw duplicated query requests from those charts applicable for the default filters:
I believe this issue was introduced during building filter indicators or filter scope selector features. The root cause is the initialization value for filter state is wrong, which cause `componentDidUpdate` trigger one extra query when dashboards having default filters.
### TEST PLAN
CI and manual test.
### REVIEWERS
@etr2460 @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org