You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hiram Chirino (JIRA)" <ji...@codehaus.org> on 2009/07/08 01:41:23 UTC

[jira] Created: (WAGON-273) Default the HTTP cookie policy to BROWSER_COMPATIBILITY

Default the HTTP cookie policy to BROWSER_COMPATIBILITY
-------------------------------------------------------

                 Key: WAGON-273
                 URL: http://jira.codehaus.org/browse/WAGON-273
             Project: Maven Wagon
          Issue Type: Improvement
            Reporter: Hiram Chirino
         Attachments: patch

Kinda related to WAGON-269.  Lots of websites these days (even google) are setting Cookies with domains like .google.com
The HTTP commons folks disagree with what all browsers do and allow that to match the google.com domain.  I think most folks accept what most browsers do is the right thing even though it goes against what the Cookie RFC says

I think it would behoove us to use the more relaxed BROWSER_COMPATIBILITY mode as the default as that will lower your support questions when wagon is used against domains that do this kind of thing.

Patch of this change attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (WAGON-273) Default the HTTP cookie policy to BROWSER_COMPATIBILITY

Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/WAGON-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg closed WAGON-273.
-------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.0)
                   2.0
         Assignee: Mark Struberg

fixed in r1136083. I implemented this for both commons.httpclient-3.1 and httpcomponents.client-4.1. So both wagon-http and wagon-dav-jackrabbit will use browser compatible cookie policy now.

> Default the HTTP cookie policy to BROWSER_COMPATIBILITY
> -------------------------------------------------------
>
>                 Key: WAGON-273
>                 URL: http://jira.codehaus.org/browse/WAGON-273
>             Project: Maven Wagon
>          Issue Type: Improvement
>          Components: wagon-http
>            Reporter: Hiram Chirino
>            Assignee: Mark Struberg
>             Fix For: 2.0
>
>         Attachments: patch
>
>
> Kinda related to WAGON-269.  Lots of websites these days (even google) are setting Cookies with domains like .google.com
> The HTTP commons folks disagree with what all browsers do and allow that to match the google.com domain.  I think most folks accept what most browsers do is the right thing even though it goes against what the Cookie RFC says
> I think it would behoove us to use the more relaxed BROWSER_COMPATIBILITY mode as the default as that will lower your support questions when wagon is used against domains that do this kind of thing.
> Patch of this change attached.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WAGON-273) Default the HTTP cookie policy to BROWSER_COMPATIBILITY

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/WAGON-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated WAGON-273:
-------------------------------

    Fix Version/s: 1.0
      Component/s: wagon-http

> Default the HTTP cookie policy to BROWSER_COMPATIBILITY
> -------------------------------------------------------
>
>                 Key: WAGON-273
>                 URL: http://jira.codehaus.org/browse/WAGON-273
>             Project: Maven Wagon
>          Issue Type: Improvement
>          Components: wagon-http
>            Reporter: Hiram Chirino
>             Fix For: 1.0
>
>         Attachments: patch
>
>
> Kinda related to WAGON-269.  Lots of websites these days (even google) are setting Cookies with domains like .google.com
> The HTTP commons folks disagree with what all browsers do and allow that to match the google.com domain.  I think most folks accept what most browsers do is the right thing even though it goes against what the Cookie RFC says
> I think it would behoove us to use the more relaxed BROWSER_COMPATIBILITY mode as the default as that will lower your support questions when wagon is used against domains that do this kind of thing.
> Patch of this change attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (WAGON-273) Default the HTTP cookie policy to BROWSER_COMPATIBILITY

Posted by "Hiram Chirino (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/WAGON-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210989#action_210989 ] 

Hiram Chirino commented on WAGON-273:
-------------------------------------

Looks like WAGON-269 tried to fix this issue but it has not.  I commented on that issue. 

> Default the HTTP cookie policy to BROWSER_COMPATIBILITY
> -------------------------------------------------------
>
>                 Key: WAGON-273
>                 URL: http://jira.codehaus.org/browse/WAGON-273
>             Project: Maven Wagon
>          Issue Type: Improvement
>          Components: wagon-http
>            Reporter: Hiram Chirino
>             Fix For: 1.0
>
>         Attachments: patch
>
>
> Kinda related to WAGON-269.  Lots of websites these days (even google) are setting Cookies with domains like .google.com
> The HTTP commons folks disagree with what all browsers do and allow that to match the google.com domain.  I think most folks accept what most browsers do is the right thing even though it goes against what the Cookie RFC says
> I think it would behoove us to use the more relaxed BROWSER_COMPATIBILITY mode as the default as that will lower your support questions when wagon is used against domains that do this kind of thing.
> Patch of this change attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (WAGON-273) Default the HTTP cookie policy to BROWSER_COMPATIBILITY

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/WAGON-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=211027#action_211027 ] 

Brett Porter commented on WAGON-273:
------------------------------------

I'm also noticing that some of the HTTP settings are not sticking Maven due to a bug, so that might be part of the problem.

> Default the HTTP cookie policy to BROWSER_COMPATIBILITY
> -------------------------------------------------------
>
>                 Key: WAGON-273
>                 URL: http://jira.codehaus.org/browse/WAGON-273
>             Project: Maven Wagon
>          Issue Type: Improvement
>          Components: wagon-http
>            Reporter: Hiram Chirino
>             Fix For: 1.0
>
>         Attachments: patch
>
>
> Kinda related to WAGON-269.  Lots of websites these days (even google) are setting Cookies with domains like .google.com
> The HTTP commons folks disagree with what all browsers do and allow that to match the google.com domain.  I think most folks accept what most browsers do is the right thing even though it goes against what the Cookie RFC says
> I think it would behoove us to use the more relaxed BROWSER_COMPATIBILITY mode as the default as that will lower your support questions when wagon is used against domains that do this kind of thing.
> Patch of this change attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira