You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2023/08/07 06:15:38 UTC

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2386: IGNITE-19294 Support merged configuration roots for multiple modules

tkalkirill commented on code in PR #2386:
URL: https://github.com/apache/ignite-3/pull/2386#discussion_r1285418798


##########
modules/configuration-api/src/main/java/org/apache/ignite/configuration/annotation/ConfigurationExtension.java:
##########
@@ -39,5 +40,12 @@
 @Target(TYPE)
 @Retention(RUNTIME)
 @Documented
-public @interface InternalConfiguration {
+public @interface ConfigurationExtension {

Review Comment:
   I don't like replacing one annotation with another, it's better to add a new one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org