You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2023/08/15 06:04:57 UTC
[GitHub] [flink-kubernetes-operator] 1996fanrui commented on a diff in pull request #651: [FLINK-32868][docs] Document the need to backport FLINK-30213 for using autoscaler with older version Flinks
1996fanrui commented on code in PR #651:
URL: https://github.com/apache/flink-kubernetes-operator/pull/651#discussion_r1294227008
##########
docs/content/docs/custom-resource/autoscaler.md:
##########
@@ -37,7 +37,10 @@ Key benefits to the user:
Job requirements:
- The autoscaler currently only works with the latest [Flink 1.17](https://hub.docker.com/_/flink) or after backporting the following fixes to your 1.15/1.16 Flink image
- - [Job vertex parallelism overrides](https://github.com/apache/flink/commit/23ce2281a0bb4047c64def9af7ddd5f19d88e2a9) (must have)
+ - Job vertex parallelism overrides (must have)
+ - [Add option to override job vertex parallelisms during job submission](https://github.com/apache/flink/commit/23ce2281a0bb4047c64def9af7ddd5f19d88e2a9)
+ - [Change ForwardPartitioner to RebalancePartitioner on parallelism changes](https://github.com/apache/flink/commit/61d6e78e1f6dff093e005c834e1a008f146c02b9)
Review Comment:
As @gyfora said at [FLINK-30213](https://issues.apache.org/jira/browse/FLINK-30213?focusedCommentId=17653597&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17653597), the PR is merged by 5 commits. So it's better to provide the PR link instead of commit link.
```suggestion
- [Change ForwardPartitioner to RebalancePartitioner on parallelism changes](https://github.com/apache/flink/pull/21443)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org