You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "Baunsgaard (via GitHub)" <gi...@apache.org> on 2024/07/30 12:24:44 UTC

[PR] [MINOR] Utility Functions for Column Arrays of Frames [systemds]

Baunsgaard opened a new pull request, #2058:
URL: https://github.com/apache/systemds/pull/2058

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Utility Functions for Column Arrays of Frames [systemds]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2058:
URL: https://github.com/apache/systemds/pull/2058#issuecomment-2258504507

   ## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2058?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `63.95817%` with `448 lines` in your changes missing coverage. Please review.
   > Project coverage is 68.77%. Comparing base [(`54d0a65`)](https://app.codecov.io/gh/apache/systemds/commit/54d0a65145aa43338da4df55e75e6e1fa598e8e3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9a11ed5`)](https://app.codecov.io/gh/apache/systemds/commit/9a11ed5177afcdf611a38259a9bb740ccac381ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 1 commits behind head on main.
   
   | [Files](https://app.codecov.io/gh/apache/systemds/pull/2058?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...s/runtime/frame/data/columns/HashIntegerArray.java](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fframe%2Fdata%2Fcolumns%2FHashIntegerArray.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvZnJhbWUvZGF0YS9jb2x1bW5zL0hhc2hJbnRlZ2VyQXJyYXkuamF2YQ==) | 71.35% | [37 Missing and 18 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ame/data/compress/CompressedFrameBlockFactory.java](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fframe%2Fdata%2Fcompress%2FCompressedFrameBlockFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvZnJhbWUvZGF0YS9jb21wcmVzcy9Db21wcmVzc2VkRnJhbWVCbG9ja0ZhY3RvcnkuamF2YQ==) | 47.36% | [43 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ysds/runtime/frame/data/columns/OptionalArray.java](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fframe%2Fdata%2Fcolumns%2FOptionalArray.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvZnJhbWUvZGF0YS9jb2x1bW5zL09wdGlvbmFsQXJyYXkuamF2YQ==) | 32.07% | [36 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/sysds/runtime/frame/data/columns/Array.java](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fframe%2Fdata%2Fcolumns%2FArray.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvZnJhbWUvZGF0YS9jb2x1bW5zL0FycmF5LmphdmE=) | 65.68% | [30 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ysds/runtime/frame/data/compress/CountHashMap.java](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fframe%2Fdata%2Fcompress%2FCountHashMap.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvZnJhbWUvZGF0YS9jb21wcmVzcy9Db3VudEhhc2hNYXAuamF2YQ==) | 0.00% | [34 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/sysds/utils/DoubleParser.java](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Futils%2FDoubleParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3V0aWxzL0RvdWJsZVBhcnNlci5qYXZh) | 74.80% | [17 Missing and 15 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ds/runtime/frame/data/lib/FrameLibApplySchema.java](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fframe%2Fdata%2Flib%2FFrameLibApplySchema.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvZnJhbWUvZGF0YS9saWIvRnJhbWVMaWJBcHBseVNjaGVtYS5qYXZh) | 47.82% | [17 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../sysds/runtime/frame/data/columns/DoubleArray.java](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fframe%2Fdata%2Fcolumns%2FDoubleArray.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvZnJhbWUvZGF0YS9jb2x1bW5zL0RvdWJsZUFycmF5LmphdmE=) | 59.57% | [19 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [src/main/java/org/apache/sysds/common/Types.java](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fcommon%2FTypes.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL2NvbW1vbi9UeXBlcy5qYXZh) | 41.93% | [15 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../sysds/runtime/frame/data/columns/StringArray.java](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fframe%2Fdata%2Fcolumns%2FStringArray.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvZnJhbWUvZGF0YS9jb2x1bW5zL1N0cmluZ0FycmF5LmphdmE=) | 86.40% | [13 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [14 more](https://app.codecov.io/gh/apache/systemds/pull/2058?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #2058      +/-   ##
   ============================================
   - Coverage     68.91%   68.77%   -0.15%     
   - Complexity    40828    40957     +129     
   ============================================
     Files          1441     1445       +4     
     Lines        161881   162551     +670     
     Branches      31460    31583     +123     
   ============================================
   + Hits         111555   111788     +233     
   - Misses        41281    41663     +382     
   - Partials       9045     9100      +55     
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/systemds/pull/2058?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Utility Functions for Column Arrays of Frames [systemds]

Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard closed pull request #2058: [MINOR] Utility Functions for Column Arrays of Frames
URL: https://github.com/apache/systemds/pull/2058


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org