You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/20 07:57:43 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #8161: Fix the so11y latency of persistence execution latency not correct in ElasticSearch storage
kezhenxu94 opened a new pull request #8161:
URL: https://github.com/apache/skywalking/pull/8161
The ES persistence execution is now asynchronous and the execution
latency only counts the time to insert the requests into the bulk
processor, instead of the time after the requests are flushed into the
storage, this patch fixes that issue.
There is the same issue in prepare latency but that needs more changes
so I'll leave it to another pull request.
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>. NO
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #8161: Fix the so11y latency of persistence execution latency not correct in ElasticSearch storage
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #8161:
URL: https://github.com/apache/skywalking/pull/8161#issuecomment-974616211
Should be good now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 merged pull request #8161: Fix the so11y latency of persistence execution latency not correct in ElasticSearch storage
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #8161:
URL: https://github.com/apache/skywalking/pull/8161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 merged pull request #8161: Fix the so11y latency of persistence execution latency not correct in ElasticSearch storage
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #8161:
URL: https://github.com/apache/skywalking/pull/8161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #8161: Fix the so11y latency of persistence execution latency not correct in ElasticSearch storage
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #8161:
URL: https://github.com/apache/skywalking/pull/8161#issuecomment-974613319
Push another commit to fix the unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 edited a comment on pull request #8161: Fix the so11y latency of persistence execution latency not correct in ElasticSearch storage
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #8161:
URL: https://github.com/apache/skywalking/pull/8161#issuecomment-974613319
Pushed another commit to fix the unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8161: Fix the so11y latency of persistence execution latency not correct in ElasticSearch storage
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #8161:
URL: https://github.com/apache/skywalking/pull/8161#issuecomment-974613356
Yes, noticed too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #8161: Fix the so11y latency of persistence execution latency not correct in ElasticSearch storage
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #8161:
URL: https://github.com/apache/skywalking/pull/8161#issuecomment-974612397
before
<img width="477" alt="Screen Shot 2021-11-20 at 15 57 35" src="https://user-images.githubusercontent.com/15965696/142719090-54087a7d-8fd2-4506-ba27-1a920a8f0399.png">
after
<img width="477" alt="Screen Shot 2021-11-20 at 15 57 56" src="https://user-images.githubusercontent.com/15965696/142719097-a4e27687-de7e-482d-adac-300f73e0efad.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 edited a comment on pull request #8161: Fix the so11y latency of persistence execution latency not correct in ElasticSearch storage
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #8161:
URL: https://github.com/apache/skywalking/pull/8161#issuecomment-974613319
Pushed another commit to fix the unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8161: Fix the so11y latency of persistence execution latency not correct in ElasticSearch storage
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #8161:
URL: https://github.com/apache/skywalking/pull/8161#issuecomment-974613356
Yes, noticed too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #8161: Fix the so11y latency of persistence execution latency not correct in ElasticSearch storage
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #8161:
URL: https://github.com/apache/skywalking/pull/8161#issuecomment-974612397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org