You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "caicancai (via GitHub)" <gi...@apache.org> on 2024/06/09 14:25:48 UTC

[PR] Build: Update NOTICE to include copyright for 2024 [iceberg]

caicancai opened a new pull request, #10471:
URL: https://github.com/apache/iceberg/pull/10471

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Update NOTICE to include copyright for 2024 [iceberg]

Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #10471:
URL: https://github.com/apache/iceberg/pull/10471#issuecomment-2172508325

   > Can you also please update the file in `aws-bundle` and `gcp-bundle`?
   
   Fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Update NOTICE to include copyright for 2024 [iceberg]

Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #10471:
URL: https://github.com/apache/iceberg/pull/10471#issuecomment-2171146052

   > > > While we are here, let's do the other ones, like azure-bundle NOTICE as well?
   > > 
   > > 
   > > Sorry, I don't seem to understand what you mean. Is there anything you need me to do?
   > 
   > I mean , there's some missing NOTICE that need update like https://github.com/apache/iceberg/blob/main/azure-bundle/NOTICE
   > 
   > > For the record, here's the details about `NOTICE` content: https://www.apache.org/legal/src-headers.html
   > > IImho, we should have the `NOTICE` only at root level (no need to have `NOTICE` in all folders).
   > > The version range should match the year of the current version, so 2024 is correct.
   > > I will propose another PR to cleanup the subfolder `NOTICE` files.
   > 
   > Yea if we can combine them somehow, that'd be nice..
   
   Thanks for the reminder, fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Update NOTICE to include copyright for 2024 [iceberg]

Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #10471:
URL: https://github.com/apache/iceberg/pull/10471#issuecomment-2171118114

   > For the record, here's the details about `NOTICE` content: https://www.apache.org/legal/src-headers.html
   > 
   > IImho, we should have the `NOTICE` only at root level (no need to have `NOTICE` in all folders).
   > 
   > The version range should match the year of the current version, so 2024 is correct.
   > 
   > I will propose another PR to cleanup the subfolder `NOTICE` files.
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Update NOTICE to include copyright for 2024 [iceberg]

Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #10471:
URL: https://github.com/apache/iceberg/pull/10471#issuecomment-2173969027

   Merged, thanks @caicancai , and @nastra , @jbonofre for additional review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Update NOTICE to include copyright for 2024 [iceberg]

Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #10471:
URL: https://github.com/apache/iceberg/pull/10471#issuecomment-2169147378

   While we are here, let's do the other ones, like azure-bundle NOTICE as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Update NOTICE to include copyright for 2024 [iceberg]

Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho merged PR #10471:
URL: https://github.com/apache/iceberg/pull/10471


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Update NOTICE to include copyright for 2024 [iceberg]

Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #10471:
URL: https://github.com/apache/iceberg/pull/10471#issuecomment-2171122177

   > > While we are here, let's do the other ones, like azure-bundle NOTICE as well?
   > 
   > Sorry, I don't seem to understand what you mean. Is there anything you need me to do?
   
   I mean , there's some missing NOTICE that need update like https://github.com/apache/iceberg/blob/main/azure-bundle/NOTICE  
   
   > For the record, here's the details about `NOTICE` content: https://www.apache.org/legal/src-headers.html
   > 
   > IImho, we should have the `NOTICE` only at root level (no need to have `NOTICE` in all folders).
   > 
   > The version range should match the year of the current version, so 2024 is correct.
   > 
   > I will propose another PR to cleanup the subfolder `NOTICE` files.
   
   Yea if we can combine them somehow, that'd be nice..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Update NOTICE to include copyright for 2024 [iceberg]

Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #10471:
URL: https://github.com/apache/iceberg/pull/10471#issuecomment-2171118437

   > While we are here, let's do the other ones, like azure-bundle NOTICE as well?
   
   Sorry, I don't seem to understand what you mean. Is there anything you need me to do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org