You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/30 11:29:23 UTC

[GitHub] [flink] leonardBang commented on a change in pull request #9669: [FLINK-13382] [Table SQL / Planner] Port DecimalITCase to unit tests

leonardBang commented on a change in pull request #9669: [FLINK-13382] [Table SQL / Planner] Port DecimalITCase to unit tests
URL: https://github.com/apache/flink/pull/9669#discussion_r329528924
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/DecimalTypeTest.scala
 ##########
 @@ -295,32 +310,1053 @@ class DecimalTypeTest extends ExpressionTestBase {
       "f4 < f0",
       "true")
 
-    // TODO add all tests if FLINK-4070 is fixed
 
 Review comment:
   I'll add more tests for this case cause FLINK-4070 has been fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services