You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2026/10/12 13:39:04 UTC
[PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Mryange opened a new pull request, #68979:
URL: https://github.com/apache/doris/pull/68979
### What problem does this PR solve?
Issue Number: N/A
Related PR: #68865
Problem Summary:
Timezone offsets can be accepted or rejected differently by FE constant folding and BE runtime CAST. For example, a DATETIME suffix of `-14:00` is valid under the literal policy but is rejected by the BE session-zone resolver. Session offsets such as `+14:30` and `-12:30` can bypass validation through the preloaded BE cache, while FE CONVERT_TZ applies different minute restrictions to bare and UTC/GMT-prefixed offsets.
Root cause: these entry points duplicate offset validation and mix session and literal policies. Introduce a shared FE parser using the existing timezone aliases and upstream canonicalization helper, retain separate session/DATETIME/TIMESTAMPTZ policies, validate BE cache endpoints, and construct parsed literal offsets through TimezoneUtils. Strict and non-strict BE CAST use the same checks. Numeric TIMESTAMPTZ offsets are limited to Java's `[-18:00, +18:00]`, retaining historical minute and second offsets within that range. Explicit named and compact suffix recognition is also corrected.
This does not add a BE Java alias table. Session alias dispatch is already fixed by #68865. System timezone database differences, ignored external lookup return values and DST rounding order are outside this change.
### Release note
Fix inconsistent timezone offset validation in CAST and CONVERT_TZ, reject out-of-range cached session offsets, and correctly recognize explicit timezone suffixes. Numeric TIMESTAMPTZ offsets beyond +/-18:00 are now rejected.
### Check List (For Author)
- Test
- [x] Regression test
- `test_timezone_parser_contract`: generated output through the runner and replayed successfully (1 suite, 0 failures). Compared 55 inputs across DATETIME/TIMESTAMPTZ and five execution paths: 550 results without semantic differences, allowing UTC display-format differences.
- Upstream `test_session_time_zone_short_ids`: passed after rebase, covering scans, point queries and stream load.
- [x] Unit Test
- Earlier focused FE tests: 76 tests, 0 failures/errors, 4 existing skips; BE TimezoneUtilsTest: 5/5 passed.
- After rebase: TimeUtilsTest, CoordinatorContextTest and TimeZoneParserTest: 18 tests passed.
- [x] Manual test
- Rebuilt BE and FE after rebase to master `2d053c83252`; both services report the matching version and Alive=true. ACT session FROM_UNIXTIME on a stored column matches Australia/Darwin without a BE alias table.
- Validation limit: the final FE cleanup removing redundant normalization/default arguments and reusing getCanonicalTimeZone has not been rebuilt. The latest regression ran on the preceding build; CI must validate the final source.
- clang-format, git diff --check and BE build hygiene passed. The earlier clang-tidy run reported pre-existing modernization diagnostics; it was not a clean clang-tidy pass.
- Behavior changed:
- [ ] No.
- [x] Yes. Offset boundaries and explicit suffix parsing are consistent across the scoped FE/BE paths; invalid endpoints are rejected.
- Does this need documentation?
- [x] No. This aligns existing offset policies and documents the TIMESTAMPTZ boundary change in the release note.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@doris.apache.org>.
github-actions[bot] commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6573981725
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #68979:
URL: https://github.com/apache/doris/pull/68979#discussion_r4256427397
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/TimeZoneParser.java:
##########
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.common.util;
+
+import java.time.DateTimeException;
+import java.time.ZoneId;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Locale;
+import java.util.Map;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+/** Doris timezone syntax, independent of the Java timezone database's input grammar. */
+public final class TimeZoneParser {
+ public enum Usage {
+ SESSION, DATETIME, TIMESTAMPTZ
+ }
+
+ private static final Pattern OFFSET = Pattern.compile("^([+-])([0-9]{1,2})(?::([0-9]{2}))?$");
+ private static final Pattern TEXT_OFFSET = Pattern.compile(
+ "^([+-])([0-9]{1,2})(?::?([0-9]{2}))?(?::([0-9]{2}))?$");
+ private static final Map<String, String> REGION_NAMES;
+
+ static {
+ Map<String, String> names = new HashMap<>();
+ for (String region : ZoneId.getAvailableZoneIds()) {
+ names.put(region, region);
+ }
+ REGION_NAMES = Collections.unmodifiableMap(names);
+ }
+
+ private TimeZoneParser() {
+ }
+
+ public static String normalize(String value, Usage usage) {
+ if (value == null || value.isEmpty()) {
+ throw new DateTimeException("Empty timezone");
+ }
+ String name = findAlias(value);
+ if (name != null) {
+ return name;
+ }
+ String region = findRegion(value);
+ if (region != null) {
+ return region;
+ }
+ String upper = value.toUpperCase(Locale.ROOT);
+ // Java's standard UTC names are not present in SHORT_IDS.
+ if (upper.equals("UT") || upper.equals("Z")) {
+ return "UTC";
+ }
+ boolean prefixed = upper.startsWith("UTC") || upper.startsWith("GMT");
+ String offset = prefixed ? value.substring(3) : value;
+ Matcher matcher = (usage == Usage.SESSION || prefixed ? OFFSET : TEXT_OFFSET).matcher(offset);
+ if (!matcher.matches()
+ || (usage == Usage.SESSION && !prefixed && matcher.group(3) == null)) {
+ throw new DateTimeException("Invalid timezone: " + value);
+ }
+ boolean negative = "-".equals(matcher.group(1));
+ int hour = Integer.parseInt(matcher.group(2));
+ int minute = matcher.group(3) == null ? 0 : Integer.parseInt(matcher.group(3));
+ int second = !prefixed && usage != Usage.SESSION && matcher.group(4) != null
+ ? Integer.parseInt(matcher.group(4)) : 0;
+ // Prefixed offsets have the same contract as session offsets in BE.
+ Usage policy = prefixed ? Usage.SESSION : usage;
+ int limit = policy == Usage.SESSION ? (negative ? 12 : 14)
+ : policy == Usage.DATETIME ? 14 : 18;
+ if (hour > limit || minute >= 60 || second >= 60
+ || (policy != Usage.TIMESTAMPTZ && hour == limit && minute != 0)
+ || (policy == Usage.TIMESTAMPTZ && hour == limit && (minute != 0 || second != 0))
+ || (policy == Usage.DATETIME
+ && (matcher.group(4) != null || (minute != 0 && minute != 30 && minute != 45)))) {
+ throw new DateTimeException("Invalid timezone offset: " + value);
+ }
+ String normalized = String.format(Locale.ROOT, "%s%02d:%02d", negative ? "-" : "+", hour, minute);
+ if (second != 0) {
+ normalized += String.format(Locale.ROOT, ":%02d", second);
+ }
+ return prefixed ? upper.substring(0, 3) + normalized : normalized;
+ }
+
+ private static String findAlias(String value) {
+ for (String alias : TimeUtils.timeZoneAliasMap.keySet()) {
+ if (alias.equalsIgnoreCase(value)) {
+ return TimeUtils.getCanonicalTimeZone(alias);
+ }
+ }
+ return null;
+ }
+
+ private static String findRegion(String value) {
+ return REGION_NAMES.get(value);
Review Comment:
[P2] Preserve case-insensitive region lookup for literal evaluation. REGION_NAMES now has exact-case HashMap keys, so this rejects `asia/shanghai` before the existing case-insensitive formatter can canonicalize it. With `time_zone='+00:00'` and non-strict casts, `CAST('2024-01-02 12:00:00 asia/shanghai' AS DATETIME(6))` folds to NULL, while casting the same stored STRING or disabling folding still resolves Shanghai and returns 04:00 in BE (`find_cctz_time_zone` lowercases the key). This worked in FE before the change and also affects the shared literal/CONVERT_TZ parser. Preserve case-insensitive region resolution for these consumers and cover folded versus stored values. This is distinct from the existing Java-only alias thread: it newly rejects a supported region rather than accepting an unsupported alias.
##########
be/src/util/timezone_utils.cpp:
##########
@@ -237,7 +255,8 @@ static bool normalize_offset_string(const std::string& timezone, bool allow_hour
minute = 0;
}
- if ((!positive && hour > 12) || (positive && hour > 14) || minute >= 60) {
+ const int limit = positive ? 14 : 12;
+ if (hour > limit || (hour == limit && minute != 0) || minute >= 60) {
Review Comment:
[P1] Handle persisted session offsets before tightening the BE resolver. The previous FE accepts `SET GLOBAL time_zone='GMT-12:30'`; session variables restore the String directly from the image/journal, and `CoordinatorContext` still sends its canonical `GMT-12:30` without invoking the new SESSION validator. After an upgrade this resolver returns false, but `RuntimeState::init` ignores that result, leaving its freshly constructed timezone object in UTC ([CCTZ default](https://raw.githubusercontent.com/google/cctz/v2.5/include/cctz/time_zone.h)). Consequently `FROM_UNIXTIME(ts)` for a stored `ts=1704153600` changes from `2024-01-01 11:30:00` to `2024-01-02 00:00:00` silently; an old-FE/new-BE rolling upgrade has the same problem. Preserve decoding of previously valid transmitted offsets or explicitly migrate/reject restored values before execution, and propagate resolver failures instead of proceeding in UTC. This is separate from the existing DATE literal-suffix thread.
##########
fe/fe-core/src/test/java/org/apache/doris/common/util/TimeZoneParserTest.java:
##########
@@ -0,0 +1,117 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.common.util;
+
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.nereids.trees.expressions.literal.DateTimeV2Literal;
+import org.apache.doris.nereids.trees.expressions.literal.TimestampTzLiteral;
+import org.apache.doris.nereids.trees.expressions.literal.format.DateTimeChecker;
+import org.apache.doris.nereids.types.TimeStampTzType;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+import java.time.DateTimeException;
+
+class TimeZoneParserTest {
+ @Test
+ void sessionBoundaries() {
+ for (String prefix : new String[] {"", "UTC", "GMT", "utc", "gmt"}) {
+ for (String offset : new String[] {"+14:01", "+14:30", "+14:45", "-12:01", "-12:30",
+ "-12:45", "+15:00", "-13:00", "+08:60"}) {
+ Assertions.assertThrows(DateTimeException.class,
+ () -> TimeZoneParser.parse(prefix + offset, TimeZoneParser.Usage.SESSION), prefix + offset);
+ }
+ for (String offset : new String[] {"+14:00", "-12:00", "+08:01", "+08:15", "-00:30"}) {
+ Assertions.assertNotNull(TimeZoneParser.parse(prefix + offset, TimeZoneParser.Usage.SESSION));
+ }
+ }
+ }
+
+ @Test
+ void offsetSyntaxCannotBypassValidation() {
+ for (TimeZoneParser.Usage usage : TimeZoneParser.Usage.values()) {
+ for (String value : new String[] {"UTC8", "GMT8:30", "UTC0", "GMT0:00"}) {
+ Assertions.assertThrows(DateTimeException.class,
+ () -> TimeZoneParser.normalize(value, usage), usage + ": " + value);
+ }
+ }
+ for (String value : new String[] {"+00:00:00", "-00:00:00", "+0000", "+00"}) {
+ Assertions.assertThrows(DateTimeException.class,
+ () -> TimeZoneParser.normalize(value, TimeZoneParser.Usage.SESSION), value);
+ }
+ Assertions.assertThrows(DateTimeException.class,
+ () -> TimeZoneParser.normalize("+00:00:00", TimeZoneParser.Usage.DATETIME));
+ Assertions.assertEquals("+00:00",
+ TimeZoneParser.normalize("+00:00:00", TimeZoneParser.Usage.TIMESTAMPTZ));
+ for (String value : new String[] {"UT", "ut", "Z", "z"}) {
+ Assertions.assertEquals("UTC", TimeZoneParser.normalize(value, TimeZoneParser.Usage.DATETIME));
+ }
+ }
+
+ @Test
+ void namesAndSyntax() throws Exception {
+ Assertions.assertEquals("UTC", TimeUtils.checkTimeZoneValidAndStandardize("utc"));
+ Assertions.assertThrows(DateTimeException.class,
Review Comment:
[P2] Expect the public validator's DdlException in this assertion. `checkTimeZoneValidAndStandardize` catches the parser's DateTimeException and calls `ErrorReport.reportDdlException`, which throws DdlException. Therefore this new assertion fails whenever `namesAndSyntax` runs, even though the validator rejects the input as intended. Assert DdlException here (or call TimeZoneParser directly if the test is meant to exercise its exception contract).
##########
regression-test/suites/datatype_p0/datetimev2/test_timezone_parser_contract.groovy:
##########
@@ -0,0 +1,129 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_timezone_parser_contract") {
+ sql "DROP TABLE IF EXISTS timezone_parser_contract_inputs"
+ sql """CREATE TABLE timezone_parser_contract_inputs (id INT, v STRING)
+ DUPLICATE KEY(id) DISTRIBUTED BY HASH(id) BUCKETS 1
+ PROPERTIES ('replication_num'='1')"""
+
+ def suffixes = ["+00:00", "-00:30", "+14:00", "-12:00", "-13:00", "-14:00",
+ "+8", "+08", "+0800", "+8:30", "+08:45", "+14:30", "-14:45",
+ "+08:01", "+08:15", "+08:60", "+24:00", "UTC", "utc", "GMT", "Z",
+ "zulu", "CST", "cst", "Asia/Shanghai", "asia/shanghai", "Etc/GMT+3",
+ "America/Port-au-Prince", "America/Does_not_exist", "UTC+08:01",
+ "GMT-13:00", "UTC+8", "+08:05:43", "-14:21", "+08:00:00", "+18:00", "+18:01",
+ "+19:00", "GMT0", "EST5EDT", "W-SU",
+ "+00:00:00", "-00:00:00", "UTC8", "GMT8:30", "UTC0", "GMT0:00"]
+ def inputs = suffixes.collect { "2024-01-02 12:00:00 ${it}" }
+ inputs.addAll(["1900-01-01 08:05:43 CST", "1900-01-01 08:05:43 Asia/Shanghai",
+ "1900-01-01 08:05:43+08:05:43", "20240102120000+0800", "20240102T120000+8:30",
+ "20240102120000UTC", "20240102T120000UTC"])
+ inputs.add(null)
+ sql "INSERT INTO timezone_parser_contract_inputs VALUES " + inputs.withIndex().collect { v, id ->
+ "(${id}, ${v == null ? 'NULL' : "'${v}'"})"
+ }.join(",")
+ sql "SET enable_sql_cache=false"
+ sql "SET time_zone='+00:00'"
+ sql "SET enable_strict_cast=false"
+
+ // Literal folding requests, folding disabled, stored slots and Lambda inputs.
+ [[false, false], [false, true], [true, false]].eachWithIndex { settings, path ->
+ sql "SET enable_fold_constant_by_be=${settings[0]}"
+ sql "SET debug_skip_fold_constant=${settings[1]}"
+ ["DATETIME(6)", "TIMESTAMPTZ(6)"].eachWithIndex { type, typeId ->
+ inputs.eachWithIndex { value, id ->
+ def literal = value == null ? "NULL" : "'${value}'"
+ "qt_literal_${path}_${typeId}_${id}"("SELECT CAST(${literal} AS ${type})")
Review Comment:
[P2] Include the generated output file for the new qt suite. There is no `regression-test/data/datatype_p0/datetimev2/test_timezone_parser_contract.out` in this checkout or the supplied changed-file list. Ordinary regression replay reaches the first `qt_literal_*` here and `Suite.quickRunTest` throws `Missing outputFile` rather than checking any results; local generation does not make its output available to CI. Generate the golden through the regression runner, verify the expected timezone results, and commit it with this suite.
##########
regression-test/suites/datatype_p0/datetimev2/test_timezone_parser_contract.groovy:
##########
@@ -0,0 +1,129 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_timezone_parser_contract") {
+ sql "DROP TABLE IF EXISTS timezone_parser_contract_inputs"
+ sql """CREATE TABLE timezone_parser_contract_inputs (id INT, v STRING)
+ DUPLICATE KEY(id) DISTRIBUTED BY HASH(id) BUCKETS 1
+ PROPERTIES ('replication_num'='1')"""
+
+ def suffixes = ["+00:00", "-00:30", "+14:00", "-12:00", "-13:00", "-14:00",
+ "+8", "+08", "+0800", "+8:30", "+08:45", "+14:30", "-14:45",
+ "+08:01", "+08:15", "+08:60", "+24:00", "UTC", "utc", "GMT", "Z",
+ "zulu", "CST", "cst", "Asia/Shanghai", "asia/shanghai", "Etc/GMT+3",
+ "America/Port-au-Prince", "America/Does_not_exist", "UTC+08:01",
+ "GMT-13:00", "UTC+8", "+08:05:43", "-14:21", "+08:00:00", "+18:00", "+18:01",
+ "+19:00", "GMT0", "EST5EDT", "W-SU",
+ "+00:00:00", "-00:00:00", "UTC8", "GMT8:30", "UTC0", "GMT0:00"]
+ def inputs = suffixes.collect { "2024-01-02 12:00:00 ${it}" }
+ inputs.addAll(["1900-01-01 08:05:43 CST", "1900-01-01 08:05:43 Asia/Shanghai",
+ "1900-01-01 08:05:43+08:05:43", "20240102120000+0800", "20240102T120000+8:30",
+ "20240102120000UTC", "20240102T120000UTC"])
+ inputs.add(null)
+ sql "INSERT INTO timezone_parser_contract_inputs VALUES " + inputs.withIndex().collect { v, id ->
+ "(${id}, ${v == null ? 'NULL' : "'${v}'"})"
+ }.join(",")
+ sql "SET enable_sql_cache=false"
+ sql "SET time_zone='+00:00'"
+ sql "SET enable_strict_cast=false"
+
+ // Literal folding requests, folding disabled, stored slots and Lambda inputs.
+ [[false, false], [false, true], [true, false]].eachWithIndex { settings, path ->
+ sql "SET enable_fold_constant_by_be=${settings[0]}"
+ sql "SET debug_skip_fold_constant=${settings[1]}"
+ ["DATETIME(6)", "TIMESTAMPTZ(6)"].eachWithIndex { type, typeId ->
+ inputs.eachWithIndex { value, id ->
+ def literal = value == null ? "NULL" : "'${value}'"
+ "qt_literal_${path}_${typeId}_${id}"("SELECT CAST(${literal} AS ${type})")
+ }
+ }
+ }
+ sql "SET enable_fold_constant_by_be=false"
+ sql "SET debug_skip_fold_constant=true"
+ ["DATETIME(6)", "TIMESTAMPTZ(6)"].eachWithIndex { type, typeId ->
+ "qt_slots_${typeId}"("SELECT id, CAST(v AS ${type}) FROM timezone_parser_contract_inputs ORDER BY id")
+ "qt_lambda_${typeId}"("SELECT id, array_map(x -> CAST(x AS ${type}), ARRAY(v)) FROM timezone_parser_contract_inputs ORDER BY id")
+ }
+ sql "SET time_zone='+08:00'"
+ [false, true].eachWithIndex { skip, path ->
+ sql "SET debug_skip_fold_constant=${skip}"
+ ["+0800", "America/Port-au-Prince", "Etc/GMT+3"].eachWithIndex { suffix, id ->
+ "qt_session_literal_${path}_${id}"("SELECT CAST('2024-01-02 12:00:00 ${suffix}' AS TIMESTAMPTZ(6))")
+ }
+ }
+ sql "SET debug_skip_fold_constant=true"
+ qt_session_slots "SELECT id, CAST(v AS TIMESTAMPTZ(6)) FROM timezone_parser_contract_inputs ORDER BY id"
+
+ ["utc", "Z", "zulu", "cst", "Asia/Shanghai", "UTC+8", "GMT-6", "+14:00", "-12:00"].eachWithIndex { zone, id ->
Review Comment:
[P2] Use an accepted session-zone spelling in the successful matrix. The third iteration runs `SET time_zone='zulu'`, but the new SESSION parser has no zulu alias and its exact-case region table contains `Zulu`. The input falls through to the offset regex and TimeUtils raises DdlException, so the suite stops before `qt_session_zone_2` and the later CONVERT_TZ/strict cases. This also prevents output generation even after the missing golden is addressed. Use an accepted spelling, or explicitly support lowercase zulu in SESSION validation, and verify the entire suite completes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6154519423
# FE Regression Coverage Report
Increment line coverage ` 89.41% (76/85)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68979_2779a99f5848ebbb78784f650f2c4327cc4adfa2_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68979_2779a99f5848ebbb78784f650f2c4327cc4adfa2_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6163258135
# FE UT Coverage Report
Increment line coverage ` 94.32% (83/88)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68979_8f45f28b1cdeedb0aa0bfa9ecf7d4a97f6c7b01e/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68979_8f45f28b1cdeedb0aa0bfa9ecf7d4a97f6c7b01e/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6141086527
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6151615791
<details>
<summary>TPC-DS: <b>Total hot run time: 152538 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2779a99f5848ebbb78784f650f2c4327cc4adfa2, data reload: false
query5 4331 572 466 466
query6 436 207 213 207
query7 4809 450 224 224
query8 316 183 166 166
query9 8793 3945 3916 3916
query10 463 311 256 256
query11 5980 3454 3205 3205
query12 148 88 87 87
query13 1254 430 308 308
query14 6515 4799 4519 4519
query14_1 4287 4281 4255 4255
query15 213 204 186 186
query16 948 451 431 431
query17 867 650 543 543
query18 2418 418 319 319
query19 199 164 140 140
query20 85 81 81 81
query21 215 134 113 113
query22 13012 13152 12810 12810
query23 13160 12560 12175 12175
query23_1 12313 12225 12257 12225
query24 7099 821 461 461
query24_1 449 469 467 467
query25 508 399 329 329
query26 1257 261 134 134
query27 2796 447 270 270
query28 4647 1919 1920 1919
query29 1534 590 430 430
query30 290 216 182 182
query31 864 760 653 653
query32 149 91 90 90
query33 496 292 240 240
query34 992 844 503 503
query35 746 765 645 645
query36 806 837 743 743
query37 129 96 93 93
query38 1771 1717 1727 1717
query39 729 706 694 694
query39_1 697 676 680 676
query40 219 112 92 92
query41 67 68 62 62
query42 87 84 80 80
query43 364 378 326 326
query44 1312 697 697 697
query45 175 193 163 163
query46 836 965 569 569
query47 2796 2888 2925 2888
query48 298 304 226 226
query49 568 393 297 297
query50 672 272 220 220
query51 10306 10516 10678 10516
query52 80 77 69 69
query53 192 202 149 149
query54 237 201 192 192
query55 75 68 61 61
query56 223 207 204 204
query57 1602 1625 1562 1562
query58 311 262 248 248
query59 2373 2413 2203 2203
query60 295 235 206 206
query61 146 153 137 137
query62 400 337 283 283
query63 193 158 160 158
query64 2748 964 801 801
query65 3433 3387 3393 3387
query66 1783 403 313 313
query67 20133 20438 20173 20173
query68 3229 994 604 604
query69 402 285 248 248
query70 932 830 822 822
query71 294 251 207 207
query72 2800 2652 2321 2321
query73 514 530 297 297
query74 4595 4492 4296 4296
query75 2351 2328 1935 1935
query76 2347 1022 604 604
query77 354 402 295 295
query78 8980 8970 8522 8522
query79 908 833 511 511
query80 480 427 331 331
query81 521 331 271 271
query82 207 135 111 111
query83 189 210 181 181
query84 288 121 101 101
query85 766 414 364 364
query86 257 240 233 233
query87 2020 1956 1820 1820
query88 3587 2711 2711 2711
query89 356 290 258 258
query90 2102 189 181 181
query91 175 162 139 139
query92 97 88 82 82
query93 975 987 580 580
query94 446 325 302 302
query95 600 413 340 340
query96 665 541 237 237
query97 2465 2446 2322 2322
query98 162 150 145 145
query99 777 778 666 666
Total cold run time: 233211 ms
Total hot run time: 152538 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #68979:
URL: https://github.com/apache/doris/pull/68979#discussion_r4248955585
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/TimeUtils.java:
##########
@@ -319,42 +317,18 @@ public static long msTimeStringToLong(String timeStr, TimeZone timeZone) {
// Check if the time zone_value is valid
public static String checkTimeZoneValidAndStandardize(String value) throws DdlException {
- Function<String, String> standardizeValue = s -> {
- boolean positive = s.charAt(0) != '-';
- String[] parts = s.replaceAll("[+-]", "").split(":");
- return (positive ? "+" : "-") + String.format("%02d:%02d",
- Integer.parseInt(parts[0]), Integer.parseInt(parts[1]));
- };
-
try {
- if (value == null) {
- ErrorReport.reportDdlException(ErrorCode.ERR_UNKNOWN_TIME_ZONE, "null");
- }
- // match offset type, such as +08:00, -07:00
- Matcher matcher = TIMEZONE_OFFSET_FORMAT_REG.matcher(value);
- // it supports offset and region timezone type, and short zone ids
- boolean match = matcher.matches();
- if (!value.contains("/") && !timeZoneAliasMap.containsKey(value) && !match) {
- if ((value.startsWith("GMT") || value.startsWith("UTC"))
- && TIMEZONE_OFFSET_FORMAT_REG.matcher(value.substring(3)).matches()) {
- value = value.substring(0, 3) + standardizeValue.apply(value.substring(3));
- } else {
- ErrorReport.reportDdlException(ErrorCode.ERR_UNKNOWN_TIME_ZONE, value);
- }
+ String input = value;
+ if (input != null && !input.isEmpty() && Character.isDigit(input.charAt(0))) {
+ input = "+" + input;
}
- if (match) {
- value = standardizeValue.apply(value);
-
- // timezone offsets around the world extended from -12:00 to +14:00
- int tz = Integer.parseInt(value.substring(1, 3)) * 100 + Integer.parseInt(value.substring(4, 6));
- if (value.charAt(0) == '-' && tz > 1200) {
- ErrorReport.reportDdlException(ErrorCode.ERR_UNKNOWN_TIME_ZONE, value);
- } else if (value.charAt(0) == '+' && tz > 1400) {
- ErrorReport.reportDdlException(ErrorCode.ERR_UNKNOWN_TIME_ZONE, value);
+ String normalized = TimeZoneParser.normalize(input, TimeZoneParser.Usage.SESSION);
Review Comment:
[P2] Preserve normalization in the dynamic-partition ALTER path. This now accepts asia/shanghai and returns Asia/Shanghai, but DynamicPartitionUtil.analyzeDynamicPartition discards that return and stores the original value. On an existing dynamically partitioned table, ALTER TABLE t SET ('dynamic_partition.time_zone'='asia/shanghai') therefore passes validation, Env.modifyTableDynamicPartition mutates TableProperty.properties, then buildDynamicProperty throws when DynamicPartitionProperty calls the case-sensitive ZoneId.of on the raw value. The statement fails before its journal entry but leaves the live property map poisoned, so subsequent dynamic-partition ALTERs fail until the timezone is repaired. Previously this input failed before mutation. Carry the normalized zone into the analyzed and logged properties and ensure reconstruction succeeds before changing live metadata.
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/TimeZoneParser.java:
##########
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.common.util;
+
+import java.time.DateTimeException;
+import java.time.ZoneId;
+import java.util.Collections;
+import java.util.Locale;
+import java.util.Map;
+import java.util.TreeMap;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+/** Doris timezone syntax, independent of the Java timezone database's input grammar. */
+public final class TimeZoneParser {
+ public enum Usage {
+ SESSION, DATETIME, TIMESTAMPTZ
+ }
+
+ private static final Pattern OFFSET = Pattern.compile("^([+-])([0-9]{1,2})(?::([0-9]{2}))?$");
+ private static final Pattern TEXT_OFFSET = Pattern.compile(
+ "^([+-])([0-9]{1,2})(?::?([0-9]{2}))?(?::([0-9]{2}))?$");
+ private static final Map<String, String> REGION_NAMES;
+
+ static {
+ Map<String, String> names = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
+ for (String region : ZoneId.getAvailableZoneIds()) {
+ names.put(region, region);
+ }
+ REGION_NAMES = Collections.unmodifiableMap(names);
+ }
+
+ private TimeZoneParser() {
+ }
+
+ public static String normalize(String value, Usage usage) {
+ if (value == null || value.isEmpty()) {
+ throw new DateTimeException("Empty timezone");
+ }
+ String name = findAlias(value);
Review Comment:
[P2] Keep non-session alias acceptance consistent with BE. The new findAlias path accepts [Java short IDs](https://docs.oracle.com/javase/8/docs/api/java/time/ZoneId.html#SHORT_IDS) such as ACT in literal CAST and CONVERT_TZ, but runtime still passes the original suffix/argument to TimezoneUtils::find_cctz_time_zone, which has no ACT alias. With time_zone='+00:00', CAST('2024-01-02 12:00:00 ACT' AS DATETIME(6)) now folds to 02:30 in FE, while the same value in a stored STRING slot or with folding disabled returns NULL (or a parse error in strict mode); CONVERT_TZ(...,'ACT','UTC') likewise succeeds only when folded. Session-zone canonicalization does not normalize these inputs. Apply equivalent resolution to the runtime paths or constrain non-session aliases, and cover a Java-only alias across folded and stored-slot evaluation.
##########
be/src/util/timezone_utils.cpp:
##########
@@ -237,7 +244,8 @@ static bool normalize_offset_string(const std::string& timezone, bool allow_hour
minute = 0;
}
- if ((!positive && hour > 12) || (positive && hour > 14) || minute >= 60) {
+ const int limit = positive ? 14 : 12;
+ if (hour > limit || (hour == limit && minute != 0) || minute >= 60) {
Review Comment:
[P2] Apply the literal/session split to DATE and legacy casts too. Rejecting -12:30/-12:45 here also changes CastToDateV2 and CastToDateOrDatetime, whose strict and non-strict numeric-offset branches still use find_cctz_time_zone. Those suffixes were valid before this change and still pass FE's DATETIME literal policy. For example, CAST('2024-01-02 12:00:00-12:30' AS DATE) folds to 2024-01-02 in FE but now returns NULL (or raises a parse error in strict mode) for a stored STRING value or with folding disabled. DATETIMEV1 is affected as well. Move these remaining literal consumers onto the policy-neutral construction path and include DATE/legacy targets in the regression matrix.
##########
be/src/exprs/function/cast/cast_to_datetimev2_impl.hpp:
##########
@@ -733,20 +733,19 @@ inline bool CastToDatetimeV2::from_string_strict_mode_internal(
"invalid minute offset '{}'", part[1]);
}
}
- if constexpr (type == DataTimeCastEnumType::TIMESTAMP_TZ) {
- // Wire offsets include historical zones outside the session fixed-zone range.
- // Use the exact offset even when it has no seconds (for example, Guam's -14:21).
- const auto offset = static_cast<int>(part[0] * 3600 + part[1] * 60 + second_offset);
- parsed_tz = cctz::fixed_time_zone(cctz::seconds(sign == '-' ? -offset : offset));
- } else {
+ if constexpr (type == DataTimeCastEnumType::DATE_TIME) {
SET_PARAMS_RET_FALSE_IFN(part[0] != 14 || part[1] == 0,
"invalid timezone offset '{}'",
combine_tz_offset(sign, part[0], part[1]));
- SET_PARAMS_RET_FALSE_IFN(
- TimezoneUtils::find_cctz_time_zone(
- combine_tz_offset(sign, part[0], part[1]), parsed_tz),
- "invalid timezone offset '{}'", combine_tz_offset(sign, part[0], part[1]));
}
+ if constexpr (type == DataTimeCastEnumType::TIMESTAMP_TZ) {
+ SET_PARAMS_RET_FALSE_IFN(part[0] != 18 || (part[1] == 0 && second_offset == 0),
+ "invalid timezone offset '{}'",
+ combine_tz_offset(sign, part[0], part[1]));
+ }
+ const auto offset = static_cast<int>(part[0] * 3600 + part[1] * 60 + second_offset);
+ parsed_tz =
+ TimezoneUtils::create_fixed_offset_time_zone(sign == '-' ? -offset : offset);
Review Comment:
[P2] Preserve cached fixed zones for per-row DATETIME parsing. For common suffixes such as +08:00, the old DATE_TIME branch copied a preloaded TimezoneUtils cache entry. This helper calls cctz::fixed_time_zone for every row instead; in the [pinned CCTZ 2.5 implementation](https://raw.githubusercontent.com/google/cctz/v2.5/src/time_zone_impl.cc) that goes through LoadTimeZone and acquires the process-wide TimeZoneMutex even on cache hits. Parallel DATETIME casts and TIMESTAMP_NS parsing now contend on this global mutex for every nonzero offset, including the non-strict branch below. Keep the separate literal range validation, but reuse already constructed zones through a policy-independent immutable cache or equivalent rather than resolving the fixed zone per row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6125430779
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6160888613
<details>
<summary>TPC-H: <b>Total hot run time: 29521 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8f45f28b1cdeedb0aa0bfa9ecf7d4a97f6c7b01e, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17621 5694 5792 5694
q2 2149 329 285 285
q3 10166 1447 860 860
q4 4685 478 351 351
q5 7442 812 547 547
q6 186 189 159 159
q7 764 797 618 618
q8 9245 1321 1122 1122
q9 5741 4471 4465 4465
q10 6817 1282 1016 1016
q11 447 257 243 243
q12 642 413 286 286
q13 18046 3043 2421 2421
q14 276 271 250 250
q15 q16 738 729 678 678
q17 1197 762 596 596
q18 7112 6259 6185 6185
q19 1147 970 602 602
q20 400 346 230 230
q21 6077 2587 2649 2587
q22 398 355 326 326
Total cold run time: 101296 ms
Total hot run time: 29521 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 6691 6657 6776 6657
q2 734 623 575 575
q3 5641 5782 5150 5150
q4 2045 2177 1590 1590
q5 5726 5443 5780 5443
q6 253 200 162 162
q7 2229 1961 1814 1814
q8 3137 2716 2711 2711
q9 8304 8188 8214 8188
q10 3685 3620 3292 3292
q11 607 430 378 378
q12 678 701 508 508
q13 2784 3084 2398 2398
q14 284 293 278 278
q15 q16 667 675 616 616
q17 7821 7046 6955 6955
q18 13106 12260 13078 12260
q19 907 798 811 798
q20 2194 2198 1939 1939
q21 5911 4887 4843 4843
q22 507 446 400 400
Total cold run time: 73911 ms
Total hot run time: 66955 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6154557307
# BE UT Coverage Report
Increment line coverage `100.00% (19/19)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2779a99f5848ebbb78784f650f2c4327cc4adfa2_2779a99f5848ebbb78784f650f2c4327cc4adfa2/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2779a99f5848ebbb78784f650f2c4327cc4adfa2_2779a99f5848ebbb78784f650f2c4327cc4adfa2/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 65.87% (31405/47675) |
| Line Coverage | 50.61% (330739/653509) |
| Region Coverage | 45.97% (267291/581416) |
| Branch Coverage | 47.65% (125506/263375) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6142832876
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6125535816
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6163312367
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (19/19)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68979_8f45f28b1cdeedb0aa0bfa9ecf7d4a97f6c7b01e_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68979_8f45f28b1cdeedb0aa0bfa9ecf7d4a97f6c7b01e_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.94% (35505/46147) |
| Line Coverage | 62.21% (401986/646146) |
| Region Coverage | 58.57% (339123/579017) |
| Branch Coverage | 59.50% (156241/262576) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6164105964
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6159650011
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6144060136
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6163474790
# FE Regression Coverage Report
Increment line coverage ` 37.62% (79/210)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68979_8f45f28b1cdeedb0aa0bfa9ecf7d4a97f6c7b01e_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68979_8f45f28b1cdeedb0aa0bfa9ecf7d4a97f6c7b01e_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6161003901
<details>
<summary>TPC-DS: <b>Total hot run time: 152565 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8f45f28b1cdeedb0aa0bfa9ecf7d4a97f6c7b01e, data reload: false
query5 4294 585 457 457
query6 423 207 199 199
query7 4797 456 228 228
query8 327 193 177 177
query9 8795 3983 3984 3983
query10 481 314 266 266
query11 5991 3450 3221 3221
query12 151 94 87 87
query13 1260 438 334 334
query14 6539 4727 4482 4482
query14_1 4214 4231 4260 4231
query15 219 210 185 185
query16 931 443 422 422
query17 866 649 567 567
query18 2416 425 320 320
query19 203 163 136 136
query20 82 78 80 78
query21 214 132 113 113
query22 13043 13008 12830 12830
query23 13161 12524 12165 12165
query23_1 12349 12219 12302 12219
query24 7095 836 472 472
query24_1 484 480 483 480
query25 535 420 362 362
query26 1245 251 145 145
query27 2786 438 273 273
query28 4622 1949 1950 1949
query29 1554 598 466 466
query30 289 226 194 194
query31 892 772 655 655
query32 150 89 101 89
query33 514 304 251 251
query34 907 844 503 503
query35 750 772 646 646
query36 787 828 766 766
query37 132 99 94 94
query38 1805 1795 1687 1687
query39 722 705 700 700
query39_1 669 686 671 671
query40 236 141 111 111
query41 70 68 72 68
query42 133 84 90 84
query43 359 375 328 328
query44 1298 706 708 706
query45 177 177 159 159
query46 860 964 571 571
query47 2795 3040 2881 2881
query48 295 308 217 217
query49 558 394 290 290
query50 679 284 219 219
query51 10305 10430 10400 10400
query52 77 80 72 72
query53 191 214 157 157
query54 249 210 185 185
query55 79 64 66 64
query56 230 219 214 214
query57 1621 1579 1543 1543
query58 269 265 250 250
query59 2363 2391 2131 2131
query60 271 236 217 217
query61 152 145 148 145
query62 394 335 284 284
query63 198 165 168 165
query64 2767 929 756 756
query65 3456 3356 3402 3356
query66 1789 420 302 302
query67 20342 20235 20068 20068
query68 3058 983 618 618
query69 385 287 247 247
query70 909 832 826 826
query71 289 241 216 216
query72 2752 2586 2315 2315
query73 512 535 299 299
query74 4586 4470 4307 4307
query75 2354 2301 1951 1951
query76 2292 1020 597 597
query77 356 404 298 298
query78 9134 9155 8601 8601
query79 960 891 540 540
query80 730 422 341 341
query81 552 329 271 271
query82 591 143 111 111
query83 296 197 175 175
query84 314 128 143 128
query85 933 432 351 351
query86 354 239 231 231
query87 2001 1953 1858 1858
query88 3669 2714 2679 2679
query89 341 305 267 267
query90 1719 190 181 181
query91 156 158 127 127
query92 99 86 83 83
query93 1013 984 570 570
query94 504 310 288 288
query95 597 351 317 317
query96 682 522 237 237
query97 2484 2441 2346 2346
query98 169 147 142 142
query99 777 771 658 658
Total cold run time: 234193 ms
Total hot run time: 152565 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@doris.apache.org>.
github-actions[bot] commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6571686413
Codex automated review failed and did not complete.
Error: Selected model is at capacity. Please try a different model.
Workflow run: https://github.com/apache/doris/actions/runs/41401011267
Please inspect the workflow logs and rerun the review after the underlying issue is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #68979:
URL: https://github.com/apache/doris/pull/68979#discussion_r4257782816
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/format/DateTimeChecker.java:
##########
@@ -160,14 +161,26 @@ private FormatChecker nanoSecond() {
}
private FormatChecker timeZone() {
+ return or(namedTimeZone(), offsetTimeZone());
+ }
+
+ private FormatChecker namedTimeZone() {
+ return and(
+ atLeast(1, Character::isLetter),
+ atLeast(0, c -> Character.isLetterOrDigit(c) || c == '/' || c == '_'
+ || c == '-' || c == '+')
+ );
+ }
+
+ private FormatChecker offsetTimeZone() {
// Z or +08:00 or UTC-01:00
return and(
// timezone: Europe/London, America/New_York
atLeast(0, c -> ('a' <= c && c <= 'z') || ('A' <= c && c <= 'Z') || c == '/' || c == '_'),
option(
and(
chars(c -> c == '+' || c == '-'),
- digit(1, 2),
+ digit(1, 4),
Review Comment:
[P2] Preserve fractional scale for newly recognized compact offsets. With time_zone='+00:00', CONVERT_TZ('20240102120000.123456+0000','UTC','UTC') now loses .123456. ConvertTz.castDateTime calls DateTimeV2Type.forTypeFromString; this wider match makes the input valid, activating DateTimeLiteral.determineScale, which still returns 0 for a compact string without '-' or ':'. The resulting CAST to DATETIME(0) rounds away the fraction before CONVERT_TZ runs, even with folding disabled. Previously the checker left two offset digits unconsumed, so inference retained MAX_SCALE=6; the existing StringLikeLiteral parser already accepted +0000 and normalized it to +00:00, preserving all six digits. Update compact fractional scale inference together with this grammar change and test an inferred-scale input; the current CONVERT_TZ matrix explicitly uses DATETIME(6) and cannot catch this regression.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DateLiteral.java:
##########
@@ -339,13 +353,22 @@ static Result<TemporalAccessor, AnalysisException> parseDateTime(String s, int m
}
if (!containsPunctuation) {
s = normalizeBasic(s);
+ boolean hasTimeSeparator = s.length() > 8 && s.charAt(8) == 'T';
+ int zoneStart = 0;
+ while (zoneStart < s.length() && (Character.isDigit(s.charAt(zoneStart))
+ || (hasTimeSeparator && zoneStart == 8) || s.charAt(zoneStart) == '.')) {
+ zoneStart++;
+ }
+ if (zoneStart < s.length() && s.charAt(zoneStart) != ' ') {
+ s = s.substring(0, zoneStart) + TimeZoneParser.normalize(s.substring(zoneStart), usage);
+ }
boolean parseNanoseconds = maxFractionDigits > 7;
if (parseNanoseconds) {
s = DateUtils.truncateFractionalSecondForJavaParser(s);
}
// mysql reject "20200219 010101" "200219 010101", can't use ' ' spilt basic date time.
- if (!s.contains("T")) {
+ if (!hasTimeSeparator) {
Review Comment:
[P2] Align short compact TIMESTAMPTZ parsing with BE. With time_zone='+00:00', CAST('240102120000UTC' AS TIMESTAMPTZ(6)) now folds to 2024-01-02 12:00:00 UTC: normalizeBasic expands the two-digit year and this branch chooses the formatter without T. BE still receives the original 12 digits; CastToDatetimeV2 only special-cases 14 contiguous digits, otherwise reads 2401-02-12 and fails the required date/time delimiter. Its non-strict fallback also requires date separators. The same value in a stored STRING or with folding disabled therefore returns NULL (or a parse error in strict mode). Before this change UTC's T selected the T formatter and left this CAST to the same failing runtime path, so the folded/runtime split is new. Add matching short-compact handling in BE or keep these values on the runtime path, and cover 12-digit inputs across folded and stored evaluation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6151442930
<details>
<summary>TPC-H: <b>Total hot run time: 29272 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2779a99f5848ebbb78784f650f2c4327cc4adfa2, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17609 5720 5613 5613
q2 2141 321 260 260
q3 10235 1423 859 859
q4 4672 468 349 349
q5 7427 817 549 549
q6 187 187 156 156
q7 812 812 609 609
q8 9251 1360 1134 1134
q9 5712 4493 4444 4444
q10 6852 1300 1020 1020
q11 429 251 238 238
q12 626 413 291 291
q13 18059 3099 2406 2406
q14 276 274 250 250
q15 q16 739 727 694 694
q17 1197 760 563 563
q18 7169 6299 6197 6197
q19 1140 977 590 590
q20 385 346 233 233
q21 5669 2522 2646 2522
q22 409 346 295 295
Total cold run time: 100996 ms
Total hot run time: 29272 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 6608 6721 6808 6721
q2 775 635 557 557
q3 5609 5766 5326 5326
q4 2054 2166 1574 1574
q5 5683 5513 5753 5513
q6 252 191 147 147
q7 2260 2020 1806 1806
q8 3294 2786 2817 2786
q9 8299 8115 8210 8115
q10 3706 3623 3274 3274
q11 602 401 370 370
q12 670 705 495 495
q13 2792 3092 2407 2407
q14 295 293 267 267
q15 q16 674 680 605 605
q17 7780 7167 6858 6858
q18 13149 12313 13049 12313
q19 928 791 790 790
q20 2191 2180 1959 1959
q21 5843 4708 4861 4708
q22 502 449 401 401
Total cold run time: 73966 ms
Total hot run time: 66992 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6143660114
/review
For this review, please do not reopen the following accepted scope decisions: Java-only aliases such as ACT, case-insensitive region-name compatibility, DATE/legacy DATETIME offset compatibility, dynamic-partition timezone normalization, and the residual per-row cost for uncommon offsets such as -12:30/-12:45. The DdlException assertion, generated regression output, Zulu session case, and common fixed-offset cache issues have already been fixed. Please focus only on new findings; treat persisted-session offset failure handling as a follow-up item rather than a blocker for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6161057779
<details>
<summary>ClickBench: <b>Total hot run time: 24.4 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8f45f28b1cdeedb0aa0bfa9ecf7d4a97f6c7b01e, data reload: false
query1 0.01 0.01 0.01
query2 0.10 0.05 0.05
query3 0.27 0.12 0.12
query4 1.61 0.13 0.12
query5 0.27 0.25 0.25
query6 1.17 0.70 0.68
query7 0.04 0.01 0.00
query8 0.06 0.04 0.04
query9 0.44 0.35 0.34
query10 0.55 0.58 0.60
query11 0.20 0.14 0.14
query12 0.19 0.15 0.14
query13 0.49 0.49 0.49
query14 0.98 0.96 0.97
query15 0.63 0.61 0.61
query16 0.35 0.32 0.35
query17 1.17 1.08 1.14
query18 0.23 0.22 0.20
query19 2.10 2.07 1.96
query20 0.02 0.01 0.01
query21 15.48 0.28 0.15
query22 4.52 0.06 0.05
query23 16.22 0.32 0.12
query24 3.27 0.62 0.36
query25 0.11 0.07 0.05
query26 1.02 0.26 0.16
query27 0.05 0.05 0.04
query28 1.54 0.60 0.40
query29 12.54 4.20 3.28
query30 0.28 0.15 0.14
query31 2.78 0.59 0.35
query32 3.22 0.61 0.53
query33 3.18 3.29 3.20
query34 15.44 3.98 3.37
query35 3.34 3.34 3.35
query36 0.56 0.45 0.41
query37 0.10 0.07 0.06
query38 0.05 0.05 0.03
query39 0.03 0.03 0.03
query40 0.17 0.16 0.15
query41 0.08 0.03 0.02
query42 0.04 0.03 0.03
query43 0.05 0.04 0.03
Total cold run time: 94.95 s
Total hot run time: 24.4 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6151702785
<details>
<summary>ClickBench: <b>Total hot run time: 24.56 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2779a99f5848ebbb78784f650f2c4327cc4adfa2, data reload: false
query1 0.00 0.00 0.00
query2 0.10 0.05 0.05
query3 0.27 0.12 0.11
query4 1.60 0.13 0.12
query5 0.27 0.22 0.25
query6 1.17 0.69 0.68
query7 0.04 0.01 0.00
query8 0.06 0.05 0.04
query9 0.43 0.35 0.35
query10 0.58 0.59 0.57
query11 0.23 0.14 0.14
query12 0.18 0.14 0.15
query13 0.48 0.50 0.51
query14 1.00 0.97 0.97
query15 0.64 0.60 0.62
query16 0.30 0.34 0.33
query17 1.18 1.11 1.16
query18 0.22 0.20 0.21
query19 2.15 1.97 1.98
query20 0.02 0.01 0.01
query21 15.49 0.26 0.13
query22 4.43 0.06 0.05
query23 16.26 0.31 0.13
query24 2.94 0.59 0.41
query25 0.11 0.05 0.08
query26 1.51 0.22 0.14
query27 0.04 0.04 0.05
query28 2.36 0.62 0.42
query29 12.51 4.12 3.32
query30 0.29 0.14 0.13
query31 2.78 0.58 0.34
query32 3.22 0.61 0.53
query33 3.15 3.23 3.23
query34 15.50 4.03 3.41
query35 3.38 3.33 3.38
query36 0.55 0.42 0.47
query37 0.09 0.06 0.06
query38 0.05 0.04 0.04
query39 0.04 0.03 0.03
query40 0.18 0.16 0.15
query41 0.09 0.03 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 95.97 s
Total hot run time: 24.56 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6154738667
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (19/19)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68979_2779a99f5848ebbb78784f650f2c4327cc4adfa2_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68979_2779a99f5848ebbb78784f650f2c4327cc4adfa2_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.81% (35445/46147) |
| Line Coverage | 62.10% (401268/646137) |
| Region Coverage | 58.46% (338512/579006) |
| Branch Coverage | 59.41% (155994/262564) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "Mryange (via GitHub) via commits" <co...@doris.apache.org>.
Mryange commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6570788665
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "Mryange (via GitHub) via commits" <co...@doris.apache.org>.
Mryange merged PR #68979:
URL: https://github.com/apache/doris/pull/68979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Align timezone offset parsing across FE and BE [doris]
Posted by "Mryange (via GitHub) via commits" <co...@doris.apache.org>.
Mryange commented on PR #68979:
URL: https://github.com/apache/doris/pull/68979#issuecomment-6572733768
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org