You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2023/12/21 20:01:49 UTC
[PR] add option to support notebook well [kyuubi]
turboFei opened a new pull request, #5898:
URL: https://github.com/apache/kyuubi/pull/5898
# :mag: Description
## Issue References ๐
<!-- Append the issue number after #. If there is no issue for you to link create one or -->
<!-- If there are no issues to link, please provide details here. -->
This pull request fixes #
## Describe Your Solution ๐ง
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
## Types of changes :bookmark:
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Test Plan ๐งช
#### Behavior Without This Pull Request :coffin:
#### Behavior With This Pull Request :tada:
#### Related Unit Tests
---
# Checklists
## ๐ Author Self Checklist
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
## ๐ Committer Pre-Merge Checklist
- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested
**Be nice. Be informative.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5877][FOLLOWUP] Add option to support notebook well [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5898:
URL: https://github.com/apache/kyuubi/pull/5898#discussion_r1434662949
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -3258,6 +3258,14 @@ object KyuubiConf {
.booleanConf
.createWithDefault(true)
+ val ENGINE_SPARK_NOTEBOOK_MODE: ConfigEntry[Boolean] =
+ buildConf("kyuubi.engine.spark.notebook.mode")
+ .doc("Enable this to support notebook well." +
+ " For python notebook, the `text/plain` wrapped output will be returned.")
Review Comment:
I'm not quite familiar with this area, could you please elaborate more about the difference between this configuration true/false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5877][FOLLOWUP] Add spark output mode to better support PySpark notebook [kyuubi]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #5898:
URL: https://github.com/apache/kyuubi/pull/5898#issuecomment-1867257398
thanks, merged to 1.9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5877][FOLLOWUP] Add option to support notebook well [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5898:
URL: https://github.com/apache/kyuubi/pull/5898#discussion_r1434670936
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -3258,6 +3258,14 @@ object KyuubiConf {
.booleanConf
.createWithDefault(true)
+ val ENGINE_SPARK_NOTEBOOK_MODE: ConfigEntry[Boolean] =
+ buildConf("kyuubi.engine.spark.notebook.mode")
+ .doc("Enable this to support notebook well." +
+ " For python notebook, the `text/plain` wrapped output will be returned.")
Review Comment:
from the logic of the code, maybe we can name it as `kyuubi.engine.spark.output.mode` with options "auto" and "notebook".
cc @cfmcgrady do you have suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5877][FOLLOWUP] Add spark output mode to better support pySpark notebook [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5898:
URL: https://github.com/apache/kyuubi/pull/5898#discussion_r1434706690
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -3258,13 +3258,19 @@ object KyuubiConf {
.booleanConf
.createWithDefault(true)
- val ENGINE_SPARK_NOTEBOOK_MODE: ConfigEntry[Boolean] =
- buildConf("kyuubi.engine.spark.notebook.mode")
- .doc("Enable this to support notebook well." +
- " For python notebook, the `text/plain` wrapped output will be returned.")
+ object EngineSparkOutputMode extends Enumeration {
+ type EngineSparkOutputMode = Value
+ val AUTO, NOTEBOOK = Value
+ }
+
+ val ENGINE_SPARK_OUTPUT_MODE: ConfigEntry[String] =
+ buildConf("kyuubi.engine.spark.output.mode")
+ .doc("The output mode of Spark engine: <ul>" +
+ " <li>AUTO: For pySpark, the extracted `text/plain` from python response as output.</li>" +
Review Comment:
**PySpark**: https://spark.apache.org/docs/latest/api/python/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5877][FOLLOWUP] Add spark output mode to better support PySpark notebook [kyuubi]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #5898: [KYUUBI #5877][FOLLOWUP] Add spark output mode to better support PySpark notebook
URL: https://github.com/apache/kyuubi/pull/5898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5877][FOLLOWUP] Add option to support notebook well [kyuubi]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #5898:
URL: https://github.com/apache/kyuubi/pull/5898#discussion_r1434676775
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -3258,6 +3258,14 @@ object KyuubiConf {
.booleanConf
.createWithDefault(true)
+ val ENGINE_SPARK_NOTEBOOK_MODE: ConfigEntry[Boolean] =
+ buildConf("kyuubi.engine.spark.notebook.mode")
+ .doc("Enable this to support notebook well." +
+ " For python notebook, the `text/plain` wrapped output will be returned.")
Review Comment:
for notebook mode, for the output:
```
{ "text/plain": <content>}
```
for non-notebook mode, the output:
```
<content>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5877][FOLLOWUP] Add option to support notebook well [kyuubi]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #5898:
URL: https://github.com/apache/kyuubi/pull/5898#discussion_r1434676775
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -3258,6 +3258,14 @@ object KyuubiConf {
.booleanConf
.createWithDefault(true)
+ val ENGINE_SPARK_NOTEBOOK_MODE: ConfigEntry[Boolean] =
+ buildConf("kyuubi.engine.spark.notebook.mode")
+ .doc("Enable this to support notebook well." +
+ " For python notebook, the `text/plain` wrapped output will be returned.")
Review Comment:
for notebook mode, the output:
```
{ "text/plain": <content>}
```
for non-notebook mode, the output:
```
<content>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5877][FOLLOWUP] Add option to support notebook well [kyuubi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5898:
URL: https://github.com/apache/kyuubi/pull/5898#issuecomment-1867212816
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5898?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `3 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`4be20e1`)](https://app.codecov.io/gh/apache/kyuubi/commit/4be20e1ca7691245addacf0373b9524afb428527?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.54% compared to head [(`12aac55`)](https://app.codecov.io/gh/apache/kyuubi/pull/5898?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.53%.
> Report is 5 commits behind head on master.
> :exclamation: Current head 12aac55 differs from pull request most recent head de1669c. Consider uploading reports for the commit de1669c to get more accurate results
| [Files](https://app.codecov.io/gh/apache/kyuubi/pull/5898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../kyuubi/engine/spark/operation/ExecutePython.scala](https://app.codecov.io/gh/apache/kyuubi/pull/5898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVB5dGhvbi5zY2FsYQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/kyuubi/pull/5898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...kyuubi/engine/spark/operation/SparkOperation.scala](https://app.codecov.io/gh/apache/kyuubi/pull/5898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vU3BhcmtPcGVyYXRpb24uc2NhbGE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/kyuubi/pull/5898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #5898 +/- ##
============================================
- Coverage 61.54% 61.53% -0.02%
Complexity 23 23
============================================
Files 615 615
Lines 36325 36332 +7
Branches 4970 4971 +1
============================================
Hits 22357 22357
- Misses 11554 11566 +12
+ Partials 2414 2409 -5
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kyuubi/pull/5898?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org