You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/23 09:39:53 UTC
[GitHub] [iotdb] yanhongwangg opened a new pull request #3621: support fill by specific value
yanhongwangg opened a new pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ijihang commented on a change in pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
ijihang commented on a change in pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#discussion_r686707983
##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/fill/ValueFill.java
##########
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.db.query.executor.fill;
+
+import org.apache.iotdb.db.metadata.PartialPath;
+import org.apache.iotdb.db.query.context.QueryContext;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.TimeValuePair;
+import org.apache.iotdb.tsfile.utils.Binary;
+import org.apache.iotdb.tsfile.utils.TsPrimitiveType;
+
+import java.util.Set;
+
+public class ValueFill extends IFill implements Cloneable {
+
+ private String value;
+
+ private boolean booleanValue;
+ private int intValue;
+ private long longValue;
+ private float floatValue;
+ private double doubleValue;
+ private Binary textValue;
+
+ public ValueFill(String value, TSDataType dataType) {
+ this.value = value;
+ this.dataType = dataType;
+ parseValue();
+ }
+
+ @Override
+ public IFill copy() {
+ return (IFill) clone();
+ }
+
+ @Override
+ public Object clone() {
+ ValueFill valueFill = null;
+ try {
+ valueFill = (ValueFill) super.clone();
+ } catch (CloneNotSupportedException e) {
+ }
+ return valueFill;
+ }
+
+ @Override
+ public void configureFill(
Review comment:
one parameter，queryTime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ijihang commented on pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
ijihang commented on pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#issuecomment-896635338
> Submit a PR to master branch?
After merge,i will cherry pick to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#issuecomment-886002421
BTW, user guide need to be updated..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] yanhongwangg commented on pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
yanhongwangg commented on pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#issuecomment-886314263
> How the feature is defined?
> value, and constant?
constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ijihang commented on a change in pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
ijihang commented on a change in pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#discussion_r686632275
##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/fill/ValueFill.java
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.db.query.executor.fill;
+
+import org.apache.iotdb.db.metadata.PartialPath;
+import org.apache.iotdb.db.query.context.QueryContext;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.TimeValuePair;
+import org.apache.iotdb.tsfile.read.filter.basic.Filter;
+import org.apache.iotdb.tsfile.utils.Binary;
+import org.apache.iotdb.tsfile.utils.TsPrimitiveType;
+
+import java.util.Set;
+
+public class ValueFill extends IFill {
+ private PartialPath seriesPath;
+ private QueryContext context;
+ private String value;
+ private Set<String> allSensors;
+ private Filter timeFilter;
+
+ public ValueFill(TSDataType dataType, long queryTime, String value) {
+ super(dataType, queryTime);
+ this.value = value;
+ }
+
+ public ValueFill(String value) {
+ this.value = value;
+ }
+
+ @Override
+ public IFill copy() {
+ return new ValueFill(dataType, queryTime, value);
+ }
+
+ @Override
+ public void configureFill(
+ PartialPath path,
+ TSDataType dataType,
+ long queryTime,
+ Set<String> deviceMeasurements,
+ QueryContext context) {
+ this.seriesPath = path;
+ this.dataType = dataType;
+ this.context = context;
+ this.queryTime = queryTime;
+ this.allSensors = deviceMeasurements;
+ }
+
+ @Override
+ public TimeValuePair getFillResult() {
+ switch (dataType) {
+ case BOOLEAN:
+ return new TimeValuePair(
Review comment:
The initialization of value is placed in the constructor，configureFill is null , avoid parse each time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] mychaow commented on a change in pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
mychaow commented on a change in pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#discussion_r686648850
##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/fill/ValueFill.java
##########
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.db.query.executor.fill;
+
+import org.apache.iotdb.db.metadata.PartialPath;
+import org.apache.iotdb.db.query.context.QueryContext;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.TimeValuePair;
+import org.apache.iotdb.tsfile.utils.Binary;
+import org.apache.iotdb.tsfile.utils.TsPrimitiveType;
+
+import java.util.Set;
+
+public class ValueFill extends IFill implements Cloneable {
+
+ private String value;
+
+ private boolean booleanValue;
+ private int intValue;
+ private long longValue;
+ private float floatValue;
+ private double doubleValue;
+ private Binary textValue;
+
+ public ValueFill(String value, TSDataType dataType) {
+ this.value = value;
+ this.dataType = dataType;
+ parseValue();
+ }
+
+ @Override
+ public IFill copy() {
+ return (IFill) clone();
+ }
+
+ @Override
+ public Object clone() {
+ ValueFill valueFill = null;
+ try {
+ valueFill = (ValueFill) super.clone();
+ } catch (CloneNotSupportedException e) {
+ }
+ return valueFill;
+ }
+
+ @Override
+ public void configureFill(
+ PartialPath path,
+ TSDataType dataType,
+ long queryTime,
+ Set<String> deviceMeasurements,
+ QueryContext context) {}
+
+ @Override
+ public TimeValuePair getFillResult() {
+ switch (dataType) {
+ case BOOLEAN:
+ return new TimeValuePair(queryTime, new TsPrimitiveType.TsBoolean(booleanValue));
Review comment:
could we cache TsPrimitiveType not the primary type?
##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/fill/ValueFill.java
##########
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.db.query.executor.fill;
+
+import org.apache.iotdb.db.metadata.PartialPath;
+import org.apache.iotdb.db.query.context.QueryContext;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.TimeValuePair;
+import org.apache.iotdb.tsfile.utils.Binary;
+import org.apache.iotdb.tsfile.utils.TsPrimitiveType;
+
+import java.util.Set;
+
+public class ValueFill extends IFill implements Cloneable {
+
+ private String value;
+
+ private boolean booleanValue;
+ private int intValue;
+ private long longValue;
+ private float floatValue;
+ private double doubleValue;
+ private Binary textValue;
+
+ public ValueFill(String value, TSDataType dataType) {
+ this.value = value;
+ this.dataType = dataType;
+ parseValue();
+ }
+
+ @Override
+ public IFill copy() {
+ return (IFill) clone();
+ }
+
+ @Override
+ public Object clone() {
+ ValueFill valueFill = null;
+ try {
+ valueFill = (ValueFill) super.clone();
+ } catch (CloneNotSupportedException e) {
+ }
+ return valueFill;
+ }
+
+ @Override
+ public void configureFill(
Review comment:
Is it useless？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ijihang commented on a change in pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
ijihang commented on a change in pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#discussion_r686707547
##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/fill/ValueFill.java
##########
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.db.query.executor.fill;
+
+import org.apache.iotdb.db.metadata.PartialPath;
+import org.apache.iotdb.db.query.context.QueryContext;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.TimeValuePair;
+import org.apache.iotdb.tsfile.utils.Binary;
+import org.apache.iotdb.tsfile.utils.TsPrimitiveType;
+
+import java.util.Set;
+
+public class ValueFill extends IFill implements Cloneable {
+
+ private String value;
+
+ private boolean booleanValue;
+ private int intValue;
+ private long longValue;
+ private float floatValue;
+ private double doubleValue;
+ private Binary textValue;
+
+ public ValueFill(String value, TSDataType dataType) {
+ this.value = value;
+ this.dataType = dataType;
+ parseValue();
+ }
+
+ @Override
+ public IFill copy() {
+ return (IFill) clone();
+ }
+
+ @Override
+ public Object clone() {
+ ValueFill valueFill = null;
+ try {
+ valueFill = (ValueFill) super.clone();
+ } catch (CloneNotSupportedException e) {
+ }
+ return valueFill;
+ }
+
+ @Override
+ public void configureFill(
+ PartialPath path,
+ TSDataType dataType,
+ long queryTime,
+ Set<String> deviceMeasurements,
+ QueryContext context) {}
+
+ @Override
+ public TimeValuePair getFillResult() {
+ switch (dataType) {
+ case BOOLEAN:
+ return new TimeValuePair(queryTime, new TsPrimitiveType.TsBoolean(booleanValue));
Review comment:
Tsprimitivetype can be cached
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] mychaow commented on pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
mychaow commented on pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#issuecomment-892620703
please merge the rel/0.12 to make ci happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] yanhongwangg commented on pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
yanhongwangg commented on pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#issuecomment-887942125
> Hi, I think the user guide is necessary for this new feature.
I'll add it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a change in pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#discussion_r685804594
##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/fill/ValueFill.java
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.db.query.executor.fill;
+
+import org.apache.iotdb.db.metadata.PartialPath;
+import org.apache.iotdb.db.query.context.QueryContext;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.TimeValuePair;
+import org.apache.iotdb.tsfile.read.filter.basic.Filter;
+import org.apache.iotdb.tsfile.utils.Binary;
+import org.apache.iotdb.tsfile.utils.TsPrimitiveType;
+
+import java.util.Set;
+
+public class ValueFill extends IFill {
+ private PartialPath seriesPath;
+ private QueryContext context;
+ private String value;
+ private Set<String> allSensors;
+ private Filter timeFilter;
+
+ public ValueFill(TSDataType dataType, long queryTime, String value) {
+ super(dataType, queryTime);
+ this.value = value;
+ }
+
+ public ValueFill(String value) {
+ this.value = value;
+ }
+
+ @Override
+ public IFill copy() {
+ return new ValueFill(dataType, queryTime, value);
+ }
+
+ @Override
+ public void configureFill(
+ PartialPath path,
+ TSDataType dataType,
+ long queryTime,
+ Set<String> deviceMeasurements,
+ QueryContext context) {
+ this.seriesPath = path;
+ this.dataType = dataType;
+ this.context = context;
+ this.queryTime = queryTime;
+ this.allSensors = deviceMeasurements;
+ }
+
+ @Override
+ public TimeValuePair getFillResult() {
+ switch (dataType) {
+ case BOOLEAN:
+ return new TimeValuePair(
Review comment:
We could cache the primitive value in this class to avoid parse each time, like this:
boolean booleanValue;
int intValue；
long longValue;
float floatValue;
double doubleValue;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ijihang commented on a change in pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
ijihang commented on a change in pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#discussion_r686632275
##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/fill/ValueFill.java
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.db.query.executor.fill;
+
+import org.apache.iotdb.db.metadata.PartialPath;
+import org.apache.iotdb.db.query.context.QueryContext;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.TimeValuePair;
+import org.apache.iotdb.tsfile.read.filter.basic.Filter;
+import org.apache.iotdb.tsfile.utils.Binary;
+import org.apache.iotdb.tsfile.utils.TsPrimitiveType;
+
+import java.util.Set;
+
+public class ValueFill extends IFill {
+ private PartialPath seriesPath;
+ private QueryContext context;
+ private String value;
+ private Set<String> allSensors;
+ private Filter timeFilter;
+
+ public ValueFill(TSDataType dataType, long queryTime, String value) {
+ super(dataType, queryTime);
+ this.value = value;
+ }
+
+ public ValueFill(String value) {
+ this.value = value;
+ }
+
+ @Override
+ public IFill copy() {
+ return new ValueFill(dataType, queryTime, value);
+ }
+
+ @Override
+ public void configureFill(
+ PartialPath path,
+ TSDataType dataType,
+ long queryTime,
+ Set<String> deviceMeasurements,
+ QueryContext context) {
+ this.seriesPath = path;
+ this.dataType = dataType;
+ this.context = context;
+ this.queryTime = queryTime;
+ this.allSensors = deviceMeasurements;
+ }
+
+ @Override
+ public TimeValuePair getFillResult() {
+ switch (dataType) {
+ case BOOLEAN:
+ return new TimeValuePair(
Review comment:
In new commit ,The initialization of value is placed in the constructor，configureFill is null , avoid parse each time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] mychaow commented on pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
mychaow commented on pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#issuecomment-892620703
please merge the rel/0.12 to make ci happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#issuecomment-886002379
How the feature is defined?
value, and constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #3621: [To rel/0.12] support fill by specific value
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #3621:
URL: https://github.com/apache/iotdb/pull/3621#issuecomment-887464737
Hi, I think the user guide is necessary for this new feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org