You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Vinod K V (JIRA)" <ji...@apache.org> on 2008/09/11 11:33:44 UTC

[jira] Created: (HADOOP-4161) [HOD] Uncaught exceptions can potentially hang hod-client.

[HOD] Uncaught exceptions can potentially hang hod-client.
----------------------------------------------------------

                 Key: HADOOP-4161
                 URL: https://issues.apache.org/jira/browse/HADOOP-4161
             Project: Hadoop Core
          Issue Type: Bug
            Reporter: Vinod K V
             Fix For: 0.18.1, 0.19.0


In hod-client, we have
{code}
sys.exit(hod.operation())
sys.exit(hod.script())
{code}
sys.exit(opCode) makes sure that the client is truly cleaned up, killing unjoined threads etc. So, exceptions not caught by hodRunner.operation() or hodRunner.script(), will by-pass sys.exit method and thus can potentially hang hod-client.

For e.g., when hod allocate fails after allocation and before service-registry thread is cleaned up, hod client will hang.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4161) [HOD] Uncaught exceptions can potentially hang hod-client.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod K V updated HADOOP-4161:
------------------------------

    Attachment: HADOOP-4161

Attaching a patch. A very small bug-fix. No test-cases and no documentation.

> [HOD] Uncaught exceptions can potentially hang hod-client.
> ----------------------------------------------------------
>
>                 Key: HADOOP-4161
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4161
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hod
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>             Fix For: 0.18.1, 0.19.0
>
>         Attachments: HADOOP-4161
>
>
> In hod-client, we have
> {code}
> sys.exit(hod.operation())
> sys.exit(hod.script())
> {code}
> sys.exit(opCode) makes sure that the client is truly cleaned up, killing unjoined threads etc. So, exceptions not caught by hodRunner.operation() or hodRunner.script(), will by-pass sys.exit method and thus can potentially hang hod-client.
> For e.g., when hod allocate fails after allocation and before service-registry thread is cleaned up, hod client will hang.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-4161) [HOD] Uncaught exceptions can potentially hang hod-client.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod K V reassigned HADOOP-4161:
---------------------------------

    Assignee: Vinod K V

> [HOD] Uncaught exceptions can potentially hang hod-client.
> ----------------------------------------------------------
>
>                 Key: HADOOP-4161
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4161
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hod
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>             Fix For: 0.18.1, 0.19.0
>
>
> In hod-client, we have
> {code}
> sys.exit(hod.operation())
> sys.exit(hod.script())
> {code}
> sys.exit(opCode) makes sure that the client is truly cleaned up, killing unjoined threads etc. So, exceptions not caught by hodRunner.operation() or hodRunner.script(), will by-pass sys.exit method and thus can potentially hang hod-client.
> For e.g., when hod allocate fails after allocation and before service-registry thread is cleaned up, hod client will hang.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4161) [HOD] Uncaught exceptions can potentially hang hod-client.

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630215#action_12630215 ] 

Hemanth Yamijala commented on HADOOP-4161:
------------------------------------------

Patch looks good. +1

> [HOD] Uncaught exceptions can potentially hang hod-client.
> ----------------------------------------------------------
>
>                 Key: HADOOP-4161
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4161
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hod
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>             Fix For: 0.18.1, 0.19.0
>
>         Attachments: HADOOP-4161
>
>
> In hod-client, we have
> {code}
> sys.exit(hod.operation())
> sys.exit(hod.script())
> {code}
> sys.exit(opCode) makes sure that the client is truly cleaned up, killing unjoined threads etc. So, exceptions not caught by hodRunner.operation() or hodRunner.script(), will by-pass sys.exit method and thus can potentially hang hod-client.
> For e.g., when hod allocate fails after allocation and before service-registry thread is cleaned up, hod client will hang.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4161) [HOD] Uncaught exceptions can potentially hang hod-client.

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley updated HADOOP-4161:
--------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 0.19.0)
           Status: Resolved  (was: Patch Available)

I just committed this to trunk and branch-0.18.  Thanks Vinod!

> [HOD] Uncaught exceptions can potentially hang hod-client.
> ----------------------------------------------------------
>
>                 Key: HADOOP-4161
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4161
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hod
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>             Fix For: 0.18.1
>
>         Attachments: HADOOP-4161
>
>
> In hod-client, we have
> {code}
> sys.exit(hod.operation())
> sys.exit(hod.script())
> {code}
> sys.exit(opCode) makes sure that the client is truly cleaned up, killing unjoined threads etc. So, exceptions not caught by hodRunner.operation() or hodRunner.script(), will by-pass sys.exit method and thus can potentially hang hod-client.
> For e.g., when hod allocate fails after allocation and before service-registry thread is cleaned up, hod client will hang.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4161) [HOD] Uncaught exceptions can potentially hang hod-client.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod K V updated HADOOP-4161:
------------------------------

    Status: Patch Available  (was: Open)

> [HOD] Uncaught exceptions can potentially hang hod-client.
> ----------------------------------------------------------
>
>                 Key: HADOOP-4161
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4161
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hod
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>             Fix For: 0.18.1, 0.19.0
>
>         Attachments: HADOOP-4161
>
>
> In hod-client, we have
> {code}
> sys.exit(hod.operation())
> sys.exit(hod.script())
> {code}
> sys.exit(opCode) makes sure that the client is truly cleaned up, killing unjoined threads etc. So, exceptions not caught by hodRunner.operation() or hodRunner.script(), will by-pass sys.exit method and thus can potentially hang hod-client.
> For e.g., when hod allocate fails after allocation and before service-registry thread is cleaned up, hod client will hang.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4161) [HOD] Uncaught exceptions can potentially hang hod-client.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod K V updated HADOOP-4161:
------------------------------

    Component/s: contrib/hod

> [HOD] Uncaught exceptions can potentially hang hod-client.
> ----------------------------------------------------------
>
>                 Key: HADOOP-4161
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4161
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hod
>            Reporter: Vinod K V
>             Fix For: 0.18.1, 0.19.0
>
>
> In hod-client, we have
> {code}
> sys.exit(hod.operation())
> sys.exit(hod.script())
> {code}
> sys.exit(opCode) makes sure that the client is truly cleaned up, killing unjoined threads etc. So, exceptions not caught by hodRunner.operation() or hodRunner.script(), will by-pass sys.exit method and thus can potentially hang hod-client.
> For e.g., when hod allocate fails after allocation and before service-registry thread is cleaned up, hod client will hang.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.