You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Austin Nobis (Code Review)" <ge...@cloudera.org> on 2019/03/20 17:38:14 UTC
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt toSql
Austin Nobis has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12813
Change subject: IMPALA-8326: Fix CreateDropRoleStmt toSql
......................................................................
IMPALA-8326: Fix CreateDropRoleStmt toSql
Previously the CreateDropRoleStmt class' toSql method would
incorrectly order the stringified SQL statement as <role_name>
ROLE CREATE/DROP. This patch will properly order the statement
as CREATE/DROP ROLE <role_name>.
Testing:
- Ran all FE tests
Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
---
M fe/src/main/java/org/apache/impala/analysis/CreateDropRoleStmt.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
2 files changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/12813/2
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 2
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12813/3/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java:
http://gerrit.cloudera.org:8080/#/c/12813/3/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@1477
PS3, Line 1477:
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 3
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 17:50:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Austin Nobis (Code Review)" <ge...@cloudera.org>.
Austin Nobis has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
IMPALA-8326: Fix CreateDropRoleStmt::toSql
Previously the CreateDropRoleStmt::toSql method would incorrectly
order the stringified SQL statement as <role_name>ROLE CREATE/DROP.
This patch will properly order the statementas CREATE/DROP ROLE
<role_name>.
Testing:
- Ran all FE tests
- Added a new test to ToSqlTest for CreateDropRoleStmt
Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
---
M fe/src/main/java/org/apache/impala/analysis/CreateDropRoleStmt.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
2 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/12813/4
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 4
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 5
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 22:55:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3929/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 5
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 18:47:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2488/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 5
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 18:49:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Austin Nobis (Code Review)" <ge...@cloudera.org>.
Austin Nobis has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
IMPALA-8326: Fix CreateDropRoleStmt::toSql
Previously the CreateDropRoleStmt::toSql method would incorrectly
order the stringified SQL statement as <role_name>ROLE CREATE/DROP.
This patch will properly order the statementas CREATE/DROP ROLE
<role_name>.
Testing:
- Ran all FE tests
- Added a new test to ToSqlTest for CreateDropRoleStmt
Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
---
M fe/src/main/java/org/apache/impala/analysis/CreateDropRoleStmt.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
2 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/12813/3
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 3
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12813/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12813/4//COMMIT_MSG@10
PS4, Line 10: ROLE
nit: add space before?
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 4
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 18:21:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
IMPALA-8326: Fix CreateDropRoleStmt::toSql
Previously the CreateDropRoleStmt::toSql method would incorrectly
order the stringified SQL statement as <role_name> ROLE CREATE/DROP.
This patch will properly order the statementas CREATE/DROP ROLE
<role_name>.
Testing:
- Ran all FE tests
- Added a new test to ToSqlTest for CreateDropRoleStmt
Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Reviewed-on: http://gerrit.cloudera.org:8080/12813
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/CreateDropRoleStmt.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
2 files changed, 15 insertions(+), 1 deletion(-)
Approvals:
Fredy Wijaya: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 6
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Austin Nobis (Code Review)" <ge...@cloudera.org>.
Austin Nobis has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
IMPALA-8326: Fix CreateDropRoleStmt::toSql
Previously the CreateDropRoleStmt::toSql method would incorrectly
order the stringified SQL statement as <role_name> ROLE CREATE/DROP.
This patch will properly order the statementas CREATE/DROP ROLE
<role_name>.
Testing:
- Ran all FE tests
- Added a new test to ToSqlTest for CreateDropRoleStmt
Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
---
M fe/src/main/java/org/apache/impala/analysis/CreateDropRoleStmt.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
2 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/12813/5
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 5
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2483/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 2
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 18:04:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2487/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 4
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 18:51:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Austin Nobis (Code Review)" <ge...@cloudera.org>.
Austin Nobis has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12813/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12813/4//COMMIT_MSG@10
PS4, Line 10: ROL
> nit: add space before?
Done
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 5
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 18:23:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt toSql
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt toSql
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12813/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12813/2//COMMIT_MSG@7
PS2, Line 7: CreateDropRoleStmt toSql
nit: CreateDropRoleStmt::toSql
http://gerrit.cloudera.org:8080/#/c/12813/2//COMMIT_MSG@9
PS2, Line 9: CreateDropRoleStmt class' toSql
nit: CreateDropRoleStmt::toSql
http://gerrit.cloudera.org:8080/#/c/12813/2//COMMIT_MSG@15
PS2, Line 15: - Ran all FE tests
mention that you added a test for this.
http://gerrit.cloudera.org:8080/#/c/12813/2/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java:
http://gerrit.cloudera.org:8080/#/c/12813/2/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@1477
PS2, Line 1477: catalog_.addRole("test_role");
Put this in try/finally and delete it again afterwards. We don't want this role to be available for other tests.
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 2
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 17:45:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2485/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 3
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 18:20:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
Patch Set 5: Code-Review+2
Thanks for fixing this and added a missing test. LGTM.
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 5
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 18:47:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql
Posted by "Austin Nobis (Code Review)" <ge...@cloudera.org>.
Austin Nobis has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12813/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12813/2//COMMIT_MSG@7
PS2, Line 7: CreateDropRoleStmt::toSq
> nit: CreateDropRoleStmt::toSql
Done
http://gerrit.cloudera.org:8080/#/c/12813/2//COMMIT_MSG@9
PS2, Line 9: CreateDropRoleStmt::toSql metho
> nit: CreateDropRoleStmt::toSql
Done
http://gerrit.cloudera.org:8080/#/c/12813/2//COMMIT_MSG@15
PS2, Line 15: - Ran all FE tests
> mention that you added a test for this.
Done
http://gerrit.cloudera.org:8080/#/c/12813/2/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java:
http://gerrit.cloudera.org:8080/#/c/12813/2/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@1477
PS2, Line 1477:
> Put this in try/finally and delete it again afterwards. We don't want this
Done
--
To view, visit http://gerrit.cloudera.org:8080/12813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a
Gerrit-Change-Number: 12813
Gerrit-PatchSet: 3
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 17:49:35 +0000
Gerrit-HasComments: Yes