You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/03/17 04:29:32 UTC
Review Request 32149: Enable 'Resources::apply' to handle reservation
operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Bugs: MESOS-2477
https://issues.apache.org/jira/browse/MESOS-2477
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
Diff: https://reviews.apache.org/r/32149/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review81349
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On April 23, 2015, 4:38 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32149/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2477
> https://issues.apache.org/jira/browse/MESOS-2477
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
> src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
>
> Diff: https://reviews.apache.org/r/32149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review82348
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 1, 2015, 10:50 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32149/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 10:50 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2477
> https://issues.apache.org/jira/browse/MESOS-2477
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
> src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
>
> Diff: https://reviews.apache.org/r/32149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
-----------------------------------------------------------
(Updated May 1, 2015, 10:50 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Changes
-------
Addressed Jie's comment.
Bugs: MESOS-2477
https://issues.apache.org/jira/browse/MESOS-2477
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
Diff: https://reviews.apache.org/r/32149/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
-----------------------------------------------------------
(Updated April 27, 2015, 5:48 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Changes
-------
`s/snake_case/camelCase/`
Bugs: MESOS-2477
https://issues.apache.org/jira/browse/MESOS-2477
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
Diff: https://reviews.apache.org/r/32149/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review81364
-----------------------------------------------------------
src/tests/resources_tests.cpp
<https://reviews.apache.org/r/32149/#comment131708>
We do not use `snake_case`. Please use unreservedCpus and unreservedMem.
src/tests/resources_tests.cpp
<https://reviews.apache.org/r/32149/#comment131709>
Ditto.
- Jie Yu
On April 23, 2015, 4:38 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32149/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2477
> https://issues.apache.org/jira/browse/MESOS-2477
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
> src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
>
> Diff: https://reviews.apache.org/r/32149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
-----------------------------------------------------------
(Updated April 23, 2015, 4:38 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Changes
-------
Added a test for `unreserve`.
Bugs: MESOS-2477
https://issues.apache.org/jira/browse/MESOS-2477
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
Diff: https://reviews.apache.org/r/32149/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review81148
-----------------------------------------------------------
Ship it!
Modulo Tim's and Jie's comments.
- Alexander Rukletsov
On April 15, 2015, 4:12 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32149/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 4:12 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2477
> https://issues.apache.org/jira/browse/MESOS-2477
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
> src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
>
> Diff: https://reviews.apache.org/r/32149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
-----------------------------------------------------------
(Updated April 15, 2015, 4:12 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Summary (updated)
-----------------
Enabled 'Resources::apply' to handle reservation operations.
Bugs: MESOS-2477
https://issues.apache.org/jira/browse/MESOS-2477
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
Diff: https://reviews.apache.org/r/32149/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Michael Park <mc...@gmail.com>.
> On April 8, 2015, 9:19 p.m., Jie Yu wrote:
> > src/common/resources.cpp, line 663
> > <https://reviews.apache.org/r/32149/diff/4/?file=920084#file920084line663>
> >
> > Do you need to call validate(operation.reserve().resources()) first (like we did in CREATE/DESTROY)? Do you also want to check if each resource is dynamically reserved (i.e., has ReservationInfo, role != `*`)?
Both of the checks you mentioned are checked by
```
Option<Error> master::validation::operation::validate(
const Offer::Operation::Reserve& reserve,
const string& role,
const string& principal);
```
which the master calls before performing `apply`.
My thought here was that valid `Operation`s are a pre-condition of `apply` because while we can perform validation such as `role != "*"`, we cannot perform other necessary validations such as "does the resource's role match the framework's role", "does the specified `principal` match the framework's `principal`".
What do you think?
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review79430
-----------------------------------------------------------
On April 27, 2015, 5:48 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32149/
> -----------------------------------------------------------
>
> (Updated April 27, 2015, 5:48 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2477
> https://issues.apache.org/jira/browse/MESOS-2477
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
> src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
>
> Diff: https://reviews.apache.org/r/32149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Jie Yu <yu...@gmail.com>.
> On April 8, 2015, 9:19 p.m., Jie Yu wrote:
> > src/common/resources.cpp, line 663
> > <https://reviews.apache.org/r/32149/diff/4/?file=920084#file920084line663>
> >
> > Do you need to call validate(operation.reserve().resources()) first (like we did in CREATE/DESTROY)? Do you also want to check if each resource is dynamically reserved (i.e., has ReservationInfo, role != `*`)?
>
> Michael Park wrote:
> Both of the checks you mentioned are checked by
>
> ```
> Option<Error> master::validation::operation::validate(
> const Offer::Operation::Reserve& reserve,
> const string& role,
> const string& principal);
> ```
>
> which the master calls before performing `apply`.
>
> My thought here was that valid `Operation`s are a pre-condition of `apply` because while we can perform validation such as `role != "*"`, we cannot perform other necessary validations such as "does the resource's role match the framework's role", "does the specified `principal` match the framework's `principal`".
>
> What do you think?
Yeah, but a C++ framework writer would also like to use this method (e.g., see the sample C++ framework I recently checked in). So I think performing some minimal validation could give meaningful error messages to the framework writers in case they made mistakes.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review79430
-----------------------------------------------------------
On April 27, 2015, 5:48 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32149/
> -----------------------------------------------------------
>
> (Updated April 27, 2015, 5:48 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2477
> https://issues.apache.org/jira/browse/MESOS-2477
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
> src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
>
> Diff: https://reviews.apache.org/r/32149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32149: Enabled 'Resources::apply' to handle
reservation operations.
Posted by Michael Park <mc...@gmail.com>.
> On April 8, 2015, 9:19 p.m., Jie Yu wrote:
> > src/common/resources.cpp, line 663
> > <https://reviews.apache.org/r/32149/diff/4/?file=920084#file920084line663>
> >
> > Do you need to call validate(operation.reserve().resources()) first (like we did in CREATE/DESTROY)? Do you also want to check if each resource is dynamically reserved (i.e., has ReservationInfo, role != `*`)?
>
> Michael Park wrote:
> Both of the checks you mentioned are checked by
>
> ```
> Option<Error> master::validation::operation::validate(
> const Offer::Operation::Reserve& reserve,
> const string& role,
> const string& principal);
> ```
>
> which the master calls before performing `apply`.
>
> My thought here was that valid `Operation`s are a pre-condition of `apply` because while we can perform validation such as `role != "*"`, we cannot perform other necessary validations such as "does the resource's role match the framework's role", "does the specified `principal` match the framework's `principal`".
>
> What do you think?
>
> Jie Yu wrote:
> Yeah, but a C++ framework writer would also like to use this method (e.g., see the sample C++ framework I recently checked in). So I think performing some minimal validation could give meaningful error messages to the framework writers in case they made mistakes.
Understood. Added the extra validation.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review79430
-----------------------------------------------------------
On May 1, 2015, 10:50 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32149/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 10:50 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2477
> https://issues.apache.org/jira/browse/MESOS-2477
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
> src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
>
> Diff: https://reviews.apache.org/r/32149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32149: Enable 'Resources::apply' to handle
reservation operations.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review79430
-----------------------------------------------------------
src/common/resources.cpp
<https://reviews.apache.org/r/32149/#comment128786>
Do you need to call validate(operation.reserve().resources()) first (like we did in CREATE/DESTROY)? Do you also want to check if each resource is dynamically reserved (i.e., has ReservationInfo, role != `*`)?
- Jie Yu
On April 7, 2015, 10:25 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32149/
> -----------------------------------------------------------
>
> (Updated April 7, 2015, 10:25 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2477
> https://issues.apache.org/jira/browse/MESOS-2477
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
> src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
>
> Diff: https://reviews.apache.org/r/32149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32149: Enable 'Resources::apply' to handle
reservation operations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
-----------------------------------------------------------
(Updated April 7, 2015, 10:25 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Bugs: MESOS-2477
https://issues.apache.org/jira/browse/MESOS-2477
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
Diff: https://reviews.apache.org/r/32149/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 32149: Enable 'Resources::apply' to handle
reservation operations.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review77768
-----------------------------------------------------------
src/tests/resources_tests.cpp
<https://reviews.apache.org/r/32149/#comment125966>
How about a test for unreserving?
- Timothy Chen
On March 18, 2015, 5:26 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32149/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 5:26 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2477
> https://issues.apache.org/jira/browse/MESOS-2477
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
> src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
>
> Diff: https://reviews.apache.org/r/32149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32149: Enable 'Resources::apply' to handle
reservation operations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
-----------------------------------------------------------
(Updated March 18, 2015, 5:26 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Changes
-------
Added a test.
Bugs: MESOS-2477
https://issues.apache.org/jira/browse/MESOS-2477
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
Diff: https://reviews.apache.org/r/32149/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 32149: Enable 'Resources::apply' to handle
reservation operations.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review76859
-----------------------------------------------------------
LGTM.
- Alexander Rukletsov
On March 17, 2015, 4:06 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32149/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 4:06 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2477
> https://issues.apache.org/jira/browse/MESOS-2477
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
>
> Diff: https://reviews.apache.org/r/32149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32149: Enable 'Resources::apply' to handle
reservation operations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
-----------------------------------------------------------
(Updated March 17, 2015, 4:06 a.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Bugs: MESOS-2477
https://issues.apache.org/jira/browse/MESOS-2477
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
Diff: https://reviews.apache.org/r/32149/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 32149: Enable 'Resources::apply' to handle
reservation operations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/
-----------------------------------------------------------
(Updated March 17, 2015, 3:37 a.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Bugs: MESOS-2477
https://issues.apache.org/jira/browse/MESOS-2477
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
Diff: https://reviews.apache.org/r/32149/diff/
Testing
-------
make check
Thanks,
Michael Park