[GitHub] [netbeans] fcorneli commented on a change in pull request #2560: [NETBEANS-5057] improved help on JSF composite component attributes

[GitBox <gi...@apache.org>]

fcorneli commented on a change in pull request #2560:
URL: https://github.com/apache/netbeans/pull/2560#discussion_r531218214



##########
File path: enterprise/web.jsf.editor/src/org/netbeans/modules/web/jsf/editor/facelets/CompositeComponentLibrary.java
##########
@@ -250,9 +250,11 @@ private synchronized void load() {
                 for (Map<String, String> attrsMap : model.getExistingInterfaceAttributes()) {
                     String attrname = attrsMap.get("name"); //NOI18N
                     boolean required = Boolean.parseBoolean(attrsMap.get("required")); //NOI18N
-                    String attributeDescription = getAttributesDescription(model, true);
+                    String attributeDescription = attrsMap.get("shortDescription"); //NOI18N

Review comment:
       With `getAttributesDescription` you used to get the description of all attributes on each individual attribute, without any distinction. Hence the full list all over the place. By using `shortDescription`, you really get just the description of the corresponding attribute, which is what you actually want to see.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists