[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4590: [Runtime] add necessary const qualifier for NDArray container of function parameters

[GitBox <gi...@apache.org>]

tqchen commented on a change in pull request #4590: [Runtime] add necessary const qualifier for NDArray container of function parameters
URL: https://github.com/apache/incubator-tvm/pull/4590#discussion_r361590582
 
 

 ##########
 File path: include/tvm/runtime/c_runtime_api.h
 ##########
 @@ -136,13 +136,16 @@ typedef DLDataType TVMType;
 typedef DLContext TVMContext;
 
 /*!
- * \brief The tensor array stucture to TVM API.
+ * \brief The tensor array structure to TVM API.
  */
 typedef DLTensor TVMArray;
 
 /*! \brief the array handle */
 typedef TVMArray* TVMArrayHandle;
 
+/*! \brief the const array handle */
+typedef const TVMArray* kTVMArrayHandle;
 
 Review comment:
   k prefix in the Google C style refers to constant numbers as opposed to types. so we should not make this change 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services