[GitHub] [inlong] gong commented on a diff in pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

["gong (via GitHub)" <gi...@apache.org>]

gong commented on code in PR #8095:
URL: https://github.com/apache/inlong/pull/8095#discussion_r1208796949


##########
inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java:
##########
@@ -42,7 +44,7 @@ public class SchemaChangeUtils {
 
     /**
      * Compare two schemas and get the schema changes that happened in them.
-     * TODO: currently only support add column
+     * TODO: currently only support add column,delete column and update column(column type change)

Review Comment:
   `update column` include too many situation. Maybe differentiation of fine grains is better, not use `update column`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org