You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/12 12:24:32 UTC

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #8857: simplify kafka configuration in cluster mode

wu-sheng commented on code in PR #8857:
URL: https://github.com/apache/skywalking/pull/8857#discussion_r848373491


##########
oap-server/server-fetcher-plugin/kafka-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/analyzer/agent/kafka/provider/handler/MeterServiceHandler.java:
##########
@@ -71,11 +71,11 @@ public MeterServiceHandler(ModuleManager manager, KafkaFetcherConfig config) {
 
     @Override
     public void handle(final ConsumerRecord<String, Bytes> record) {
-        try (HistogramMetrics.Timer timer = histogramBatch.createTimer()) {
+        try (HistogramMetrics.Timer ignored = histogramBatch.createTimer()) {

Review Comment:
   `timer` to `ignored`? What is the new naming style?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org