You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/03/23 15:04:59 UTC
[GitHub] [pulsar] merlimat commented on a change in pull request #3887:
Support Kafka's ConsumerConfig.MAX_POLL_RECORDS_CONFIG to config max number
of message will return in a single poll
merlimat commented on a change in pull request #3887: Support Kafka's ConsumerConfig.MAX_POLL_RECORDS_CONFIG to config max number of message will return in a single poll
URL: https://github.com/apache/pulsar/pull/3887#discussion_r268397827
##########
File path: pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java
##########
@@ -304,8 +313,6 @@ public void unsubscribe() {
});
}
- private static final int MAX_RECORDS_IN_SINGLE_POLL = 1000;
Review comment:
we should still use the constant for `1000`, maybe renaming to `DEFAULT_MAX_RECORDS_IN_SINGLE_POLL`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services