[jira] [Commented] (HBASE-21153) Shaded client jars should always build in relevant phase to avoid confusion

["Sean Busbey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604873#comment-16604873 ] 

Sean Busbey commented on HBASE-21153:
-------------------------------------

Reproduced the error locally and it's even more confusing if you're on a Hadoop version missing YARN-7190. In that case my 2.1.1-SNAPSHOT build reported the hbase version as 1.2.6. :(

> Shaded client jars should always build in relevant phase to avoid confusion
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-21153
>                 URL: https://issues.apache.org/jira/browse/HBASE-21153
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.1.0, 2.2.0
>            Reporter: stack
>            Assignee: Sean Busbey
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0, 2.1.1
>
>         Attachments: ls.txt
>
>
> *edit*:
> Now that our assembly directly relies on the shaded clients, failing to build the actual client jars (e.g. because {{-P release}} is required to fill in their contents) causes confusing errors for downstream folks about classes not being found when they run simple commands like {{hbase version}}.
> We should always fill in the shaded artifacts to make our build easier to understand.
> *original report:*: When I run the {{hbase version}} command it comes back with:
> {code}$ ./bin/hbase version
> Error: Could not find or load main class org.apache.hadoop.hbase.util.GetJavaProperty
> Error: Could not find or load main class org.apache.hadoop.hbase.util.VersionInfo{code}
> The two classes are in hbase-commons.
> The nice shaded refactoring of our bin/hbase -- i.e. using shaded jars wherever possible -- may have overstretched expecting version to work with shaded client ([~busbey] ?).  If so, fix is < one-liner.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)