You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Bryan Call <bc...@apache.org> on 2021/09/21 16:00:03 UTC
[DISCUSS] Removing the INKUDP* APIs
During the bug scrub on Monday we came across this issue: https://github.com/apache/trafficserver/issues/6245 <https://github.com/apache/trafficserver/issues/6245>
The proposal is to remove the INKUDP* APIs in InkAPIPrivateIOCore.h (https://github.com/apache/trafficserver/blob/master/include/ts/InkAPIPrivateIOCore.h#L141 <https://github.com/apache/trafficserver/blob/master/include/ts/InkAPIPrivateIOCore.h#L141>). I don’t believe they are used at all and there is no testing done around these APIs.
Please voice your support to either keep or remove these APIs.
Thank you,
-Bryan
Re: [DISCUSS] Removing the INKUDP* APIs
Posted by SUSAN HINRICHS <sh...@ieee.org.INVALID>.
+1
On Tue, Sep 28, 2021, 2:31 PM Leif Hedstrom <zw...@apache.org> wrote:
>
>
> > On Sep 28, 2021, at 11:19 AM, Randall Meyer <ra...@yahoo.com.INVALID>
> wrote:
> >
> > I agree with Masakazu and am +1 for removing these APIs.
>
> +1
>
> — Leif
>
>
Re: [DISCUSS] Removing the INKUDP* APIs
Posted by Leif Hedstrom <zw...@apache.org>.
> On Sep 28, 2021, at 11:19 AM, Randall Meyer <ra...@yahoo.com.INVALID> wrote:
>
> I agree with Masakazu and am +1 for removing these APIs.
+1
— Leif
Re: [DISCUSS] Removing the INKUDP* APIs
Posted by Randall Meyer <ra...@yahoo.com.INVALID>.
I agree with Masakazu and am +1 for removing these APIs.
-r
On Tuesday, September 28, 2021, 01:19:29 AM PDT, Masakazu Kitajo <ma...@apache.org> wrote:
Let's remove the APIs.
One week of silence probably means nobody cares about the APIs. If we keep
the APIs, I want the maintainer to propose the APIs as official TS APIs and
add documentation to make it clear that those are available for plugins. If
nobody volunteers, we should remove the APIs. We can't keep things that
nobody maintains.
Tests for the APIs were removed 3 years ago (
https://github.com/apache/trafficserver/pull/3784), btw.
Masakazu
On Wed, Sep 22, 2021 at 1:00 AM Bryan Call <bc...@apache.org> wrote:
> During the bug scrub on Monday we came across this issue:
> https://github.com/apache/trafficserver/issues/6245 <
> https://github.com/apache/trafficserver/issues/6245>
>
> The proposal is to remove the INKUDP* APIs in InkAPIPrivateIOCore.h (
> https://github.com/apache/trafficserver/blob/master/include/ts/InkAPIPrivateIOCore.h#L141
> <
> https://github.com/apache/trafficserver/blob/master/include/ts/InkAPIPrivateIOCore.h#L141>).
> I don’t believe they are used at all and there is no testing done around
> these APIs.
>
> Please voice your support to either keep or remove these APIs.
>
> Thank you,
>
> -Bryan
>
>
>
Re: [DISCUSS] Removing the INKUDP* APIs
Posted by Masakazu Kitajo <ma...@apache.org>.
Let's remove the APIs.
One week of silence probably means nobody cares about the APIs. If we keep
the APIs, I want the maintainer to propose the APIs as official TS APIs and
add documentation to make it clear that those are available for plugins. If
nobody volunteers, we should remove the APIs. We can't keep things that
nobody maintains.
Tests for the APIs were removed 3 years ago (
https://github.com/apache/trafficserver/pull/3784), btw.
Masakazu
On Wed, Sep 22, 2021 at 1:00 AM Bryan Call <bc...@apache.org> wrote:
> During the bug scrub on Monday we came across this issue:
> https://github.com/apache/trafficserver/issues/6245 <
> https://github.com/apache/trafficserver/issues/6245>
>
> The proposal is to remove the INKUDP* APIs in InkAPIPrivateIOCore.h (
> https://github.com/apache/trafficserver/blob/master/include/ts/InkAPIPrivateIOCore.h#L141
> <
> https://github.com/apache/trafficserver/blob/master/include/ts/InkAPIPrivateIOCore.h#L141>).
> I don’t believe they are used at all and there is no testing done around
> these APIs.
>
> Please voice your support to either keep or remove these APIs.
>
> Thank you,
>
> -Bryan
>
>
>