You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/06/12 21:27:40 UTC

[GitHub] [iceberg] Fokko commented on a diff in pull request #7823: Fixes for D205 issues

Fokko commented on code in PR #7823:
URL: https://github.com/apache/iceberg/pull/7823#discussion_r1227261055


##########
python/pyiceberg/conversions.py:
##########
@@ -109,6 +109,8 @@ def _(primitive_type: BooleanType, value_str: str) -> Union[int, float, str, uui
 @handle_none
 def _(primitive_type: PrimitiveType, value_str: str) -> int:
     """
+    Converts a string to an integer value

Review Comment:
   Shouldn't this one be one line up?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org