You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "CurtHagenlocher (via GitHub)" <gi...@apache.org> on 2023/05/20 20:47:42 UTC
[GitHub] [arrow] CurtHagenlocher opened a new pull request, #35699: GH-35698: [C#] Update FlatBuffers
CurtHagenlocher opened a new pull request, #35699:
URL: https://github.com/apache/arrow/pull/35699
### Rationale for this change
The FlatBuffers definitions in the C# code don't seem to have been updated for a while. Adding the latest FlatBuffers code ensures that we're up to date with both the Arrow definitions and the FlatBuffers compiler.
### What changes are included in this PR?
The latest version of the C# FlatBuffers runtime files were copied into the project (with visibility changed from public to internal).
The latest version of the FlatBuffers compiler was used against the latest version of the Arrow .fbs source. The output of the compiler was edited to more closely match the existing code by moving it into the directory structure and namespaces of the existing classes and by changing class visibility from public to internal.
A few small changes were made to the existing source to accommodate changes in the FlatBuffers runtime, most specifically that the files have moved from the namespace "FlatBuffers" to the namespace "Google.FlatBuffers".
### Are these changes tested?
No substantive product changes were made. All tests still pass.
### Are there any user-facing changes?
No.
Resolves #35698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #35699: GH-35698: [C#] Update FlatBuffers
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #35699:
URL: https://github.com/apache/arrow/pull/35699#issuecomment-1652330536
@CurtHagenlocher is there still value in this PR (I'm not aware of any reason there isn't but it's been a few minutes and I just wanted to double-check before spending any significant time reviewing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35699: GH-35698: [C#] Update FlatBuffers
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35699:
URL: https://github.com/apache/arrow/pull/35699#issuecomment-1555998647
:warning: GitHub issue #35698 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #35699: GH-35698: [C#] Update FlatBuffers
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #35699:
URL: https://github.com/apache/arrow/pull/35699#issuecomment-1683341615
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 0e677d27ae8ed489f2fa6f5e95b0e498319a887e.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/16000490386) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] CurtHagenlocher commented on pull request #35699: GH-35698: [C#] Update FlatBuffers
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #35699:
URL: https://github.com/apache/arrow/pull/35699#issuecomment-1652507889
@westonpace Yes, this is still worthwhile. At some point we'll want to implement whatever the final "alternate string view" design is, and being up-to-date on fbs-derived stuff will make that an easier to follow change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace merged pull request #35699: GH-35698: [C#] Update FlatBuffers
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace merged PR #35699:
URL: https://github.com/apache/arrow/pull/35699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35699: GH-35698: [C#] Update FlatBuffers
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35699:
URL: https://github.com/apache/arrow/pull/35699#issuecomment-1555998639
* Closes: #35698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org