You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/23 16:58:20 UTC

[GitHub] [pulsar] nicoloboschi opened a new pull request, #18583: [fix][build] Include Pulsar shell in the released artifacts

nicoloboschi opened a new pull request, #18583:
URL: https://github.com/apache/pulsar/pull/18583

   ### Motivation
   
   The current release process doesn't stage the pulsar shell artifacts. Pulsar shell is going to be released in 2.11.0 
   
   ### Modifications
   
   * Add the .tar.gz and .zip pulsar shell artifacts to the stage-artifacts procedure
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   
   note: we should update the release process in the pulsar-site repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codecov-commenter commented on pull request #18583: [fix][build] Include Pulsar shell in the released artifacts

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18583:
URL: https://github.com/apache/pulsar/pull/18583#issuecomment-1325433809

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/18583?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#18583](https://codecov.io/gh/apache/pulsar/pull/18583?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1060d2f) into [master](https://codecov.io/gh/apache/pulsar/commit/be1d07e16119fafbe489315ab68c4751bf03c31d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be1d07e) will **decrease** coverage by `6.21%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/18583/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/18583?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18583      +/-   ##
   ============================================
   - Coverage     36.82%   30.60%   -6.22%     
   + Complexity     7842     5626    -2216     
   ============================================
     Files           698      592     -106     
     Lines         68060    56322   -11738     
     Branches       7277     5848    -1429     
   ============================================
   - Hits          25062    17240    -7822     
   + Misses        39675    36685    -2990     
   + Partials       3323     2397     -926     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `30.60% <ø> (-6.22%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/18583?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sar/broker/stats/metrics/ManagedLedgerMetrics.java](https://codecov.io/gh/apache/pulsar/pull/18583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9tZXRyaWNzL01hbmFnZWRMZWRnZXJNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ker/service/schema/exceptions/SchemaException.java](https://codecov.io/gh/apache/pulsar/pull/18583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9leGNlcHRpb25zL1NjaGVtYUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...naming/RangeEquallyDivideBundleSplitAlgorithm.java](https://codecov.io/gh/apache/pulsar/pull/18583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9uYW1pbmcvUmFuZ2VFcXVhbGx5RGl2aWRlQnVuZGxlU3BsaXRBbGdvcml0aG0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...roker/stats/metrics/ManagedLedgerCacheMetrics.java](https://codecov.io/gh/apache/pulsar/pull/18583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9tZXRyaWNzL01hbmFnZWRMZWRnZXJDYWNoZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
   | [...g/apache/pulsar/broker/stats/MetricsGenerator.java](https://codecov.io/gh/apache/pulsar/pull/18583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9NZXRyaWNzR2VuZXJhdG9yLmphdmE=) | `23.80% <0.00%> (-76.20%)` | :arrow_down: |
   | [...schema/exceptions/IncompatibleSchemaException.java](https://codecov.io/gh/apache/pulsar/pull/18583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9leGNlcHRpb25zL0luY29tcGF0aWJsZVNjaGVtYUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...r/common/naming/NamespaceBundleSplitAlgorithm.java](https://codecov.io/gh/apache/pulsar/pull/18583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9uYW1pbmcvTmFtZXNwYWNlQnVuZGxlU3BsaXRBbGdvcml0aG0uamF2YQ==) | `0.00% <0.00%> (-61.54%)` | :arrow_down: |
   | [...vice/schema/AvroSchemaBasedCompatibilityCheck.java](https://codecov.io/gh/apache/pulsar/pull/18583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9BdnJvU2NoZW1hQmFzZWRDb21wYXRpYmlsaXR5Q2hlY2suamF2YQ==) | `5.71% <0.00%> (-60.01%)` | :arrow_down: |
   | [...rvice/schema/KeyValueSchemaCompatibilityCheck.java](https://codecov.io/gh/apache/pulsar/pull/18583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9LZXlWYWx1ZVNjaGVtYUNvbXBhdGliaWxpdHlDaGVjay5qYXZh) | `8.10% <0.00%> (-59.46%)` | :arrow_down: |
   | [...e/pulsar/broker/stats/metrics/AbstractMetrics.java](https://codecov.io/gh/apache/pulsar/pull/18583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9tZXRyaWNzL0Fic3RyYWN0TWV0cmljcy5qYXZh) | `0.00% <0.00%> (-54.06%)` | :arrow_down: |
   | ... and [197 more](https://codecov.io/gh/apache/pulsar/pull/18583/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on pull request #18583: [fix][build] Include Pulsar shell in the released artifacts

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18583:
URL: https://github.com/apache/pulsar/pull/18583#issuecomment-1325402414

   It seems the release action of 2.11.0 is performed against branch-2.11 so we need a cherry-pick.
   
   Also, cc @Technoboy- as the release manager of 2.11.0 FYI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- commented on pull request #18583: [fix][build] Include Pulsar shell in the released artifacts

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #18583:
URL: https://github.com/apache/pulsar/pull/18583#issuecomment-1325875708

   > Merging...
   > 
   > @nicoloboschi @Technoboy- how do you think this patch should be cherry-picked to branch-2.11?
   
   I will do this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun merged pull request #18583: [fix][build] Include Pulsar shell in the released artifacts

Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #18583:
URL: https://github.com/apache/pulsar/pull/18583


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nicoloboschi closed pull request #18583: [fix][build] Include Pulsar shell in the released artifacts

Posted by GitBox <gi...@apache.org>.
nicoloboschi closed pull request #18583: [fix][build] Include Pulsar shell in the released artifacts
URL: https://github.com/apache/pulsar/pull/18583


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org