You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Olivier Lamy <ol...@apache.org> on 2012/11/12 18:05:26 UTC
MNG-5356 Make encrypt/decrypt logic pluggable
Changes looks good for me.
Most of the large changes has been done Karin Karlsson (can we have cla ?)
Any special reason to use a package org.maven ?
New files doesn't have license header but " //TODO: add copyright "
Thanks
--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: MNG-5356 Make encrypt/decrypt logic pluggable
Posted by Stephen Connolly <st...@gmail.com>.
On 13 November 2012 11:28, Anders Hammar <an...@hammar.net> wrote:
> > Changes looks good for me.
> >
>
> Thanks for having a look!
> One specific thing I'm not sure about is the maven-security artifactId. Is
> it good, or should we maybe use maven-crypto. maven-security could in the
> future contain more than the crypto things.
>
> Most of the large changes has been done Karin Karlsson (can we have cla ?)
> >
>
> I realized that as well. I will get a CLA for Devoteam Sweden in place as
> she's been doing this as part of her work with Devoteam. I believe that's
> the proper level of CLA in this case, right?
>
I think we'll need a cCLA from Devoteam and an ICLA from her
>
> Any special reason to use a package org.maven ?
> >
> > New files doesn't have license header but " //TODO: add copyright "
> >
>
> Yes, there's still some polishing to do here. It's still work in progress.
>
> /Anders
>
>
> >
> > Thanks
> > --
> > Olivier Lamy
> > Talend: http://coders.talend.com
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
> > --
> > Olivier Lamy
> > Talend: http://coders.talend.com
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
Re: MNG-5356 Make encrypt/decrypt logic pluggable
Posted by Anders Hammar <an...@hammar.net>.
Ok. I'll see to that she signs a cla.
/Anders (mobile)
Den 13 nov 2012 17:28 skrev "Stephen Connolly" <
stephen.alan.connolly@gmail.com>:
> On 13 November 2012 15:04, Olivier Lamy <ol...@apache.org> wrote:
>
> > 2012/11/13 Anders Hammar <an...@hammar.net>:
> > >> Changes looks good for me.
> > >>
> > >
> > > Thanks for having a look!
> > > One specific thing I'm not sure about is the maven-security artifactId.
> > Is
> > > it good, or should we maybe use maven-crypto. maven-security could in
> the
> > > future contain more than the crypto things.
> > >
> > > Most of the large changes has been done Karin Karlsson (can we have cla
> > ?)
> > >>
> > >
> > > I realized that as well. I will get a CLA for Devoteam Sweden in place
> as
> > > she's been doing this as part of her work with Devoteam. I believe
> that's
> > > the proper level of CLA in this case, right?
> >
> > iCLA is mandatory but not CCLA that's only optional (see
> > http://markmail.org/message/4fit2o33yjj5pxyt )
> >
>
> Technically correct, though *Karin* may want the CCLA or at least something
> from Devoteam to say she is ok contributing it under an ICLA that she has
> signed.
>
> We only need the ICLA on file... but the contributor may want to cover
> their own ass... hence they may want the CCLA ;-)
>
>
> >
> > >
> > > Any special reason to use a package org.maven ?
> > >>
> > >> New files doesn't have license header but " //TODO: add copyright "
> > >>
> > >
> > > Yes, there's still some polishing to do here. It's still work in
> > progress.
> > >
> > > /Anders
> > >
> > >
> > >>
> > >> Thanks
> > >> --
> > >> Olivier Lamy
> > >> Talend: http://coders.talend.com
> > >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >>
> > >> --
> > >> Olivier Lamy
> > >> Talend: http://coders.talend.com
> > >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >> For additional commands, e-mail: dev-help@maven.apache.org
> > >>
> > >>
> >
> >
> >
> > --
> > Olivier Lamy
> > Talend: http://coders.talend.com
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
Re: MNG-5356 Make encrypt/decrypt logic pluggable
Posted by Stephen Connolly <st...@gmail.com>.
On 13 November 2012 15:04, Olivier Lamy <ol...@apache.org> wrote:
> 2012/11/13 Anders Hammar <an...@hammar.net>:
> >> Changes looks good for me.
> >>
> >
> > Thanks for having a look!
> > One specific thing I'm not sure about is the maven-security artifactId.
> Is
> > it good, or should we maybe use maven-crypto. maven-security could in the
> > future contain more than the crypto things.
> >
> > Most of the large changes has been done Karin Karlsson (can we have cla
> ?)
> >>
> >
> > I realized that as well. I will get a CLA for Devoteam Sweden in place as
> > she's been doing this as part of her work with Devoteam. I believe that's
> > the proper level of CLA in this case, right?
>
> iCLA is mandatory but not CCLA that's only optional (see
> http://markmail.org/message/4fit2o33yjj5pxyt )
>
Technically correct, though *Karin* may want the CCLA or at least something
from Devoteam to say she is ok contributing it under an ICLA that she has
signed.
We only need the ICLA on file... but the contributor may want to cover
their own ass... hence they may want the CCLA ;-)
>
> >
> > Any special reason to use a package org.maven ?
> >>
> >> New files doesn't have license header but " //TODO: add copyright "
> >>
> >
> > Yes, there's still some polishing to do here. It's still work in
> progress.
> >
> > /Anders
> >
> >
> >>
> >> Thanks
> >> --
> >> Olivier Lamy
> >> Talend: http://coders.talend.com
> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> >>
> >> --
> >> Olivier Lamy
> >> Talend: http://coders.talend.com
> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >>
>
>
>
> --
> Olivier Lamy
> Talend: http://coders.talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: MNG-5356 Make encrypt/decrypt logic pluggable
Posted by Olivier Lamy <ol...@apache.org>.
2012/11/13 Anders Hammar <an...@hammar.net>:
>> Changes looks good for me.
>>
>
> Thanks for having a look!
> One specific thing I'm not sure about is the maven-security artifactId. Is
> it good, or should we maybe use maven-crypto. maven-security could in the
> future contain more than the crypto things.
>
> Most of the large changes has been done Karin Karlsson (can we have cla ?)
>>
>
> I realized that as well. I will get a CLA for Devoteam Sweden in place as
> she's been doing this as part of her work with Devoteam. I believe that's
> the proper level of CLA in this case, right?
iCLA is mandatory but not CCLA that's only optional (see
http://markmail.org/message/4fit2o33yjj5pxyt )
>
> Any special reason to use a package org.maven ?
>>
>> New files doesn't have license header but " //TODO: add copyright "
>>
>
> Yes, there's still some polishing to do here. It's still work in progress.
>
> /Anders
>
>
>>
>> Thanks
>> --
>> Olivier Lamy
>> Talend: http://coders.talend.com
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
>> --
>> Olivier Lamy
>> Talend: http://coders.talend.com
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: MNG-5356 Make encrypt/decrypt logic pluggable
Posted by Anders Hammar <an...@hammar.net>.
> Changes looks good for me.
>
Thanks for having a look!
One specific thing I'm not sure about is the maven-security artifactId. Is
it good, or should we maybe use maven-crypto. maven-security could in the
future contain more than the crypto things.
Most of the large changes has been done Karin Karlsson (can we have cla ?)
>
I realized that as well. I will get a CLA for Devoteam Sweden in place as
she's been doing this as part of her work with Devoteam. I believe that's
the proper level of CLA in this case, right?
Any special reason to use a package org.maven ?
>
> New files doesn't have license header but " //TODO: add copyright "
>
Yes, there's still some polishing to do here. It's still work in progress.
/Anders
>
> Thanks
> --
> Olivier Lamy
> Talend: http://coders.talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
> --
> Olivier Lamy
> Talend: http://coders.talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Fwd: MNG-5356 Make encrypt/decrypt logic pluggable
Posted by Olivier Lamy <ol...@gmail.com>.
resend as I have issues with my @apache.o mailbox.
---------- Forwarded message ----------
From: Olivier Lamy <ol...@apache.org>
Date: 2012/11/12
Subject: MNG-5356 Make encrypt/decrypt logic pluggable
To: Maven Developers List <de...@maven.apache.org>
Changes looks good for me.
Most of the large changes has been done Karin Karlsson (can we have cla ?)
Any special reason to use a package org.maven ?
New files doesn't have license header but " //TODO: add copyright "
Thanks
--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org