You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/08 01:27:36 UTC
[GitHub] [zookeeper] belugabehr opened a new pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class
belugabehr opened a new pull request #1192:
URL: https://github.com/apache/zookeeper/pull/1192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] belugabehr commented on pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1192:
URL: https://github.com/apache/zookeeper/pull/1192#issuecomment-720612573
@nkalmar Alright. All set now :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] nkalmar commented on pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class
Posted by GitBox <gi...@apache.org>.
nkalmar commented on pull request #1192:
URL: https://github.com/apache/zookeeper/pull/1192#issuecomment-721218941
Merging! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] belugabehr commented on pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1192:
URL: https://github.com/apache/zookeeper/pull/1192#issuecomment-632091841
@nkalmar Mind taking a look at this one also?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] nkalmar commented on pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class
Posted by GitBox <gi...@apache.org>.
nkalmar commented on pull request #1192:
URL: https://github.com/apache/zookeeper/pull/1192#issuecomment-721220507
Merged to master, thanks @belugabehr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] belugabehr commented on pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1192:
URL: https://github.com/apache/zookeeper/pull/1192#issuecomment-721182751
@eolivelli How about this one then? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] belugabehr commented on pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1192:
URL: https://github.com/apache/zookeeper/pull/1192#issuecomment-661053266
@enixon @lvfangmin @maoling Good to push? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1192:
URL: https://github.com/apache/zookeeper/pull/1192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1192:
URL: https://github.com/apache/zookeeper/pull/1192#issuecomment-712879861
I have restarted the CI build, there were errors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] belugabehr commented on pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1192:
URL: https://github.com/apache/zookeeper/pull/1192#issuecomment-721220066
@nkalmar A miracle worker! Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] belugabehr commented on pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1192:
URL: https://github.com/apache/zookeeper/pull/1192#issuecomment-712873648
@enixon @eolivelli Can you please consider accepting this PR into the project? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] belugabehr closed pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class
Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #1192:
URL: https://github.com/apache/zookeeper/pull/1192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1192: ZOOKEEPER-3662: Remove NPE Possibility in Follower Class
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1192:
URL: https://github.com/apache/zookeeper/pull/1192#issuecomment-712880605
can you please rebase or merge with current master ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org