You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zhaohai666 (via GitHub)" <gi...@apache.org> on 2023/08/31 03:04:15 UTC
[GitHub] [rocketmq-eventbridge] zhaohai666 opened a new pull request, #149: Add error code
zhaohai666 opened a new pull request, #149:
URL: https://github.com/apache/rocketmq-eventbridge/pull/149
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-eventbridge] 2011shenlin commented on a diff in pull request #149: Add error code
Posted by "2011shenlin (via GitHub)" <gi...@apache.org>.
2011shenlin commented on code in PR #149:
URL: https://github.com/apache/rocketmq-eventbridge/pull/149#discussion_r1311042543
##########
domain/src/main/java/org/apache/rocketmq/eventbridge/domain/common/exception/EventBridgeErrorCode.java:
##########
@@ -134,7 +135,10 @@ public enum EventBridgeErrorCode implements BaseErrorCode {
ClientSecretLengthExceed(409, "ClientSecretLengthExceed", "ClientSecret length cannot exceed 127!"),
AuthorizationEndpointLengthExceed(409, "AuthorizationEndpointLengthExceed", "Authorization endpoint length cannot exceed 127!"),
NetworkParametersIsEmpty(409, "NetworkParametersIsEmpty", "Network required parameter is empty!"),
- RequestParameterInvalid(409, "RequestParameterInvalid", "Request parameter Invalid!");
+ RequestParameterInvalid(409, "RequestParameterInvalid", "Request parameter Invalid!"),
+ CreatePrivateNetworkFailed(409, "CreatePrivateNetworkFailed", "Create private network failed!"),
+ DeletePrivateNetworkFailed(409, "DeletePrivateNetworkFailed", "Delete private network failed!"),
+ GetTotalQuotaFailed(409, "GetTotalQuotaFailed", "Query total quota failed!");
Review Comment:
这几个参数异常信息提示不够明确
##########
domain/src/main/java/org/apache/rocketmq/eventbridge/domain/common/exception/EventBridgeErrorCode.java:
##########
@@ -134,7 +135,10 @@ public enum EventBridgeErrorCode implements BaseErrorCode {
ClientSecretLengthExceed(409, "ClientSecretLengthExceed", "ClientSecret length cannot exceed 127!"),
AuthorizationEndpointLengthExceed(409, "AuthorizationEndpointLengthExceed", "Authorization endpoint length cannot exceed 127!"),
NetworkParametersIsEmpty(409, "NetworkParametersIsEmpty", "Network required parameter is empty!"),
- RequestParameterInvalid(409, "RequestParameterInvalid", "Request parameter Invalid!");
+ RequestParameterInvalid(409, "RequestParameterInvalid", "Request parameter Invalid!"),
+ CreatePrivateNetworkFailed(409, "CreatePrivateNetworkFailed", "Create private network failed!"),
+ DeletePrivateNetworkFailed(409, "DeletePrivateNetworkFailed", "Delete private network failed!"),
+ GetTotalQuotaFailed(409, "GetTotalQuotaFailed", "Query total quota failed!");
Review Comment:
这几个参数异常信息提示不够明确
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-eventbridge] zhaohai666 closed pull request #149: Add error code
Posted by "zhaohai666 (via GitHub)" <gi...@apache.org>.
zhaohai666 closed pull request #149: Add error code
URL: https://github.com/apache/rocketmq-eventbridge/pull/149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org