[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #692: DISPATCH-975: Implement max-message-size policy restrictions

[GitBox <gi...@apache.org>]

ganeshmurthy commented on a change in pull request #692: DISPATCH-975: Implement max-message-size policy restrictions
URL: https://github.com/apache/qpid-dispatch/pull/692#discussion_r383493833
 
 

 ##########
 File path: src/message.c
 ##########
 @@ -1301,6 +1301,10 @@ qd_message_t *qd_message_receive(pn_delivery_t *delivery)
         msg->strip_annotations_in  = qd_connection_strip_annotations_in(qdc);
         pn_record_def(record, PN_DELIVERY_CTX, PN_WEAKREF);
         pn_record_set(record, PN_DELIVERY_CTX, (void*) msg);
+        msg->content->max_message_size = qd_connection_max_message_size(qdc);
+    } else {
+        // existing messages may detect oversize transitions only once
+        msg->content->oversize_detected = false;
 
 Review comment:
   Is setting msg->content->oversize_detected  to false necessary ? 
   Calling ZERO (msg); already sets this flag to false. Also, once this flag becomes true it *should not* go to false?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org