You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/24 18:37:04 UTC
[jira] [Commented] (GEODE-2955) gfsh create lucene index command
should validate the region name parameter
[ https://issues.apache.org/jira/browse/GEODE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023416#comment-16023416 ]
ASF GitHub Bot commented on GEODE-2955:
---------------------------------------
GitHub user DivineEnder opened a pull request:
https://github.com/apache/geode/pull/531
GEODE-2955: Validating region names when creating lucene index
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DivineEnder/geode feature/GEODE-2955
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/531.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #531
----
commit 37449b92a7b67010e6ccac03ea8e8e1f8fa8c92f
Author: David Anuta <da...@gmail.com>
Date: 2017-05-24T18:34:39Z
GEODE-2955: Validating region names when creating lucene index
----
> gfsh create lucene index command should validate the region name parameter
> --------------------------------------------------------------------------
>
> Key: GEODE-2955
> URL: https://issues.apache.org/jira/browse/GEODE-2955
> Project: Geode
> Issue Type: Bug
> Components: lucene
> Reporter: Jason Huynh
> Assignee: David Anuta
>
> The gfsh command to create the lucene index should not only validate the lucene index name but also the region name. It currently is possible to pass an invalid region name as a parameter. The region will then not be able to be created.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)