You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2009/01/20 12:14:29 UTC

[PATCH] Use local SQLite amalgamation in preference to system SQLite

I assume it would be better to use the local SQLite amalgamation, if
present, in preference to any SQLite installed on the system, if the
user doesn't specify otherwise. Currently, if there's a usable version
on the system it ignores the local amalgamation file.

Patch attached. Notice that the current comments on those lines of code
indicate that it was intended to be the way I'm saying.

Any reason why not?

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1037837

Re: [PATCH] Use local SQLite amalgamation in preference to system SQLite

Posted by Julian Foad <ju...@btopenworld.com>.
Stefan Sperling wrote:
> On Tue, Jan 20, 2009 at 12:14:29PM +0000, Julian Foad wrote:
> > I assume it would be better to use the local SQLite amalgamation, if
> > present, in preference to any SQLite installed on the system, if the
> > user doesn't specify otherwise. Currently, if there's a usable version
> > on the system it ignores the local amalgamation file.
> > 
> > Patch attached. Notice that the current comments on those lines of code
> > indicate that it was intended to be the way I'm saying.
> > 
> > Any reason why not?

> I'd say it does not matter at all what the default is, as long as it is
> very clearly documented, e.g. in the configure script's help output.

Well, it's not clearly documented, but at least the change makes it
consistent with how we look for e.g. Neon.

> As far as I can see, packagers would prefer to use the system sqlite
> so that bug fixes to the system's sqlite package benefit the Subversion
> package (see below). Developers (i.e. ourselves) or people compiling
> their own builds from tarballs might prefer the amalgamation because it
> is more convenient.


Committed in r35374.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1041592

Re: [PATCH] Use local SQLite amalgamation in preference to system SQLite

Posted by Stefan Sperling <st...@elego.de>.
On Tue, Jan 20, 2009 at 12:14:29PM +0000, Julian Foad wrote:
> I assume it would be better to use the local SQLite amalgamation, if
> present, in preference to any SQLite installed on the system, if the
> user doesn't specify otherwise. Currently, if there's a usable version
> on the system it ignores the local amalgamation file.
> 
> Patch attached. Notice that the current comments on those lines of code
> indicate that it was intended to be the way I'm saying.
> 
> Any reason why not?
> 

I'd say it does not matter at all what the default is, as long as it is
very clearly documented, e.g. in the configure script's help output.

As far as I can see, packagers would prefer to use the system sqlite
so that bug fixes to the system's sqlite package benefit the Subversion
package (see below). Developers (i.e. ourselves) or people compiling
their own builds from tarballs might prefer the amalgamation because it
is more convenient.

Stefan