You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by sz...@apache.org on 2008/10/21 01:35:26 UTC

svn commit: r706459 - in /hadoop/core/branches/branch-0.18: CHANGES.txt src/core/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java

Author: szetszwo
Date: Mon Oct 20 16:35:26 2008
New Revision: 706459

URL: http://svn.apache.org/viewvc?rev=706459&view=rev
Log:
HADOOP-4369. Use setMetric(...) instead of incrMetric(...) for metrics averages.
  Contributed by Brian Bockelman

Modified:
    hadoop/core/branches/branch-0.18/CHANGES.txt
    hadoop/core/branches/branch-0.18/src/core/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java

Modified: hadoop/core/branches/branch-0.18/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/branches/branch-0.18/CHANGES.txt?rev=706459&r1=706458&r2=706459&view=diff
==============================================================================
--- hadoop/core/branches/branch-0.18/CHANGES.txt (original)
+++ hadoop/core/branches/branch-0.18/CHANGES.txt Mon Oct 20 16:35:26 2008
@@ -31,6 +31,9 @@
     HADOOP-4399. Make fuse-dfs multi-thread access safe.
     (Pete Wyckoff via dhruba)
 
+    HADOOP-4369. Use setMetric(...) instead of incrMetric(...) for metrics
+    averages.  (Brian Bockelman via szetszwo)
+
   NEW FEATURES
 
     HADOOP-2421.  Add jdiff output to documentation, listing all API

Modified: hadoop/core/branches/branch-0.18/src/core/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java
URL: http://svn.apache.org/viewvc/hadoop/core/branches/branch-0.18/src/core/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java?rev=706459&r1=706458&r2=706459&view=diff
==============================================================================
--- hadoop/core/branches/branch-0.18/src/core/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java (original)
+++ hadoop/core/branches/branch-0.18/src/core/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java Mon Oct 20 16:35:26 2008
@@ -134,7 +134,7 @@
     intervalHeartBeat();
     try {
       mr.incrMetric(name + "_num_ops", getPreviousIntervalNumOps());
-      mr.incrMetric(name + "_avg_time", getPreviousIntervalAverageTime());
+      mr.setMetric(name + "_avg_time", getPreviousIntervalAverageTime());
     } catch (Exception e) {
       LOG.info("pushMetric failed for " + name + "\n" +
           StringUtils.stringifyException(e));