You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2026/02/25 12:26:15 UTC

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24032


Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................

IMPALA-14781: Use real host name in URL in dual stack webui

Before this patch :::25000 was used incorrectly instead of
hostname:25000. While listening to :: is needed for dual stack,
this url is only reachable on localhost. Note that ::: is also
incorrect because ipv6 addrsses in URLs should be bracketed: [::]:

Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
---
M be/src/util/network-util.cc
M tests/custom_cluster/test_ipv6.py
2 files changed, 15 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/24032/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24032 )

Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/21784/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 12:57:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24032 )

Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................

IMPALA-14781: Use real host name in URL in dual stack webui

Before this patch :::25000 was used incorrectly instead of
hostname:25000. While listening to :: is needed for dual stack,
this url is only reachable on localhost. Note that ::: is also
incorrect because ipv6 addresses in URLs should be bracketed: [::]:

Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Reviewed-on: http://gerrit.cloudera.org:8080/24032
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/network-util.cc
M tests/custom_cluster/test_ipv6.py
2 files changed, 15 insertions(+), 6 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Noemi Pap-Takacs, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24032

to look at the new patch set (#2).

Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................

IMPALA-14781: Use real host name in URL in dual stack webui

Before this patch :::25000 was used incorrectly instead of
hostname:25000. While listening to :: is needed for dual stack,
this url is only reachable on localhost. Note that ::: is also
incorrect because ipv6 addresses in URLs should be bracketed: [::]:

Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
---
M be/src/util/network-util.cc
M tests/custom_cluster/test_ipv6.py
2 files changed, 15 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/24032/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24032 )

Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 19:08:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/24032 )

Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24032/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24032/1//COMMIT_MSG@12
PS1, Line 12: addrsses
nit: addresses



-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 15:13:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24032 )

Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24032/2/tests/custom_cluster/test_ipv6.py
File tests/custom_cluster/test_ipv6.py:

http://gerrit.cloudera.org:8080/#/c/24032/2/tests/custom_cluster/test_ipv6.py@125
PS2, Line 125:     assert re.search(r'href="https?://.+:', html_resp)
> My plan was to match that too and then rule it out in the next assert.
Ah, ok. Have you manually verified that another configuration returns the hostname?



-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 17:40:19 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24032 )

Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24032/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24032/1//COMMIT_MSG@12
PS1, Line 12: addresse
> nit: addresses
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 16:27:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24032 )

Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24032/2/tests/custom_cluster/test_ipv6.py
File tests/custom_cluster/test_ipv6.py:

http://gerrit.cloudera.org:8080/#/c/24032/2/tests/custom_cluster/test_ipv6.py@125
PS2, Line 125:     assert re.search(r'href="https?://.+:', html_resp)
Should this assert the start of a hostname, i.e. alphanumeric character after `//`? It looks like it would still match 'http://:::'.



-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 16:58:43 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24032 )

Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13142/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 19:08:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24032 )

Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 23:26:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24032 )

Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 19:08:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24032 )

Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24032/2/tests/custom_cluster/test_ipv6.py
File tests/custom_cluster/test_ipv6.py:

http://gerrit.cloudera.org:8080/#/c/24032/2/tests/custom_cluster/test_ipv6.py@125
PS2, Line 125:     assert re.search(r'href="https?://.+:', html_resp)
> Should this assert the start of a hostname, i.e. alphanumeric character aft
My plan was to match that too and then rule it out in the next assert.
For ipv6 ::1 is returned in the test, so that should be accept - it is not a valid value in production, but works for the test.



-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 17:35:25 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14781: Use real host name in URL in dual stack webui

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24032 )

Change subject: IMPALA-14781: Use real host name in URL in dual stack webui
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24032/2/tests/custom_cluster/test_ipv6.py
File tests/custom_cluster/test_ipv6.py:

http://gerrit.cloudera.org:8080/#/c/24032/2/tests/custom_cluster/test_ipv6.py@125
PS2, Line 125:     assert re.search(r'href="https?://.+:', html_resp)
> Ah, ok. Have you manually verified that another configuration returns the h
I played with this only locally, with the fix the hostname is returned if Impala listens to ::. For ipv6 only I listened to ip6.impala.test, and it was returned correctly even before this change.



-- 
To view, visit http://gerrit.cloudera.org:8080/24032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I655cb0240008d60066f81a93a0ece3c0c75d00cb
Gerrit-Change-Number: 24032
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 17:57:24 +0000
Gerrit-HasComments: Yes