You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by st...@apache.org on 2005/01/21 00:09:15 UTC
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/repository Library.java
stevel 2005/01/20 15:09:15
Modified: src/main/org/apache/tools/ant/taskdefs/repository
Library.java
Log:
cleanup a few loose ends
Revision Changes Path
1.6 +5 -6 ant/src/main/org/apache/tools/ant/taskdefs/repository/Library.java
Index: Library.java
===================================================================
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/repository/Library.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- Library.java 6 Jan 2005 12:05:10 -0000 1.5
+++ Library.java 20 Jan 2005 23:09:15 -0000 1.6
@@ -72,7 +72,7 @@
private String destinationName;
/**
- * file mapped to this one
+ * this is a file reference which is created during binding
*/
private File libraryFile;
@@ -190,11 +190,11 @@
}
/**
- * set the library file.
- * @param libraryFile
+ * set the library file. Hidden from Ant users.
+ * @param file
*/
- public void setLibraryFile(File libraryFile) {
- this.libraryFile = libraryFile;
+ public void _setLibraryFile(File file) {
+ this.libraryFile = file;
}
/**
@@ -222,7 +222,6 @@
//adopt the name of the project if no archive is specced
archive=project;
}
- faultIfEmpty(archive, ERROR_NO_ARCHIVE);
faultIfEmpty(version, ERROR_NO_VERSION);
if(suffix==null) {
suffix="";
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/repository
Library.java
Posted by Peter Reilly <pe...@apache.org>.
Using _setXX for method names does not look nice.
Perhaps use another name for set (assign?) or split
up the class into a configuration class presented to ant and
an implementation class that actually does the processing.
Peter
stevel@apache.org wrote:
>stevel 2005/01/20 15:09:15
>
> Modified: src/main/org/apache/tools/ant/taskdefs/repository
> Library.java
> */
> - public void setLibraryFile(File libraryFile) {
> - this.libraryFile = libraryFile;
> + public void _setLibraryFile(File file) {
> + this.libraryFile = file;
> }
>
> /**
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>For additional commands, e-mail: dev-help@ant.apache.org
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org