You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/07/07 05:18:14 UTC
[PR] CAMEL-23912: Address review feedback on ThemeTest fix [camel]
gnodet opened a new pull request, #24482:
URL: https://github.com/apache/camel/pull/24482
_Claude Code on behalf of gnodet_
## Summary
Follow-up to #24475 — addresses review feedback from Copilot and @ammachado that landed after the original PR was merged.
**Changes:**
- **Handle null classloader** (Copilot): `Theme.class.getClassLoader()` can legally return `null` for bootstrap-loaded classes. Now null-checked before calling `getResourceAsStream()`, falling through to the TCCL fallback instead of throwing an NPE.
- **Soften javadoc wording** (@ammachado suggestion #1): Changed from "guaranteed to have access" to accurately describe the fallback behavior, so a future reader doesn't strip the TCCL fallback as dead code.
- **Revert `ConcurrentHashMap` to `HashMap`** (@ammachado suggestion #2): All `CACHE` access is already inside `synchronized` methods, so the concurrent map added no real safety — just a misleading signal.
## Test plan
- [x] All 6 `ThemeTest` tests pass.
- [x] `mvn formatter:format impsort:sort` produces no diff.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23912: Address review feedback on ThemeTest fix [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #24482:
URL: https://github.com/apache/camel/pull/24482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23912: Address review feedback on ThemeTest fix [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24482:
URL: https://github.com/apache/camel/pull/24482#issuecomment-4900573084
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `dsl/camel-jbang/camel-jbang-plugin-tui`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 2 tested, 1 compile-only — current: 2 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **3 affected modules** (current approach: 2).
<details><summary>:warning: Modules only in Scalpel (1)</summary>
- `camel-launcher`
</details>
**Skip-tests mode would test 2 modules** (1 direct + 1 downstream), **skip tests for 1** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (2)</summary>
- `camel-jbang-plugin-tui`
- `camel-launcher-container`
</details>
<details><summary>Modules with tests skipped (1)</summary>
- `camel-launcher`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>All tested modules (3 modules)</summary>
- Camel :: JBang :: Plugin :: TUI
- Camel :: Launcher
- Camel :: Launcher :: Container
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/28843425747)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23912: Address review feedback on ThemeTest fix [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24482:
URL: https://github.com/apache/camel/pull/24482#issuecomment-4900421663
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org