You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Paul Joseph Davis (JIRA)" <ji...@apache.org> on 2011/08/26 23:23:29 UTC

[jira] [Created] (COUCHDB-1262) View files are never fsynced

View files are never fsynced
----------------------------

                 Key: COUCHDB-1262
                 URL: https://issues.apache.org/jira/browse/COUCHDB-1262
             Project: CouchDB
          Issue Type: Bug
          Components: JavaScript View Server
            Reporter: Paul Joseph Davis


We don't fsync headers in view files. We should fix that.

First thought for a patch would be to pass the current db fsync options before_header and after_header to couch_file:write_header so that views and databases have the same level of configurable protection.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (COUCHDB-1262) View files are never fsynced

Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092068#comment-13092068 ] 

Adam Kocoloski commented on COUCHDB-1262:
-----------------------------------------

Seriously, though, I'd probably omit 'after_header' from the view group syncing.  If we re-index a handful of docs after a power failure it's no big deal.  The 'before_header' option is the much more important one.

There's some precedence for this in the compactor code, where it ignores options other than 'before_header' and only applies that option if it's set in the server config.

> View files are never fsynced
> ----------------------------
>
>                 Key: COUCHDB-1262
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1262
>             Project: CouchDB
>          Issue Type: Bug
>          Components: JavaScript View Server
>            Reporter: Paul Joseph Davis
>
> We don't fsync headers in view files. We should fix that.
> First thought for a patch would be to pass the current db fsync options before_header and after_header to couch_file:write_header so that views and databases have the same level of configurable protection.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (COUCHDB-1262) View files are never fsynced

Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092065#comment-13092065 ] 

Adam Kocoloski commented on COUCHDB-1262:
-----------------------------------------

+1000 (order-of-magnitude number of corrupted view files I've seen since I started working with CouchDB)

> View files are never fsynced
> ----------------------------
>
>                 Key: COUCHDB-1262
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1262
>             Project: CouchDB
>          Issue Type: Bug
>          Components: JavaScript View Server
>            Reporter: Paul Joseph Davis
>
> We don't fsync headers in view files. We should fix that.
> First thought for a patch would be to pass the current db fsync options before_header and after_header to couch_file:write_header so that views and databases have the same level of configurable protection.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira