[GitHub] [iceberg] big-guy commented on a change in pull request #2816: Gradle build cache optimization

[GitBox <gi...@apache.org>]

big-guy commented on a change in pull request #2816:
URL: https://github.com/apache/iceberg/pull/2816#discussion_r670396832



##########
File path: gradlew
##########
@@ -28,7 +28,7 @@ APP_NAME="Gradle"
 APP_BASE_NAME=`basename "$0"`
 
 # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
-DEFAULT_JVM_OPTS=""
+DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'

Review comment:
       > If you’re optimizing for build cache (and for gradle runtimes in general), I would think raising this might be beneficial. Particularly, for compiling scala code I usually see it recommended that the gradle JVM get more memory.
   
   @runningcode is correct.
   
   There's the client VM (environment variables DEFAULT_JVM_ARGS, GRADLE_OPTS and JAVA_OPTS all affect this), the Gradle daemon (controlled by org.gradle.jvmargs which can be set in several ways) and the _worker processes_ used by compilers (built in default, but adjustable in the build script). 
   
   So to affect Scala compilation, you'd have to tweak the last one (worker process).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org