[GitHub] chewbranca commented on a change in pull request #1199: Prevent access to Fauxton on node-local port (5986)

[GitBox <gi...@apache.org>]

chewbranca commented on a change in pull request #1199: Prevent access to Fauxton on node-local port (5986)
URL: https://github.com/apache/couchdb/pull/1199#discussion_r171996206
 
 

 ##########
 File path: src/couch/src/couch_httpd_misc_handlers.erl
 ##########
 @@ -61,22 +61,8 @@ handle_file_req(#httpd{method='GET'}=Req, Document) ->
 handle_file_req(Req, _) ->
     send_method_not_allowed(Req, "GET,HEAD").
 
-handle_utils_dir_req(#httpd{method='GET'}=Req, DocumentRoot) ->
-    "/" ++ UrlPath = couch_httpd:path(Req),
-    case couch_httpd:partition(UrlPath) of
-    {_ActionKey, "/", RelativePath} ->
-        % GET /_utils/path or GET /_utils/
-        CachingHeaders = [{"Cache-Control", "private, must-revalidate"}],
-        EnableCsp = config:get("csp", "enable", "false"),
-        Headers = maybe_add_csp_headers(CachingHeaders, EnableCsp),
-        couch_httpd:serve_file(Req, RelativePath, DocumentRoot, Headers);
-    {_ActionKey, "", _RelativePath} ->
-        % GET /_utils
-        RedirectPath = couch_httpd:path(Req) ++ "/",
-        couch_httpd:send_redirect(Req, RedirectPath)
-    end;
 handle_utils_dir_req(Req, _) ->
-    send_method_not_allowed(Req, "GET,HEAD").
+   throw({forbidden, <<"The Fauxton interface is no longer available on the node-local port.">>}).
 
 Review comment:
   This should be indented one space further in, eg 4 spaces instead of 3.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services