You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "hust-hhb (via GitHub)" <gi...@apache.org> on 2025/04/08 18:38:23 UTC
[PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
hust-hhb opened a new pull request, #49889:
URL: https://github.com/apache/doris/pull/49889
When sc fail, it will abort sc job by fe, however it forget to release delete bitmap lock, which will block data input.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2823454962
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2789599037
# BE UT Coverage Report
Increment line coverage `0.00% (0/9)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/349c226f587e134759b0873ee1ee955043ed262e_349c226f587e134759b0873ee1ee955043ed262e/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/349c226f587e134759b0873ee1ee955043ed262e_349c226f587e134759b0873ee1ee955043ed262e/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.34% (14070/26881) |
| Line Coverage | 41.13% (121545/295517) |
| Region Coverage | 39.86% (61845/155152) |
| Branch Coverage | 34.52% (30960/89694) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2789328529
<details>
<summary>ClickBench: <b>Total hot run time: 31.06 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 349c226f587e134759b0873ee1ee955043ed262e, data reload: false
query1 0.04 0.03 0.04
query2 0.13 0.11 0.10
query3 0.24 0.19 0.20
query4 1.59 0.19 0.19
query5 0.59 0.56 0.59
query6 1.21 0.73 0.71
query7 0.02 0.01 0.02
query8 0.04 0.03 0.04
query9 0.60 0.52 0.52
query10 0.58 0.60 0.57
query11 0.15 0.11 0.11
query12 0.14 0.11 0.11
query13 0.61 0.61 0.59
query14 2.77 2.71 2.80
query15 0.92 0.86 0.85
query16 0.39 0.39 0.39
query17 1.03 1.09 1.06
query18 0.21 0.20 0.20
query19 1.94 1.99 1.75
query20 0.01 0.01 0.01
query21 15.38 0.90 0.55
query22 0.76 1.09 0.69
query23 15.02 1.39 0.60
query24 7.03 1.96 0.73
query25 0.48 0.24 0.08
query26 0.63 0.17 0.15
query27 0.06 0.05 0.06
query28 9.78 0.90 0.42
query29 12.53 4.02 3.36
query30 0.24 0.09 0.06
query31 2.84 0.58 0.37
query32 3.24 0.55 0.47
query33 3.05 3.06 3.08
query34 15.55 5.08 4.48
query35 4.51 4.53 4.51
query36 0.66 0.50 0.49
query37 0.09 0.07 0.06
query38 0.06 0.04 0.04
query39 0.03 0.02 0.02
query40 0.17 0.12 0.13
query41 0.09 0.03 0.02
query42 0.04 0.03 0.02
query43 0.04 0.03 0.02
Total cold run time: 105.49 s
Total hot run time: 31.06 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "hust-hhb (via GitHub)" <gi...@apache.org>.
hust-hhb commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2789188300
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2822941422
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2823022898
<details>
<summary>ClickBench: <b>Total hot run time: 30 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6be70e0068dd67c31a13b76f8da29209af558d13, data reload: false
query1 0.03 0.04 0.02
query2 0.13 0.10 0.11
query3 0.26 0.19 0.19
query4 1.60 0.19 0.20
query5 0.60 0.59 0.60
query6 1.16 0.72 0.71
query7 0.02 0.02 0.02
query8 0.04 0.03 0.04
query9 0.57 0.53 0.52
query10 0.57 0.59 0.57
query11 0.15 0.11 0.11
query12 0.14 0.11 0.11
query13 0.61 0.60 0.59
query14 1.19 1.24 1.19
query15 0.86 0.85 0.85
query16 0.39 0.39 0.38
query17 1.02 1.01 1.03
query18 0.21 0.20 0.20
query19 2.00 1.78 1.79
query20 0.02 0.02 0.01
query21 15.41 0.88 0.53
query22 0.75 1.27 0.74
query23 14.79 1.37 0.64
query24 7.21 1.53 1.10
query25 0.55 0.16 0.09
query26 0.57 0.16 0.16
query27 0.06 0.05 0.04
query28 10.25 0.85 0.44
query29 12.52 3.93 3.30
query30 0.24 0.08 0.06
query31 2.83 0.59 0.39
query32 3.23 0.54 0.46
query33 3.01 3.07 3.13
query34 15.77 5.08 4.49
query35 4.55 4.56 4.52
query36 0.66 0.49 0.49
query37 0.08 0.06 0.06
query38 0.05 0.04 0.04
query39 0.04 0.03 0.02
query40 0.17 0.14 0.13
query41 0.08 0.03 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.02
Total cold run time: 104.46 s
Total hot run time: 30 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "hust-hhb (via GitHub)" <gi...@apache.org>.
hust-hhb commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2822926599
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2823006298
<details>
<summary>TPC-H: <b>Total hot run time: 33763 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6be70e0068dd67c31a13b76f8da29209af558d13, data reload: false
------ Round 1 ----------------------------------
q1 26050 5141 5006 5006
q2 2075 281 179 179
q3 10387 1247 694 694
q4 10227 993 533 533
q5 7566 2286 2368 2286
q6 179 164 133 133
q7 916 746 601 601
q8 9304 1302 1143 1143
q9 6825 5074 5112 5074
q10 6792 2297 1882 1882
q11 485 278 269 269
q12 352 355 213 213
q13 17780 3667 3063 3063
q14 219 220 205 205
q15 535 482 484 482
q16 451 450 397 397
q17 594 859 367 367
q18 7881 7196 7137 7137
q19 1223 937 545 545
q20 326 338 208 208
q21 4109 2656 2403 2403
q22 1082 1028 943 943
Total cold run time: 115358 ms
Total hot run time: 33763 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5100 5054 5048 5048
q2 233 323 231 231
q3 2200 2628 2313 2313
q4 1417 1798 1417 1417
q5 4520 4431 4387 4387
q6 214 165 127 127
q7 1970 1880 1764 1764
q8 2562 2557 2486 2486
q9 7165 7149 7200 7149
q10 2941 3159 2795 2795
q11 587 500 507 500
q12 719 756 607 607
q13 3509 3909 3233 3233
q14 285 285 270 270
q15 539 466 473 466
q16 454 508 468 468
q17 1178 1560 1363 1363
q18 7762 7493 7353 7353
q19 810 803 844 803
q20 1987 2094 1827 1827
q21 5066 4764 4667 4667
q22 1038 1043 997 997
Total cold run time: 52256 ms
Total hot run time: 50271 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2823005042
TeamCity cloud ut coverage result:
Function Coverage: 82.93% (1093/1318)
Line Coverage: 65.68% (18267/27813)
Region Coverage: 65.07% (9046/13903)
Branch Coverage: 55.03% (4870/8850)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6be70e0068dd67c31a13b76f8da29209af558d13_6be70e0068dd67c31a13b76f8da29209af558d13_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "hust-hhb (via GitHub)" <gi...@apache.org>.
hust-hhb commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2787355753
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2789313095
<details>
<summary>TPC-DS: <b>Total hot run time: 193360 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 349c226f587e134759b0873ee1ee955043ed262e, data reload: false
query1 1411 1080 1043 1043
query2 6016 1965 1956 1956
query3 11021 4273 4403 4273
query4 53198 25483 23238 23238
query5 5108 557 454 454
query6 334 197 189 189
query7 4882 500 278 278
query8 306 253 247 247
query9 5510 2624 2606 2606
query10 468 321 277 277
query11 15112 15164 14883 14883
query12 168 115 106 106
query13 1044 525 390 390
query14 10163 6356 6393 6356
query15 188 200 182 182
query16 7116 701 501 501
query17 1097 791 608 608
query18 1565 427 324 324
query19 212 204 177 177
query20 136 136 127 127
query21 219 135 111 111
query22 4279 4388 4469 4388
query23 34171 33350 33399 33350
query24 6875 2419 2428 2419
query25 458 470 406 406
query26 734 282 162 162
query27 2426 508 347 347
query28 3130 2504 2467 2467
query29 582 579 427 427
query30 274 274 202 202
query31 869 897 820 820
query32 73 63 63 63
query33 463 377 339 339
query34 791 891 523 523
query35 794 837 769 769
query36 954 990 896 896
query37 117 103 73 73
query38 4156 4268 4148 4148
query39 1521 1472 1445 1445
query40 215 121 109 109
query41 54 55 51 51
query42 119 101 101 101
query43 505 522 496 496
query44 1343 839 820 820
query45 178 180 165 165
query46 845 1036 646 646
query47 1876 1913 1857 1857
query48 407 417 314 314
query49 681 520 454 454
query50 669 693 404 404
query51 4331 4255 4228 4228
query52 114 110 101 101
query53 228 262 196 196
query54 592 585 516 516
query55 84 86 83 83
query56 309 312 291 291
query57 1151 1219 1166 1166
query58 283 267 269 267
query59 2857 2802 2682 2682
query60 349 323 304 304
query61 135 131 125 125
query62 735 752 704 704
query63 226 195 188 188
query64 1953 1064 733 733
query65 4449 4447 4354 4354
query66 763 407 316 316
query67 16004 15896 15284 15284
query68 7504 892 514 514
query69 537 298 261 261
query70 1219 1139 1076 1076
query71 495 334 296 296
query72 5903 4748 4838 4748
query73 1447 637 344 344
query74 8999 9138 8920 8920
query75 4010 3239 2809 2809
query76 4294 1200 762 762
query77 712 365 283 283
query78 10215 10104 9277 9277
query79 6632 808 547 547
query80 649 521 436 436
query81 483 255 217 217
query82 735 134 103 103
query83 325 258 237 237
query84 297 107 84 84
query85 779 351 311 311
query86 358 291 288 288
query87 4388 4464 4443 4443
query88 3612 2200 2188 2188
query89 464 319 285 285
query90 1991 208 208 208
query91 136 140 107 107
query92 73 57 60 57
query93 3604 952 573 573
query94 677 424 298 298
query95 363 298 290 290
query96 477 575 269 269
query97 3172 3226 3123 3123
query98 236 206 202 202
query99 1410 1404 1279 1279
Total cold run time: 305592 ms
Total hot run time: 193360 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2822962365
<details>
<summary>TPC-H: <b>Total hot run time: 34211 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 36fe8eb17ad12eacbf549259f25ce82086cf9c19, data reload: false
------ Round 1 ----------------------------------
q1 26411 5062 5070 5062
q2 2061 273 190 190
q3 10397 1249 705 705
q4 10230 998 553 553
q5 7503 2380 2376 2376
q6 184 160 136 136
q7 911 731 599 599
q8 9311 1253 1072 1072
q9 6715 5073 5088 5073
q10 6816 2291 1898 1898
q11 469 279 266 266
q12 352 357 213 213
q13 17764 3686 3167 3167
q14 228 234 212 212
q15 541 475 480 475
q16 445 456 410 410
q17 630 873 353 353
q18 7691 7187 7175 7175
q19 1219 935 572 572
q20 324 339 231 231
q21 4231 3415 2477 2477
q22 1025 999 996 996
Total cold run time: 115458 ms
Total hot run time: 34211 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5109 5110 5090 5090
q2 238 333 227 227
q3 2171 2710 2321 2321
q4 1425 1801 1436 1436
q5 4479 4401 4436 4401
q6 213 167 129 129
q7 2010 1933 1764 1764
q8 2598 2626 2583 2583
q9 7239 7142 7089 7089
q10 3012 3188 2753 2753
q11 577 498 466 466
q12 701 746 603 603
q13 3534 3907 3369 3369
q14 283 322 289 289
q15 528 487 462 462
q16 468 504 468 468
q17 1136 1426 1413 1413
q18 7809 7568 7460 7460
q19 884 892 1102 892
q20 2028 1972 1830 1830
q21 5226 4918 4826 4826
q22 1103 1028 1031 1028
Total cold run time: 52771 ms
Total hot run time: 50899 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "zhannngchen (via GitHub)" <gi...@apache.org>.
zhannngchen merged PR #49889:
URL: https://github.com/apache/doris/pull/49889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "hust-hhb (via GitHub)" <gi...@apache.org>.
hust-hhb commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2787377155
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2822941346
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2823017820
<details>
<summary>TPC-DS: <b>Total hot run time: 184559 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6be70e0068dd67c31a13b76f8da29209af558d13, data reload: false
query1 1019 492 495 492
query2 6545 1765 1813 1765
query3 6751 233 216 216
query4 26596 23541 22969 22969
query5 4337 609 468 468
query6 324 201 196 196
query7 4617 484 285 285
query8 300 249 237 237
query9 8633 2563 2576 2563
query10 496 330 259 259
query11 15611 15094 14800 14800
query12 161 109 104 104
query13 1635 528 391 391
query14 8569 6078 6056 6056
query15 195 185 172 172
query16 7129 661 484 484
query17 962 705 579 579
query18 1974 396 310 310
query19 197 189 165 165
query20 125 118 116 116
query21 213 135 105 105
query22 4090 4159 4030 4030
query23 34011 32983 32992 32983
query24 8401 2346 2323 2323
query25 517 443 379 379
query26 1258 269 149 149
query27 2767 490 337 337
query28 4347 2083 2073 2073
query29 756 543 434 434
query30 328 212 190 190
query31 932 835 784 784
query32 74 62 64 62
query33 551 364 294 294
query34 770 830 506 506
query35 776 830 727 727
query36 937 975 873 873
query37 113 105 97 97
query38 4108 4103 4101 4101
query39 1428 1403 1395 1395
query40 208 123 117 117
query41 58 56 55 55
query42 124 100 106 100
query43 486 503 444 444
query44 1346 798 792 792
query45 178 171 166 166
query46 839 1017 617 617
query47 1752 1811 1719 1719
query48 382 415 301 301
query49 776 499 409 409
query50 644 684 387 387
query51 4102 4101 3992 3992
query52 103 100 102 100
query53 225 257 182 182
query54 580 568 496 496
query55 85 76 80 76
query56 316 298 302 298
query57 1123 1134 1066 1066
query58 263 256 254 254
query59 2541 2631 2543 2543
query60 326 338 316 316
query61 131 126 121 121
query62 828 759 654 654
query63 224 192 187 187
query64 4350 1002 667 667
query65 4318 4226 4221 4221
query66 1136 409 308 308
query67 15941 15637 15264 15264
query68 7775 874 508 508
query69 484 293 260 260
query70 1221 1151 1080 1080
query71 407 320 297 297
query72 5700 4682 4747 4682
query73 622 596 342 342
query74 8979 9029 8567 8567
query75 3287 3202 2651 2651
query76 3229 1193 755 755
query77 524 377 284 284
query78 9842 9730 9245 9245
query79 2453 802 562 562
query80 631 509 446 446
query81 500 245 219 219
query82 480 127 98 98
query83 254 241 229 229
query84 301 104 95 95
query85 844 419 372 372
query86 376 308 293 293
query87 4295 4333 4352 4333
query88 3826 2219 2225 2219
query89 382 312 283 283
query90 1878 221 220 220
query91 140 146 112 112
query92 71 59 58 58
query93 2072 933 573 573
query94 713 423 313 313
query95 376 293 275 275
query96 492 555 278 278
query97 3078 3204 3108 3108
query98 247 213 206 206
query99 1313 1388 1275 1275
Total cold run time: 272730 ms
Total hot run time: 184559 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2789211542
TeamCity cloud ut coverage result:
Function Coverage: 83.07% (1089/1311)
Line Coverage: 66.09% (18167/27488)
Region Coverage: 65.54% (8951/13657)
Branch Coverage: 55.35% (4820/8708)
Coverage Report: http://coverage.selectdb-in.cc/coverage/349c226f587e134759b0873ee1ee955043ed262e_349c226f587e134759b0873ee1ee955043ed262e_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2822978732
<details>
<summary>ClickBench: <b>Total hot run time: 29.15 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 36fe8eb17ad12eacbf549259f25ce82086cf9c19, data reload: false
query1 0.04 0.03 0.03
query2 0.14 0.11 0.12
query3 0.26 0.19 0.19
query4 1.60 0.20 0.21
query5 0.58 0.58 0.59
query6 1.18 0.72 0.72
query7 0.02 0.01 0.02
query8 0.04 0.04 0.04
query9 0.58 0.54 0.50
query10 0.57 0.57 0.56
query11 0.15 0.11 0.11
query12 0.14 0.12 0.12
query13 0.62 0.59 0.60
query14 1.15 1.17 1.19
query15 0.87 0.85 0.84
query16 0.37 0.38 0.38
query17 1.05 1.04 1.03
query18 0.21 0.19 0.19
query19 1.83 1.77 1.80
query20 0.02 0.02 0.01
query21 15.40 0.91 0.55
query22 0.76 1.07 0.64
query23 15.09 1.39 0.65
query24 8.00 0.80 0.38
query25 0.48 0.21 0.16
query26 0.60 0.16 0.13
query27 0.05 0.06 0.05
query28 9.31 0.88 0.43
query29 12.59 4.03 3.35
query30 0.25 0.10 0.07
query31 2.81 0.59 0.38
query32 3.23 0.55 0.46
query33 3.01 2.99 3.06
query34 15.84 5.09 4.47
query35 4.51 4.51 4.51
query36 0.67 0.50 0.48
query37 0.09 0.06 0.06
query38 0.05 0.04 0.03
query39 0.03 0.02 0.03
query40 0.18 0.13 0.12
query41 0.08 0.03 0.02
query42 0.03 0.03 0.02
query43 0.03 0.03 0.03
Total cold run time: 104.51 s
Total hot run time: 29.15 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2823202533
# BE UT Coverage Report
Increment line coverage `0.00% (0/14)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/6be70e0068dd67c31a13b76f8da29209af558d13_6be70e0068dd67c31a13b76f8da29209af558d13/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/6be70e0068dd67c31a13b76f8da29209af558d13_6be70e0068dd67c31a13b76f8da29209af558d13/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.54% (14536/27150) |
| Line Coverage | 42.37% (126011/297419) |
| Region Coverage | 41.18% (64401/156378) |
| Branch Coverage | 35.76% (32372/90526) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2822949457
TeamCity cloud ut coverage result:
Function Coverage: 82.93% (1093/1318)
Line Coverage: 65.64% (18258/27814)
Region Coverage: 65.04% (9043/13904)
Branch Coverage: 55.01% (4868/8850)
Coverage Report: http://coverage.selectdb-in.cc/coverage/36fe8eb17ad12eacbf549259f25ce82086cf9c19_36fe8eb17ad12eacbf549259f25ce82086cf9c19_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2787398724
TeamCity cloud ut coverage result:
Function Coverage: 83.07% (1089/1311)
Line Coverage: 66.08% (18166/27493)
Region Coverage: 65.52% (8950/13659)
Branch Coverage: 55.33% (4819/8710)
Coverage Report: http://coverage.selectdb-in.cc/coverage/886e2b0e5bd9d1ee24d0755a5b39eba38669e611_886e2b0e5bd9d1ee24d0755a5b39eba38669e611_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2789264993
<details>
<summary>TPC-H: <b>Total hot run time: 34364 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 349c226f587e134759b0873ee1ee955043ed262e, data reload: false
------ Round 1 ----------------------------------
q1 26061 5087 4975 4975
q2 2064 273 186 186
q3 10431 1267 671 671
q4 10232 990 520 520
q5 7624 2448 2375 2375
q6 186 164 135 135
q7 929 727 606 606
q8 9317 1290 1119 1119
q9 6789 5166 5118 5118
q10 6851 2323 1865 1865
q11 487 287 281 281
q12 353 354 218 218
q13 17947 3863 3255 3255
q14 226 233 217 217
q15 539 500 489 489
q16 643 619 600 600
q17 629 871 386 386
q18 7680 7298 7149 7149
q19 1702 931 540 540
q20 331 350 239 239
q21 4551 3555 2486 2486
q22 1035 1026 934 934
Total cold run time: 116607 ms
Total hot run time: 34364 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5172 5038 5027 5027
q2 237 318 226 226
q3 2151 2614 2241 2241
q4 1421 1849 1493 1493
q5 4460 4475 4421 4421
q6 220 175 131 131
q7 1979 1902 1730 1730
q8 2567 2419 2471 2419
q9 7266 7037 7053 7037
q10 2992 3188 2752 2752
q11 562 512 485 485
q12 658 768 619 619
q13 3564 3864 3397 3397
q14 284 307 276 276
q15 535 494 486 486
q16 671 692 633 633
q17 1139 1552 1374 1374
q18 7711 7650 7532 7532
q19 833 821 811 811
q20 1909 1981 1815 1815
q21 5381 4830 4904 4830
q22 1126 1061 1018 1018
Total cold run time: 52838 ms
Total hot run time: 50753 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2787355394
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on code in PR #49889:
URL: https://github.com/apache/doris/pull/49889#discussion_r2055154524
##########
be/src/cloud/cloud_schema_change_job.cpp:
##########
@@ -541,6 +542,9 @@ Status CloudSchemaChangeJob::_process_delete_bitmap(int64_t alter_version,
}
void CloudSchemaChangeJob::clean_up_on_failed() {
+ _cloud_storage_engine.meta_mgr().remove_delete_bitmap_update_lock(
Review Comment:
call remove_delete_bitmap_update_lock only when this is a mow tablet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "zhannngchen (via GitHub)" <gi...@apache.org>.
zhannngchen commented on code in PR #49889:
URL: https://github.com/apache/doris/pull/49889#discussion_r2055172769
##########
be/src/cloud/cloud_schema_change_job.cpp:
##########
@@ -541,6 +542,9 @@ Status CloudSchemaChangeJob::_process_delete_bitmap(int64_t alter_version,
}
void CloudSchemaChangeJob::clean_up_on_failed() {
+ _cloud_storage_engine.meta_mgr().remove_delete_bitmap_update_lock(
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2822973894
<details>
<summary>TPC-DS: <b>Total hot run time: 191919 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 36fe8eb17ad12eacbf549259f25ce82086cf9c19, data reload: false
query1 1424 1069 1037 1037
query2 6343 1810 1805 1805
query3 10996 4699 4429 4429
query4 54291 25911 23418 23418
query5 4997 522 443 443
query6 342 196 190 190
query7 4904 496 278 278
query8 333 256 236 236
query9 5723 2589 2572 2572
query10 431 315 250 250
query11 15160 15027 14741 14741
query12 158 110 107 107
query13 1032 521 379 379
query14 10184 6322 6373 6322
query15 203 206 186 186
query16 7124 660 507 507
query17 1113 768 599 599
query18 1556 415 319 319
query19 217 198 171 171
query20 131 129 124 124
query21 208 122 108 108
query22 4337 4374 4263 4263
query23 34014 33588 33530 33530
query24 6395 2424 2392 2392
query25 505 463 417 417
query26 707 281 159 159
query27 2535 516 338 338
query28 2896 2145 2123 2123
query29 603 553 434 434
query30 265 280 191 191
query31 864 873 786 786
query32 72 65 64 64
query33 435 386 309 309
query34 1054 855 506 506
query35 789 850 778 778
query36 968 999 900 900
query37 122 102 81 81
query38 4215 4308 4201 4201
query39 1474 1443 1412 1412
query40 216 127 106 106
query41 60 85 52 52
query42 119 108 120 108
query43 502 523 473 473
query44 1358 837 820 820
query45 182 179 176 176
query46 849 1021 637 637
query47 1811 1889 1827 1827
query48 382 416 311 311
query49 699 512 418 418
query50 655 701 418 418
query51 4260 4278 4167 4167
query52 107 104 101 101
query53 258 270 196 196
query54 578 566 503 503
query55 86 77 78 77
query56 290 302 317 302
query57 1162 1173 1123 1123
query58 275 256 267 256
query59 2582 2752 2675 2675
query60 350 334 309 309
query61 132 128 127 127
query62 750 782 698 698
query63 225 186 186 186
query64 2049 1026 673 673
query65 4451 4273 4251 4251
query66 827 397 298 298
query67 15796 15312 15186 15186
query68 7450 885 514 514
query69 544 296 251 251
query70 1203 1073 1061 1061
query71 505 304 298 298
query72 5534 4834 4832 4832
query73 1400 607 345 345
query74 9206 8858 8682 8682
query75 3927 3186 2698 2698
query76 4240 1194 761 761
query77 627 366 265 265
query78 10163 10098 9208 9208
query79 2570 818 554 554
query80 637 501 434 434
query81 485 249 217 217
query82 446 127 96 96
query83 340 250 240 240
query84 293 111 85 85
query85 843 357 312 312
query86 371 322 304 304
query87 4449 4389 4309 4309
query88 3641 2222 2210 2210
query89 405 331 276 276
query90 1796 204 203 203
query91 140 144 116 116
query92 72 64 56 56
query93 1977 934 575 575
query94 660 408 300 300
query95 372 292 284 284
query96 489 560 267 267
query97 3185 3173 3122 3122
query98 233 204 277 204
query99 1426 1401 1261 1261
Total cold run time: 299760 ms
Total hot run time: 191919 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "hust-hhb (via GitHub)" <gi...@apache.org>.
hust-hhb commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2822985474
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #49889:
URL: https://github.com/apache/doris/pull/49889#issuecomment-2823527882
# BE Regression P0 && UT Coverage Report
Increment line coverage `0.00% (0/14)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/49889_6be70e0068dd67c31a13b76f8da29209af558d13_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/49889_6be70e0068dd67c31a13b76f8da29209af558d13_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | |
| Line Coverage | |
| Region Coverage | |
| Branch Coverage | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org