[GitHub] dubeejw commented on a change in pull request #3018: remove swift3.0 support

[GitBox <gi...@apache.org>]

dubeejw commented on a change in pull request #3018: remove swift3.0 support
URL: https://github.com/apache/incubator-openwhisk/pull/3018#discussion_r154249977
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/entity/test/ExecHelpers.scala
 ##########
 @@ -36,10 +36,15 @@ trait ExecHelpers extends Matchers with WskActorSystem with StreamLogging {
   protected val NODEJS = "nodejs"
   protected val NODEJS6 = "nodejs:6"
   protected val SWIFT = "swift"
-  protected val SWIFT3 = "swift:3"
-
-  protected def imagename(name: String) =
-    ExecManifest.ImageName(s"${name}action".replace(":", ""), Some("openwhisk"), Some("latest"))
+  protected val SWIFT3 = "swift:3.1.1"
+
+  protected def imagename(name: String) = {
+    var image = s"${name}action".replace(":", "")
+    if (name.equals("swift:3.1.1")) {
 
 Review comment:
   Use `SWIFT3` instead of `"swift:3.1.1"`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services